chore(ci): remove the merged one-shot PR-909 conflict-resolver workflow - #920
Merged
Conversation
PR #909 (fix/batch-routing-owner-20260829) merged 2026-08-29. This push-triggered, self-modifying workflow (top-level contents:write + pull-requests:write, calling a reusable workflow from an unpinned automation branch ref) has no PR left to resolve and is now a standing security liability rather than doing useful work — matching the pattern Scorecard flagged on the equivalent PR-868 resolver.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough지정 브랜치 push 시 PR 909를 처리하던 GitHub Actions 워크플로 파일을 삭제했습니다. 관련 권한 설정도 함께 제거되었습니다. Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change removes an obsolete one-shot workflow without modifying runtime code or introducing a current merge-blocking risk; it is merge-ready after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
seonghobae
pushed a commit
that referenced
this pull request
Aug 30, 2026
…ar fix .github#1436 merged (admin bypass, structurally deadlocked check — evidence on the PR). Re-queued opencode-review/noema-review/strix on this PR plus #911/#920 as the live canary: the specific max_tokens 502 symptom is confirmed fixed, but noema-review still failed with a distinct signature (bytez discovery 500 + preflight finding zero passing routes). Records what's confirmed, what's still open, and the working hypothesis (concurrent-run rate-limit contention) pending a clean re-observation.
seonghobae
added a commit
that referenced
this pull request
Aug 30, 2026
#921) * docs(gap-baseline): record the sidecar preflight max_tokens root cause Fulfills the reference added in .github#1436's code comment (Devin flagged it as a missing baseline entry when it merely pointed at a not-yet-written one). Records the exact-evidence trail (downloaded strix-reports artifact from this repo's own PR #912 run) that this repo's PRs cannot fix directly since the sidecar is central-.github-owned infrastructure. * docs(gap-baseline): record the post-merge canary result for the sidecar fix .github#1436 merged (admin bypass, structurally deadlocked check — evidence on the PR). Re-queued opencode-review/noema-review/strix on this PR plus #911/#920 as the live canary: the specific max_tokens 502 symptom is confirmed fixed, but noema-review still failed with a distinct signature (bytez discovery 500 + preflight finding zero passing routes). Records what's confirmed, what's still open, and the working hypothesis (concurrent-run rate-limit contention) pending a clean re-observation. * docs(gap-baseline): correct the reasoning-starvation mechanism claim Devin flagged (on #921) that ModelClient._response_content returns successfully for any string content, including "", so the entry's "reasoning consumes the budget, content comes back empty" narrative doesn't match the code, and the generic error message quoted implies a narrower condition (non-string/absent content, reasoning falsy) than originally claimed. Verified against the code and the original strix-reports artifact (no raw provider payload was ever captured — sanitized by design), corrected the entry to state what's actually evidenced (budget mismatch reproduces, matching it fixes it) versus what was an unverified hypothesis, and noted the fix's own tests target a different, stricter function (the launcher's own preflight content check) that is unaffected by this correction. * docs(gap-baseline): replace the rate-limit hypothesis with confirmed evidence Downloaded and inspected the actual strix-reports artifact instead of continuing to speculate: the real causes were (1) noema-review/ opencode-review having zero visibility into per-route preflight rejection reasons, and (2) the gateway preflight's 30s curl timeout cutting off a route the routing probe had just proven healthy in 18s. Both fixed and RED/GREEN-tested in ContextualWisdomLab/.github#1440. * docs(gap-baseline): restate the retracted hypothesis instead of a dangling "above" Devin caught it on #921: the previous edit deleted the paragraph stating the rate-limit hypothesis while the replacement text still said "the hypothesis above," leaving nothing for that reference to point to. Restated it inline. * docs(gap-baseline): record the full incident timeline (checker tightened 8/27, gateway check broke 8/29) Investigated whether .github's opencode-review verdict-checker itself was defective, since it's been failing org-wide for days. It isn't: git history shows it was a rubber stamp (always exit 0) until 8/27, when it was correctly rewritten to require a real matching review. Two days later, 8/29's "exercise exact gateway readiness" commit introduced the end-to-end gateway check that shipped with the max_tokens:16 bug (#1436 fixed today). The now-strict checker collided with a newly-broken dispatch path, not a checker design flaw. Confirmed via #1246: last real opencode-agent review was 8/23, none since despite the head moving forward repeatedly. * docs(gap-baseline): fix two stale/inaccurate claims CodeRabbit flagged 1. Softened "will resolve on the scheduler's next pass" to not assert an outcome that hasn't been verified. 2. Removed the false implication that the routing probe's 10s per-candidate timeout says anything about the separate gateway curl timeout completing in time -- especially now stale since that curl timeout was raised 30s->120s in .github#1440 after being found too tight for real reasoning-model latency. --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve-pr-909-v2.ymlwas a push-triggered, self-modifying workflow scoped tofix/batch-routing-owner-20260829(PR #909). PR #909 merged on 2026-08-29 — the branch it triggers on no longer exists as an open PR, so this workflow has no remaining purpose.Leaving it in place is a standing risk, not idle: it carries top-level
contents: write+pull-requests: writepermissions and calls a reusable workflow from an unpinned automation branch ref (@automation/one-shot-pr-conflict-resolver). This is the same pattern OSSF Scorecard flagged (1 high, 1 medium) on the equivalentresolve-pr-868.ymlfile, which I removed from PR #868 in this same cycle for the same reason.Validation
git diff --checkclean.Generated by Claude Code
Summary by CodeRabbit