Skip to content

fix: preserve budget stops during generated planning - #813

Merged
seonghobae merged 7 commits into
ContextualWisdomLab:fix/auto-reasoning-effort-contract-rebasedfrom
seonghobae:repair/pr810-budget-stop-v2203
Aug 21, 2026
Merged

fix: preserve budget stops during generated planning#813
seonghobae merged 7 commits into
ContextualWisdomLab:fix/auto-reasoning-effort-contract-rebasedfrom
seonghobae:repair/pr810-budget-stop-v2203

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Change

  • re-raise BudgetExceededError before generated-plan template fallback
  • add a regression proving budget exhaustion does not invoke _plan

Parent

Validation

  • pytest tests/test_generated_workflow.py tests/test_budget_enforcement.py (15 passed)
  • python -m compileall -q contextual_orchestrator tests
  • changed-test ruff --select F,E9
  • git diff --check

This preserves the ADR 0014 hard budget stop and includes no credentials or real data.


Open in Devin Review

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 13:02
@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 46d8ad17-59c5-4fa1-85bb-17ad849395c4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Maintainer exact-head audit: remote head 6e5e193, base 5379157. The PR tree is equivalent to the locally verified #810 follow-up tree: budget-stop re-raise plus regression coverage. Formal approvals are 0. Hosted checks are 17 total with 8 skipped and 9 queued, no failures. The equivalent local tree passed the full 1646-test suite, compileall, actionlint, diff-check, Semgrep, and pip-audit. Decision: WAIT_AND_REMEDIATE; no merge or bypass.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 5 potential issues.

Open in Devin Review

Comment thread contextual_orchestrator/orchestrator.py
Comment thread contextual_orchestrator/orchestrator.py
Comment thread contextual_orchestrator/orchestrator.py
Comment thread contextual_orchestrator/cost_router.py
Comment thread contextual_orchestrator/orchestrator.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant