Skip to content

docs: complete public docstring coverage - #809

Merged
seonghobae merged 2 commits into
mainfrom
docs/complete-public-docstring-coverage
Aug 24, 2026
Merged

docs: complete public docstring coverage#809
seonghobae merged 2 commits into
mainfrom
docs/complete-public-docstring-coverage

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add the missing public docstrings in the telemetry ledger and HTTP request handler.
  • No runtime behavior, API, authorization, or dependency changes.
  • This closes the repository docstring quality gap from 95.8% to 100%.

Exact-head verification

  • Head: 756d2a7
  • Full pytest: 1435 passed in 538.77s
  • Focused ledger/server tests: 22 passed
  • interrogate: 100.0%
  • compileall: passed
  • actionlint: passed
  • git diff --check: passed
  • Semgrep Python and secrets: 0 findings; existing rule timeout warnings only
  • pip-audit against requirements.lock: no known vulnerabilities

This is a normal protected PR. No bypass, direct protected-branch push, fake status, self-approval, or force push was used.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 31 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 116f7cd5-9b8a-4d45-a7e2-3096828edaea

📥 Commits

Reviewing files that changed from the base of the PR and between 84a40cb and 11fa228.

📒 Files selected for processing (2)
  • contextual_orchestrator/cost_ledger.py
  • contextual_orchestrator/server.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review update

  • Exact head: 756d2a76bb91c0c65aac6c15bbab8270dd0ea479
  • Exact base: e226e1197bdfc890c9d8e5b9b648c78857d7e465
  • Scope: two files; public docstrings were added for the usage telemetry methods and HTTP handler methods.
  • Exact-head interrogate: 100.0% (minimum 80%)
  • compileall and git diff --check: passed
  • Live hosted checks: 21 success, 8 skipped, 2 neutral; formal approvals: 0.

No source finding remains in the bounded documentation diff. Decision remains WAIT_AND_REMEDIATE until the protected required approval is present; no merge or bypass was performed.

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 16:49
@opencode-agent opencode-agent Bot added area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: docs Documentation, ADR, PRD, or technical writing labels Aug 22, 2026
@seonghobae

Copy link
Copy Markdown
Contributor Author

Merge-gate evidence (2026-08-24)

All required checks green on current head except strix, which fails closed because the org's shared NVIDIA NIM key is returning litellm.RateLimitError (see runs 32646490187 / 32707494858: Nvidia_nimException - Error code 429 across primary and all fallback models, including the openai-direct fallback). Root cause + systemic fix (per-repository scan serialization): ContextualWisdomLab/.github#1297.

This is an external provider-capacity blocker, not a finding against this diff. Local evidence: full suite green on the rebased head; docstring additions are behavior-neutral (+12/-0).

@seonghobae
seonghobae merged commit fec64dd into main Aug 24, 2026
30 of 31 checks passed
@seonghobae
seonghobae deleted the docs/complete-public-docstring-coverage branch August 24, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: docs Documentation, ADR, PRD, or technical writing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant