Skip to content

fix: restore test contract lintability - #799

Closed
seonghobae wants to merge 1 commit into
mainfrom
fix/ruff-test-contract-baseline
Closed

fix: restore test contract lintability#799
seonghobae wants to merge 1 commit into
mainfrom
fix/ruff-test-contract-baseline

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Customer outcome

The repository-wide Ruff gate is green again without changing runtime behavior. Directly executable HTTP honesty tests now call their actual test names, the null/empty-functions payload has one unambiguous JSON key, and the security test no longer carries an unused import.

Verification

  • ruff check .
  • git diff --check
  • focused HTTP honesty/security tests: 38 passed

This PR is intentionally independent of the feature stacks. Merge only through the protected current-head review and Checks path; no self-approval or bypass.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a7a99391-a9e4-4cd7-8764-afc19f8e068f

📥 Commits

Reviewing files that changed from the base of the PR and between e226e11 and 0eb0a9b.

📒 Files selected for processing (4)
  • tests/test_chat_tools_shape_http_honesty.py
  • tests/test_functions_null_max_tool_calls_null_http_honesty.py
  • tests/test_responses_tools_shape_http_honesty.py
  • tests/test_security_hardening.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 01:05
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head validation — PR #799

  • Current HEAD: 0eb0a9b7323b9de17311c0b990838c71de644d00
  • Repository-wide ruff check .: passed.
  • Focused HTTP honesty/security regressions: 38 passed.
  • git diff --check: passed.
  • The patch only restores test-contract names, removes an impossible duplicate JSON key, and removes an unused import; runtime production behavior is unchanged.
  • Auto-merge is enabled; current live PR remains BLOCKED/REVIEW_REQUIRED while protected Checks and independent approval are pending.

@opencode-agent please review only exact current HEAD 0eb0a9b7323b9de17311c0b990838c71de644d00; verify the lint findings are fully resolved without weakening tests or changing runtime behavior. Do not approve or merge.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@opencode-agent
opencode-agent Bot disabled auto-merge August 21, 2026 03:01
@opencode-agent opencode-agent Bot added area: api API, protocol, event, or external contract area: operations Operability, observability, readiness, SLO, backup, or retention priority: medium Normal-priority or P2 work scope: product-gap Customer-visible product gap status: needs-review Open pull request requiring current-head review or checks type: bug Defect or incorrect behavior labels Aug 22, 2026
@seonghobae
seonghobae enabled auto-merge (squash) August 24, 2026 00:53
@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded by #771 (merged): the identical lint-contract fixes are already on main (84a40cb), so this branch adds zero delta against current main. Closing as redundant; no content is lost.

@seonghobae seonghobae closed this Aug 24, 2026
auto-merge was automatically disabled August 24, 2026 08:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: api API, protocol, event, or external contract area: operations Operability, observability, readiness, SLO, backup, or retention priority: medium Normal-priority or P2 work scope: product-gap Customer-visible product gap status: needs-review Open pull request requiring current-head review or checks type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant