feat: add contextual review gateway bootstrap - #790
Conversation
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head8d31fa50cc6de8ddc3e6b91576e7251c5aa7d914. -
Head SHA:
8d31fa50cc6de8ddc3e6b91576e7251c5aa7d914 -
Workflow run: 32702062450
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (7 files)"]
S1 --> I1["repository behavior"]
I1 --> Conflict["Merge conflict blocks this path"]
Conflict --> V1["required checks"]
Evidence --> S2["Docs (2 files)"]
S2 --> I2["operator or user guidance"]
I2 --> Conflict["Merge conflict blocks this path"]
Conflict --> V2["docs review"]
Evidence --> S3["Test (10 files)"]
S3 --> I3["regression suite"]
I3 --> Conflict["Merge conflict blocks this path"]
Conflict --> V3["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (7 files)"]
S1 --> I1["repository behavior"]
I1 --> Conflict["Merge conflict blocks this path"]
Conflict --> V1["required checks"]
Evidence --> S2["Docs (2 files)"]
S2 --> I2["operator or user guidance"]
I2 --> Conflict["Merge conflict blocks this path"]
Conflict --> V2["docs review"]
Evidence --> S3["Test (10 files)"]
S3 --> I3["regression suite"]
I3 --> Conflict["Merge conflict blocks this path"]
Conflict --> V3["targeted test run"]
Merge Conflict Guidance
gh pr checkout 790 --repo ContextualWisdomLab/contextual-orchestrator
git fetch origin main
git merge --no-ff origin/main # or: git rebase origin/main
git status --short
# resolve files, then git add <resolved-files>
# merge path: git commit
# rebase path: git rebase --continue
git push origin HEAD:feat/opencode-review-gateway
# rebase path only: git push --force-with-lease origin HEAD:feat/opencode-review-gateway |
Exact-head restack and verification audit\n\n- Repository: ContextualWisdomLab/contextual-orchestrator\n- Pull request: #790\n- Exact head SHA:
|
|
Merge-gate evidence (2026-08-25): All required checks green on current head (verified via check-runs); strix blocked externally by org-wide NVIDIA NIM quota exhaustion — documented external provider-capacity blocker, systemic serialization fix in ContextualWisdomLab/.github#1297. |
# Conflicts: # contextual_orchestrator/orchestrator.py
…gateway-2 # Conflicts: # README.md # contextual_orchestrator/model_discovery.py # docs/doctoring/embedding-chat-capability-isolation.md # docs/doctoring/provider-diverse-discovery-routing.md # tests/test_discovery_bootstrap_selection.py
# Conflicts: # README.md # contextual_orchestrator/model_discovery.py # docs/doctoring/embedding-chat-capability-isolation.md # docs/doctoring/provider-diverse-discovery-routing.md # tests/test_discovery_bootstrap_selection.py
…textualWisdomLab/contextual-orchestrator into feat-opencode-review-gateway-2
|
Merge-gate evidence (2026-08-25): Rebased onto current main (discovery/capability files taken from main's merged #768 state; gateway bootstrap + review-gateway tests preserved). Full local suite green (1856 tests). All required checks green except strix — org-wide NVIDIA NIM quota exhaustion (external provider-capacity blocker; serialization fix in ContextualWisdomLab/.github#1297). |
Summary
--auth-tokenas a local-development overrideStack reconciliation
6b603efeb9728d7c142f090153925948c0f1248fpreserved the shared chat-capability boundary and provider-diverse, price-honest discovery selector instead of reintroducing the stale simpler ranking path.8d31fa50cc6de8ddc3e6b91576e7251c5aa7d914; fix(discovery): bootstrap an honest provider-diverse failover pool #770 remains independently reviewable and must satisfy its own protected merge gates.Verification
uv run --with pytest pytest tests/test_review_gateway.py tests/test_model_discovery.py tests/test_api_contract.py -q(37 passed)python -m pytest -q tests(1,566 passed in 9:48)review_gateway.pybranch coverage: 100%8d31fa50cc6de8ddc3e6b91576e7251c5aa7d914This PR is intentionally limited to the gateway bootstrap and discovery-selection boundary; persistent production credentials remain the existing KV deployment concern.
Summary by CodeRabbit
새 기능
버그 수정
문서