Repository navigation
fix: classify tool-runtime failures and fail safely #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
334f0c6
fix: add safe tool execution fallback policy
7e1e7dd
fix: harden HTTP tool failure classification
4e6512c
fix: address tool fallback review findings
c796661
docs: specify fail-closed HTTP and SSE contract
seonghobae fbe50d3
fix: address follow-up tool fallback review
github-actions[bot] 4407046
fix: bound tool fallback retries
seonghobae 6cc4466
docs: remove plan whitespace
seonghobae 2351cab
fix(tools): honor suppressed exception contexts
seonghobae ac7d546
fix(security): require object policy for external admin reads
seonghobae 9794cff
fix(security): pass principal token to resource policy
seonghobae b762782
test(tool): preserve structured metadata through wrappers
seonghobae b706952
fix(tools): preserve structured failures through wrappers
seonghobae f60adbc
docs: record external admin resource policy
seonghobae 5bbec44
refactor: keep tool failure PR focused
seonghobae e1d4170
test: repair fallback regression checks
seonghobae 1329dc7
fix: contain raw provider failures
seonghobae 1ccb868
fix: sever fail closed tool error causes
seonghobae e258875
fix: harden tool failure retry boundaries
seonghobae cc806cd
fix: stop malformed provider failover
seonghobae 276ed4f
fix: preserve terminal provider tool failures
seonghobae d7b4f68
fix: preserve provider tool-stop failures (#811)
seonghobae 035d08a
fix: count safe retries in circuit health
seonghobae b24b3a3
refactor: remove unreachable provider error branch
seonghobae c05ab7e
fix: remove stale fallback error state
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this project are documented in this file. | ||
|
|
||
| ## [Unreleased] | ||
|
|
||
| ### Added | ||
|
|
||
| - Structured tool failure categories, stable fallback actions, and public adapter exceptions. | ||
| - Secret-free `tool_fallback_decision` audit events. | ||
| - Exact regression coverage for the Strix `Tool execute_command not found in agent strix` failure. | ||
|
|
||
| ### Changed | ||
|
|
||
| - Agent invocation now retries explicitly idempotent transient tool failures with bounded exponential backoff within a per-agent budget. | ||
| - A shared four-attempt ceiling now bounds the configured same-agent tool retry budget. | ||
| - Fail-closed tool decisions now have dedicated JSON and SSE error contracts, and preserve the observed failure kind in secret-free audit evidence. | ||
| - Missing or unavailable tools move to the next eligible agent instead of terminating the workflow immediately. | ||
|
|
||
| ### Security | ||
|
|
||
| - Ambiguous non-idempotent outcomes, invalid arguments, permission denial, and policy denial fail closed. | ||
| - Fallback errors and audit events do not copy provider exception text, tool arguments, outputs, or credentials; fail-closed exceptions also sever the original cause chain so later traceback logging cannot recover them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.