fix(security): persist provider_egress and process_bootstrap on the credential KV by cursor[bot] · Pull Request #656 · ContextualWisdomLab/contextual-orchestrator

cursor · 2026-08-16T16:34:51Z

Summary

Successor to #645 at a240cc0 (process-bootstrap sqlite/Clearfolio/CA + KV host allowlist on the SSE tools tip). Unique work on this branch closes the documented next loop after #645: those two config categories persist on the existing credential KV backend so they survive process restart.

set_runtime_config write-through copies provider_egress.allowed_provider_hosts and process_bootstrap.* onto the credential backend (runtime_config_entries on Postgres; a separate in-memory map on InMemoryCredentialBackend).
seed_provider_egress_from_environ and seed_process_bootstrap_from_environ hydrate empty process keys from that backend, then persist. Whitespace-only durable rows count as empty.
Provider secrets stay in provider_credentials / get_credential. get_credential("process_bootstrap.state_database_path") stays None.
Gateway Bearer tokens stay on fix(security): resolve gateway Bearer tokens from the credential KV #621. This slice does not copy CONTEXTUAL_ORCHESTRATOR_TOKEN / _ADMIN_TOKEN / _INFERENCE_TOKEN.
Ponytail: no second ConfigStore backend. Ephemeral in-memory backends drop persisted rows on reset_runtime_config_store; retain_runtime_settings=True (and Postgres) keep them.

Buyer next action

Call set_runtime_config("provider_egress", "allowed_provider_hosts", "api.openai.com") and set_runtime_config("process_bootstrap", "state_database_path", "state.db") (or start once with the env vars set so bootstrap can copy them). Restart the process. seed_* at __main__ / serve() reloads the last authorized hosts and paths. Do not register those keys as secrets. Do not write them only into a new get_config_store(postgres_dsn=...) instance.

Do not merge #645, #619, #598, #607, #608, #611, or #617 in parallel when landing persist + process-bootstrap + allowlist together. Prefer this head. Independent non-author APPROVE + Full unit/Semgrep are still required. This automation will not APPROVE or merge.

Test plan

python3 tests/test_runtime_config_persist.py — printed ok (allowlist after restart; real sqlite prompt persist the invoice review after restart; env seed copied onto retained backend; secrets/tokens not written; ephemeral reset does not leak; whitespace durable row does not freeze fail-open; ModelClient allowlist after hydrate)
python3 tests/test_process_bootstrap_kv.py test_provider_host_allowlist_kv.py test_self_check.py test_paper_contracts.py test_conventions.py test_security_hardening.py test_admin_contract.py test_api_contract.py test_sales_readiness.py test_product_planning_contract.py test_persistence.py test_agent_pool_db.py test_clearfolio_integration.py — printed ok
CI Full unit + Semgrep

Docs

docs/kv-credentials.md, docs/architecture.md, docs/library_research.md, docs/papers/README.md, CHANGELOG.md, conductor/tracks.md
APA 7th: Joint Task Force. (2020). Security and privacy controls for information systems and organizations (NIST SP 800-53 Rev. 5). https://doi.org/10.6028/NIST.SP.800-53r5 (CM-2, CM-6)
International Organization for Standardization. (2022). Information security, cybersecurity and privacy protection — Information security controls (ISO/IEC 27001:2022). https://www.iso.org/standard/27001 (A.8.9; cite+link, no ISO PDF)

Next loop

Remaining __main__.py bind host/port flags. Do not open another persist-only PR. Do not fold #621 token KV into this slice.

…closed otherwise Chat history: message-level audio and legacy function_call are null/empty omit no-ops; non-empty fail closed with named errors (including tools passthrough). Tip substrate from #577 assistant refusal/annotations honesty. Local full unit: 940 passed.

…ed otherwise OpenAI fine-tune style message weight is not applied on this gateway. Accept null/0/1 as honest no-ops; reject other types and values with invalid_message_weight. Tip substrate from #578. Local full unit: 943 passed.

…ion role Reject unsupported message keys with named unknown_message_fields (not silent strip or tools-passthrough smuggle). Reject legacy function role with invalid_message_role migration to tool. Tip substrate from #579. Local full unit: 947 passed.

OpenAI partial-assistant prefix flag is not applied on this gateway. null/false are honest no-ops; true and non-booleans fail closed with invalid_message_prefix. Tip substrate from #580. Local full unit: 950 passed.

…therwise Named invalid_max_tool_calls on /v1/chat/completions instead of opaque unknown_fields. Aligns with Responses max_tool_calls honesty; gateway has no multi-step tool loop.

…losed otherwise Legacy /v1/completions treated max_tool_calls as unknown_fields. Accept the key for named invalid_max_tool_calls (null/empty/whitespace omit-equivalent), matching chat/Responses honesty so SDKs get a clear migration path.

SDK clients often send include_usage/include_obfuscation as JSON null. Drop null flag values before validation so null (and null+false mixes) match omit / all-false no-ops on chat, Completions, and Responses. True flags remain fail-closed with invalid_stream_options.

…age honesty Null include_usage/include_obfuscation stay omit-equivalent, but unknown stream_options keys no longer become no-ops just because their value is null. Weight, prefix, refusal, annotations, developer role, empty user/system content, and participant name now use the same named errors on the tools passthrough path as on orchestration. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Hoist stream, required model, stream_options, and temperature/top_p range checks before proxy_completion so a tools or response_format body cannot return a billed JSON completion when the SDK asked for SSE, or silently pick a pool model when model is omitted. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Hoist attribution and routing validation before proxy_completion so a tools or response_format body cannot bill a sync completion with an unknown spend dimension or a batch/latency_tolerant hint. Tools passthrough has no batch job plane. Buyer next action: send known sync attribution; omit routing.channel=batch and latency_tolerant=true on tool-calling requests. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Call the orchestration message, max_tokens, attribution, and routing validators before proxy_completion so a tools or response_format body cannot bill a completion with no prompt, crash on a non-object entry, or silently drop unknown spend/routing keys. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Match _validate_messages: tools + user content 123 must 400 invalid_message instead of billing a sync completion. Assistant/tool JSON null stays omit-equivalent. Buyer next action: send user/system content as a non-empty string or a content-parts array. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Match the tools-path honesty contract to the invalid_message behavior so SDK clients send a string or content-parts array. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Passthrough has no batch job plane. Reject routing.channel=batch and latency_tolerant=true before proxy_completion so a tool-calling body cannot bill a silent sync completion. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Hoist the remaining chat request knobs before proxy_completion so an OpenAI SDK tool-calling body cannot bill a sync completion for seed, stop, n>1, logprobs, logit_bias, out-of-range token/penalty values, unsupported reasoning_effort, or a non-default service_tier. Buyer next action: omit those fields on tool-calling requests; they are not applied on this gateway. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Call _validate_messages before proxy_completion so tools + [] / omitted / null / non-list / non-object messages raise invalid_message instead of billing a completion with no prompt. Buyer next action: always send a non-empty messages array of objects on tool-calling requests. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Hoist the orchestration request-knob validators before proxy_completion so a tools or response_format body cannot bill a completion that silently drops seed, stop, n>1, logprobs, logit_bias, or out-of-range penalties. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

stream_chat defaulted to 0.2 even after the HTTP path wrote default_temperature from the request. A streamed invoice summary at temperature=0.8 no longer silently falls back to 0.2. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

… proxy SDK optional defaults serialize omitted fields as JSON null. Accepting those keys without popping them is not omit-equivalent: proxy_completion forwards the body and several providers reject a null JSON Schema object. Pop the keys in place, keep non-null wrong types on invalid_tools, and assert omit-real via mock echo on chat and Responses. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

OpenAI SDK tool callers send stream=true. Returning 400 was honest but left every streaming tool client failing. Pipe a single pool agent as chat.completion.chunk frames so concatenated mock content matches the non-stream JSON body, and pipe live provider text so tool_calls deltas survive. Keep include_usage, empty messages, and unsupported knobs fail-closed. Buyer next action: send stream=true on tool-calling requests; omit stream_options.include_usage. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Keep tools/response_format SSE proxy from this branch and take #601's null tool.function omit-pop, request-knob HTTP cases, and streamed route temperature. Conflict resolution keeps stream=true as SSE, not 400. CHANGELOG records the combined unreleased slice. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Unknown assistant tool_calls entry/function fields, non-boolean include_orchestration_trace, and unknown mode used to bill a JSON or SSE completion on the tools proxy. They now return the same named 400s as the orchestration path before the first byte. Buyer next action: send only id/type/function/optional index on assistant tool_calls; send a boolean or omit include_orchestration_trace; send auto/route/conduct or omit mode. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

mock:// lookup_balance now returns assistant tool_calls and streams delta.tool_calls with finish_reason=tool_calls so offline SDK clients match the live _stream_raw path. Invoice identifiers bind from the user text (default INV-9). Buyer next action: send stream=true on tool-calling requests and include the invoice id in the user message. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

stream_chat recorded temperature but omitted the request-scoped top_p, presence_penalty, and frequency_penalty that chat() already forwards. A streamed invoice summary at top_p=0.1 no longer drops those knobs. Buyer next action: send the nucleus and penalty values you want on stream=true route requests; streaming matches the JSON path. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Stop reading CONTEXTUAL_ORCHESTRATOR_ALLOWED_PROVIDER_HOSTS in ModelClient._validate_provider. The allowlist lives in provider_egress.allowed_provider_hosts; env is bootstrap transport via seed_provider_egress_from_environ only. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

Prove a second seed() after an env edit keeps the first KV set, that _validate_provider ignores env-only allowlists, and that a detached get_config_store() write is not the request-time source. Hold the runtime lock across seed read+write and fuzz the host CSV parser. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

A stored " " used to skip env seed while parsing as an empty set, freezing fail-open public HTTPS. Bootstrap now recopies env for None/""/whitespace. Request-path env-ignore and listed-host tests mock getaddrinfo so CI stays offline and still requires success. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

STATE_DB, AGENTS_DB, CLEARFOLIO_URL, and PROVIDER_CA_BUNDLE are bootstrap transport into process_bootstrap.*. Init reads the process store; CLI flags still win. Gateway Bearer tokens stay on the #621 slice. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

…redential KV Authorized hosts and sqlite/Clearfolio/CA paths survive process restart on the existing credential backend (runtime_config_entries). Secrets and gateway Bearer tokens stay out of that table. Env remains bootstrap only. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

cursor · 2026-08-16T17:10:20Z

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

seonghobae · 2026-08-16T18:22:30Z

Superseded by tip #691 (cumulative honesty substrate ≥ #689). Closing to free Full unit + Semgrep runners.

seonghobae and others added 30 commits August 16, 2026 21:18

fix(api): treat message prefix null/false as omit; fail-closed on true

82038d3

OpenAI partial-assistant prefix flag is not applied on this gateway. null/false are honest no-ops; true and non-booleans fail closed with invalid_message_prefix. Tip substrate from #580. Local full unit: 950 passed.

fix(api): treat chat max_tool_calls null/empty as omit; fail-closed o…

1a196b0

…therwise Named invalid_max_tool_calls on /v1/chat/completions instead of opaque unknown_fields. Aligns with Responses max_tool_calls honesty; gateway has no multi-step tool loop.

docs(api): tell buyers non-string user content fails closed on tools

f6dfae5

Match the tools-path honesty contract to the invalid_message behavior so SDK clients send a string or content-parts array. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

docs: tell buyers to omit batch routing on tool-calling requests

dbfa0e5

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

docs: record passthrough knob and stream temperature fixes in CHANGELOG

7e9a339

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>

cursoragent and others added 2 commits August 16, 2026 16:26

cursor Bot requested a review from seonghobae August 16, 2026 16:34

This was referenced Aug 16, 2026

feat: org catalog + live discovery + cost-performance choose #642

Closed

feat(api): fail-closed image_url rasters and persist message_image_unit #676

Closed

seonghobae marked this pull request as ready for review August 16, 2026 17:10

seonghobae enabled auto-merge (squash) August 16, 2026 17:10

seonghobae closed this Aug 16, 2026

auto-merge was automatically disabled August 16, 2026 18:22
Pull request was closed

Navigation Menu

Uh oh!

fix(security): persist provider_egress and process_bootstrap on the credential KV - #656

fix(security): persist provider_egress and process_bootstrap on the credential KV#656
cursor[bot] wants to merge 32 commits into
mainfrom
cursor/bc-34638c24-75b5-4ace-9c69-2b3f5d8fb44b-3d13

cursor Bot commented Aug 16, 2026

Uh oh!

cursor Bot commented Aug 16, 2026

Uh oh!

seonghobae commented Aug 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

cursor Bot commented Aug 16, 2026

Summary

Buyer next action

Test plan

Docs

Next loop

Uh oh!

cursor Bot commented Aug 16, 2026

Uh oh!

seonghobae commented Aug 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants