fix(api): accept OpenAI multimodal text+image_url content parts on chat - #573
Merged
seonghobae merged 5 commits intoAug 16, 2026
Conversation
SDK clients may stringify omitted optionals as empty strings. Treat empty/whitespace temperature, top_p, max_tokens, max_completion_tokens, penalties, n, seed, logprobs, parallel_tool_calls, include_orchestration_trace, echo, best_of, dimensions, max_output_tokens, and responses stream as omit. Whitespace-only stop arrays are also omit. Local full unit: 917 passed.
Vision callers send content-parts arrays. Shape-check and passthrough text/image_url parts; unsupported part types fail closed. Coerce part text for agent selection so list content does not 500. Tip substrate from empty-string numeric honesty. Local full unit: 921 passed.
seonghobae
enabled auto-merge (squash)
August 16, 2026 10:18
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the base branch from
main
to
feat/reasoning-effort-none-store-stream-empty-noop-http-honesty-20260814114817
August 16, 2026 10:58
![contextual-orchestrator-maintainer[bot]](https://github.githubassets.com/images/gravatars/gravatar-user-420.png){kind=avatar}
seonghobae
merged commit Aug 16, 2026
d192fa1
into
feat/reasoning-effort-none-store-stream-empty-noop-http-honesty-20260814114817
1 check passed
seonghobae
deleted the
feat/multimodal-content-parts-tip-http-honesty-20260816191047
branch
August 16, 2026 11:11
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contentparts (text+image_url) on/v1/chat/completionswith named fail-closed errors for bad part shapes and unsupported types (e.g.input_audio)._latest_user_text) so list content never 500s.Test plan
pytest tests/test_multimodal_message_content_http_honesty.py(+ developer multimodal suite)pytest tests -q(921 passed) — evidence implementer/evidence/pytest-multimodal-full.logProduct gates only: Full unit + Semgrep (Strix ignored). Independent non-author APPROVE still required.