fix(api): Responses truncation auto|disabled and empty parallel_tool_calls omit no-ops - #571
Merged
Conversation
…_tool_calls as omit OpenAI SDKs often send truncation=auto on /v1/responses. Without previous_response_id or conversation this gateway has no multi-turn context, so auto|disabled are honest omit-equivalent no-ops; other values stay fail-closed with invalid_truncation (not unknown_fields). Also treat empty/whitespace-string parallel_tool_calls as omit no-ops on chat, Completions, and Responses (matching store/stream empty-string SDK controls), while true without tools remains fail-closed. HTTP honesty coverage for the new contracts; cumulative tip substrate from the reasoning_effort/store/stream head.
seonghobae
enabled auto-merge (squash)
August 16, 2026 10:08
|
Important Review skippedToo many files! This PR contains 131 files, which is 31 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (131)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the base branch from
main
to
feat/reasoning-effort-none-store-stream-empty-noop-http-honesty-20260814114817
August 16, 2026 10:27
seonghobae
merged commit Aug 16, 2026
718701c
into
feat/reasoning-effort-none-store-stream-empty-noop-http-honesty-20260814114817
23 of 24 checks passed
seonghobae
deleted the
feat/responses-truncation-auto-disabled-noop-http-honesty-20260816100452
branch
August 16, 2026 10:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
truncation: "auto"|"disabled"(and whitespace-padded forms) as omit-equivalent no-ops. Withoutprevious_response_id/conversationthere is no multi-turn context to truncate; OpenAI SDKs often sendtruncation=auto.invalid_truncation(not opaqueunknown_fields).parallel_tool_callsas omit no-ops on chat Completions, legacy Completions, and Responses (SDK empty-string controls), matchingstore/streamempty-string honesty.parallel_tool_calls=truewithout tools remains fail-closed.Test plan
python tests/test_responses_truncation_parallel_empty_noop_http_honesty.pypython tests/test_responses_conversation_controls_http_honesty.pyNotes