fix(api): treat empty-string stop as omit no-op on chat/completions/responses - #550
Closed
seonghobae wants to merge 1 commit into
Closed
fix(api): treat empty-string stop as omit no-op on chat/completions/responses#550seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
…esponses Buyer SDKs often send stop:"" as an optional default meaning no stop sequences. Accept empty string as omit (parity with null and empty array) while still fail-closing non-empty Completions/chat stop and validating Responses stop shape. Tip honesty substrate re-ship; 832 unit pass.
seonghobae
enabled auto-merge (squash)
August 14, 2026 00:46
|
Important Review skippedToo many files! This PR contains 115 files, which is 15 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (115)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
auto-merge was automatically disabled
August 14, 2026 08:04
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Product gates only: Full unit + Semgrep (Strix ignored). Independent non-author APPROVE still required.