Complete admin visual surfaces - #5
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fills out the previously nav-only Admin UI surfaces (evaluations, datasets, access control, integrations, observability, audit, settings) and updates the admin simulation/evaluation requests to include orchestration traces so the UI can display real workflow evidence.
Changes:
- Expanded the Admin HTML to include additional view sections, navigation wiring, and renderers for evaluations/datasets/access/integrations/observability/audit/settings.
- Updated admin simulation and evaluation-run requests to pass
include_orchestration_trace: true, and added client-side rendering for access/timeline/JSON trace evidence. - Extended admin contract tests to assert presence of the newly populated surfaces and trace-request behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
contextual_orchestrator/admin.py |
Adds new admin visual surfaces, view switching, trace-aware simulation/evaluation requests, and rendering logic for admin evidence panels. |
tests/test_admin_contract.py |
Adds contract assertions ensuring the admin HTML includes the new surfaces and trace request flag. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
959833c to
49dd451
Compare
OpenCode Review Overview
Pull request overviewOpenCode reviewed the current-head bounded evidence and found no blocking issues. FindingsNo blocking findings. SummaryApproval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: admin.py"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: admin.py"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_admin_contract.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_admin_contract.py"]
R2 --> V2["targeted test run"]
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode reviewed the current-head bounded evidence and found no blocking issues.
Findings
No blocking findings.
Summary
Approval sufficiency: bounded evidence supplied affirmative approval evidence for changed files, coverage/docstring posture, risk surfaces, and current-head verification; approval is not based merely on the absence of known blockers.
Verification posture: CodeGraph evidence was initialized and bounded current-head evidence reviewed for changed-file evidence including contextual_orchestrator/admin.py, tests/test_admin_contract.py.
Linter/static: workflow/static review evidence is bounded by the current-head GitHub Checks gate and changed-file evidence.
TDD/regression: coverage execution evidence and focused changed hunks were reviewed from bounded-review-evidence.md.
Coverage: coverage execution evidence reports supported repository test suites passed.
Docstring coverage: coverage execution evidence reports configured repository docstring gates passed or docstring coverage was advisory.
DAG: CodeGraph/source-backed behavior map connects contextual_orchestrator/admin.py to the affected review, runtime, or workflow path and required checks.
PoC/execution: coverage-evidence job executed on the current head and reported PASS.
DDD/domain: workflow and repository-governance invariants were reviewed against changed files in bounded evidence.
CDD/context: CodeGraph evidence, changed-file history, and focused hunks were reviewed from bounded-review-evidence.md.
Similar issues: changed-file history evidence was reviewed for comparable local precedents.
Claim/concept check: bounded evidence, repository source, current-head workflow evidence, and, where numeric, scientific, statistical, or literature-backed claims are affected, original-paper/formula evidence and parameter-recovery expectations were used for claims.
Standards search: standards and external-source checks are delegated to configured OpenCode web_search/Context7/DeepWiki sources when applicable; no evidence-backed standards blocker is present in bounded evidence.
Compatibility/convention: changed workflow/script conventions, object naming, and reserved-word safety for schema/API/config/code surfaces were checked in bounded evidence.
Breaking-change/backcompat: deployment evidence and changed-file history were checked for backward-compatibility risk.
Performance: changed surfaces were checked for performance risk in bounded evidence.
Developer experience: changed automation, review, test, setup, and maintenance surfaces were checked for helpful or obstructive DX impact in bounded evidence.
User experience: connected user, operator, API, CLI, documentation, review-comment, status-check, rendering, and workflow-reader behavior was checked for contradictions against code, docs, and tests in bounded evidence.
Visual/DOM: Playwright visual, DOM locator, ARIA snapshot, console, and responsive evidence were checked when a web UI surface was present; for non-web surfaces, API/CLI/log/docs/workflow interaction evidence was reviewed instead.
Accessibility/i18n: accessibility, localization, and human-readable text surfaces were checked where UI, CLI, API message, docs, logs, or review text changed.
Supply-chain/license: dependency, package, model, container, and external-tool changes were checked in bounded evidence.
Packaging: package, build, test, lint, and security contracts were checked in bounded evidence.
Security/privacy: workflow-token, review-gate, and repository-automation security/privacy boundaries were checked in bounded evidence.
- Result: APPROVE
- Reason: Admin UI completion with full test coverage
- Head SHA:
49dd4518a1544bf1b03c3763999a92a92dcd6bfe - Workflow run: 28487586740
- Workflow attempt: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: admin.py"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: admin.py"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test_admin_contract.py"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test_admin_contract.py"]
R2 --> V2["targeted test run"]
Summary
Verification