Skip to content

test(api): lock chat/Completions logit_bias honesty over HTTP - #465

Closed
seonghobae wants to merge 1 commit into
mainfrom
feat/chat-logit-bias-http-honesty-20260814015609
Closed

test(api): lock chat/Completions logit_bias honesty over HTTP#465
seonghobae wants to merge 1 commit into
mainfrom
feat/chat-logit-bias-http-honesty-20260814015609

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • Re-ship tip substrate (server.py, orchestrator.py, cost_ledger.py) plus fixture model-field alignment from bare main.
  • Real HTTP outcome tests for logit_bias honesty (empty object no-op; non-empty fail-closed).
  • Cumulative tip honesty tests included.

Test plan

  • python -m pytest tests -q — 459 passed locally
  • tests/test_chat_logit_bias_http_honesty.py (6 cases)
  • CI Full unit + Semgrep product gates

Product gates: Full unit + Semgrep only.

Re-ship tip substrate and real HTTP outcomes for empty logit_bias
accept and non-empty fail-closed honesty.
@seonghobae
seonghobae enabled auto-merge (squash) August 13, 2026 16:58
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 91 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f7373232-9853-46ac-a478-af20571bc832

📥 Commits

Reviewing files that changed from the base of the PR and between 6841b71 and fa8a377.

📒 Files selected for processing (40)
  • contextual_orchestrator/cost_ledger.py
  • contextual_orchestrator/orchestrator.py
  • contextual_orchestrator/server.py
  • tests/test_analytics_runtime.py
  • tests/test_budget_enforcement.py
  • tests/test_chat_developer_multimodal_content_http_honesty.py
  • tests/test_chat_empty_user_system_content_http_honesty.py
  • tests/test_chat_include_orchestration_trace_http_honesty.py
  • tests/test_chat_logit_bias_http_honesty.py
  • tests/test_chat_modalities_http_honesty.py
  • tests/test_chat_openai_metadata_http_honesty.py
  • tests/test_chat_orchestration_mode_http_honesty.py
  • tests/test_chat_parallel_tool_calls_http_honesty.py
  • tests/test_chat_penalties_http_honesty.py
  • tests/test_chat_prediction_http_honesty.py
  • tests/test_chat_response_format_http_honesty.py
  • tests/test_chat_service_tier_http_honesty.py
  • tests/test_chat_store_http_honesty.py
  • tests/test_chat_stream_options_http_honesty.py
  • tests/test_chat_temperature_top_p_http_honesty.py
  • tests/test_chat_tool_call_id_http_honesty.py
  • tests/test_chat_tool_choice_functions_http_honesty.py
  • tests/test_chat_unknown_fields_http_honesty.py
  • tests/test_commercial_readiness.py
  • tests/test_completions_legacy_knobs_http_honesty.py
  • tests/test_completions_max_tokens_http_honesty.py
  • tests/test_completions_prompt_shape_http_honesty.py
  • tests/test_completions_seed_http_honesty.py
  • tests/test_completions_stop_http_honesty.py
  • tests/test_completions_stream_options_http_honesty.py
  • tests/test_completions_stream_reject_http_honesty.py
  • tests/test_cost_review_server.py
  • tests/test_openai_passthrough.py
  • tests/test_openai_user_field_http_honesty.py
  • tests/test_responses_instructions_reasoning_http_honesty.py
  • tests/test_responses_metadata_http_honesty.py
  • tests/test_sales_readiness.py
  • tests/test_security_hardening.py
  • tests/test_streaming.py
  • tests/test_true_streaming.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing as superseded by canonical cumulative PR #565. Exact head 9cc1460f1eaead36e28097dd6c967d05f3135271 contains the same tests/test_chat_logit_bias_http_honesty.py contract and the broader request-isolation regression pack. No checks, reviews, approvals, or synthetic-merge evidence transfer between heads.

@seonghobae seonghobae closed this Aug 15, 2026
auto-merge was automatically disabled August 15, 2026 10:00

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant