-
Notifications
You must be signed in to change notification settings - Fork 1
fix(tests): repair test_model_group_mutations_refresh_audit_events #1035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,9 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import json | ||
| from pathlib import Path | ||
| import shutil | ||
| import subprocess | ||
| import sys | ||
|
|
||
| sys.path.insert(0, str(Path(__file__).resolve().parents[1])) | ||
|
|
@@ -177,17 +180,22 @@ def test_model_group_mutations_refresh_audit_events() -> None: | |
| assert "model_groups_refresh_warning" in ADMIN_TRANSLATIONS["ko"] | ||
|
|
||
| def source_between(start_marker: str, end_marker: str) -> str: | ||
| """Extract one function declaration's source, parenthesized into an | ||
| expression so ``eval()`` yields the function itself rather than | ||
| ``undefined`` (eval's completion value for a bare declaration | ||
| statement).""" | ||
| start_index = ADMIN_HTML.index(start_marker) | ||
| end_index = ADMIN_HTML.index(end_marker, start_index) | ||
| return ADMIN_HTML[start_index:end_index].strip() | ||
| return "(" + ADMIN_HTML[start_index:end_index].strip() + ")" | ||
|
|
||
| node_script = "\n".join( | ||
| [ | ||
| 'import assert from "node:assert/strict";', | ||
| f"const refreshModelGroups = eval({json.dumps(source_between('async function refreshModelGroups()', ' function showModelGroupRefreshWarning'))});", | ||
| f"const refreshAuditEvents = eval({json.dumps(source_between('async function refreshAuditEvents()', ' async function refreshModelGroupViews'))});", | ||
| f"const refreshModelGroups = eval({json.dumps(source_between('async function refreshModelGroups()', ' async function refreshAuditEvents'))});", | ||
| f"const refreshAuditEvents = eval({json.dumps(source_between('async function refreshAuditEvents()', ' function showModelGroupRefreshWarning'))});", | ||
| f"const showModelGroupRefreshWarning = eval({json.dumps(source_between('function showModelGroupRefreshWarning(message)', ' async function refreshModelGroupViews'))});", | ||
| f"const refreshModelGroupViews = eval({json.dumps(source_between('async function refreshModelGroupViews()', ' async function saveModelGroup'))});", | ||
| f"const saveModelGroup = eval({json.dumps(source_between('async function saveModelGroup(event)', ' async function deleteModelGroup'))});", | ||
| f"const saveModelGroup = eval({json.dumps(source_between('async function saveModelGroup(event)', ' function renderTrace(result)'))});", | ||
| f"const deleteModelGroup = eval({json.dumps(source_between('async function deleteModelGroup(groupName)', ' els.modelGroups.addEventListener'))});", | ||
|
Comment on lines
+189
to
199
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| "let queuedResponses = [];", | ||
| "const calls = [];", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Node dependency remains implicit
The test invokes
node, but the main test job neither installs nor versions it. Runner-provided tooling therefore controls this contract test's reproducibility.(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.