🛡️ Sentinel: [MEDIUM] hmac.compare_digest의 비-ASCII 문자 처리 오류 (500 에러) 수정

[seonghobae]

Verified succession

Exact predecessor cbc5b2d386ca24049116ff3871134681d8a404ca는 decoded API-key 문자열을 UTF-8 bytes로 바꾸고 emoji mismatch→401 regression 및 같은 encoding 지침을 추가합니다. Canonical #520 exact cf730d007543ee828b7b8e77c9473288924047d4는 raw ASGI X-API-Key bytes를 configured UTF-8 key와 직접 비교하여 동일 invalid non-ASCII rejection을 보존하고, valid Unicode credential success와 duplicate-header fail-closed까지 더 강하게 검증합니다.

따라서 predecessor의 유효 behavior/test contract는 #520에 완전 승계됐습니다. decoded framework string 재인코딩과 blanket encoding 지침은 Unicode credential byte identity를 훼손할 수 있어 별도 유효 delta가 아니며 canonical guidance는 raw-header boundary로 교정했습니다. #520은 protected main@90717c6e9954bf3b7a351137995ebe89975e46c2 대비 behind_by=0인 non-force descendant입니다.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d04c4278-15c0-421a-9b38-93652c4ae55a

📥 Commits

Reviewing files that changed from the base of the PR and between a8e4956 and c3b2814.

📒 Files selected for processing (3)

• .jules/sentinel.md
• saas_web.py
• tests/test_saas_web.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

require_api_key가 API 키를 UTF-8 바이트로 비교합니다. 비ASCII API 키 입력이 401 응답을 반환하는 회귀 테스트와 관련 보안 학습 문서를 추가했습니다.

Changes

API 키 검증

Layer / File(s)	Summary
UTF-8 API 키 비교 및 회귀 검증 saas_web.py, tests/test_saas_web.py, .jules/sentinel.md	require_api_key가 제공된 키와 설정된 키를 UTF-8 바이트로 변환한 후 hmac.compare_digest로 비교합니다. 비ASCII API 키 요청은 401과 {"error": "Invalid or missing API key"}를 반환합니다. 보안 학습 문서에 예방 조치를 기록합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to c3b28

The change makes non-ASCII X-API-Key values return HTTP 401 instead of HTTP 500 without altering the authentication boundary or deployment behavior. No actionable merge-blocking risk remains after normal checks and review.

Possibly related PRs

• ContextualWisdomLab/codec-carver#303: 동일한 require_api_key UTF-8 인코딩 수정과 비ASCII API 키 DoS 대응을 다룹니다.
• ContextualWisdomLab/codec-carver#326: 동일한 수정, 회귀 테스트, Sentinel 문서를 포함합니다.
• ContextualWisdomLab/codec-carver#451: require_api_key의 UTF-8 API 키 비교 수정을 다룹니다.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 비-ASCII API 키 처리로 발생하는 hmac.compare_digest의 500 오류 수정이라는 주요 변경 사항을 명확하게 요약합니다.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jules-11981266730423604347-a86f1501

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devin-ai-integration]

Devin Review found 1 potential issue.

[devin-ai-integration]

📝 Info: Env-based API key reading remains the documented anti-pattern

AGENTS.md marks the CODEC_CARVER_API_KEYS env read in get_configured_api_keys as a known deviation to migrate to the credential registry. This PR edits the auth path but leaves that runtime env read in place.

(Refers to this code)

---

Was this helpful? React with 👍 or 👎 to provide feedback.