fix(ui): restore drop-zone click-to-open after landmark-only rewrite - #425
fix(ui): restore drop-zone click-to-open after landmark-only rewrite#425cursor[bot] wants to merge 9 commits into
Conversation
Keep region landmarks and reopen the matching file picker from empty drop-zone space, with DOM-ready registration, nested-control guards, and the executable Node harness so a later design rewrite cannot drop the buyer-visible click path again. Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
There was a problem hiding this comment.
Verdict
#425 is superseded.
#419 at 71c03498 restored the click listeners and Node harness after the d14ea48 landmark-only wipe. #428 (ce7c3e4) overlays click-or-drag copy, labelled role="region" landmarks, and design tokens on that same tree, and teaches closest(...) in .jules/palette.md.
Do not land #425, #419, and #428 in parallel. Keep #425 Draft. Prefer #419 once its current-head checks are green, then #428 for the residual buyer copy/landmark slice.
Sent by Cursor Automation: Fix Issues
|
Closing as superseded by active Cursor successor #428. The exact #425 changed-file set ( |


Buyer-visible outcome
Click empty space in either upload card to open the matching file picker. Native input, button, and label clicks stay authoritative. Screen readers still get distinct region landmarks.
Why this PR exists
#419 head
d14ea48keptrole="region"/aria-labeland deleted the reviewed click contract for the third time:DOMContentLoadedregistration (batch controls do not exist when the first script parses)closest('input, button, label')guardsfileInput.click()/batchFileInput.click()tests/test_saas_ui_contract.py(executable Node DOM harness)This branch restores that tree and keeps the landmarks.
Contract
INPUT,BUTTON,LABEL, and aSPANinside aLABELdo not synthesize a second activation.Verification
python3 -m unittest tests.test_saas_ui_contract tests.test_saas_web -v— 76 tests, OK.Grounding:
docs/doctoring/drop-zone-pointer-activation.md(Fitts, 1954; MacKenzie, 1992; WAI-ARIA 1.2; WCAG 2.2).Do not merge #419 at
d14ea48. Land this repair instead, or replay these commits onto the #419 branch without another landmark-only rewrite.