fix(web): normalize upload basenames across path styles - #397
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough업로드 파일명의 백슬래시를 경로 구분자로 정규화한 뒤 basename을 추출합니다. 단일 및 배치 업로드에 적용하고, Windows 경로 순회 입력에 대한 회귀 테스트와 변경 기록을 추가합니다. Changes업로드 파일명 보안 처리
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/test_saas_web.py`:
- Around line 567-585: Update the test around shrink_media_batch to close the
archive with a with statement and ensure the temporary workspace is removed in a
finally block by calling cleanup_temp_dir with Path(response.path).parent. Keep
the existing manifest and conversion assertions intact.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a41459ba-ace1-416b-96c7-497e02302c60
📒 Files selected for processing (4)
.jules/sentinel.mdCHANGELOG.mdsaas_web.pytests/test_saas_web.py
Summary
/and\client path separators before extracting upload basenamesBoundary
Uploads remain inside a trusted temporary workspace, and batch archive entry names are generated outputs. This is a cross-platform correctness and defense-in-depth change; the reviewed code does not demonstrate arbitrary filesystem writes or archive-entry escape.
Verification
PR created automatically by Jules for task 6471144421105359756 started by @seonghobae