fix(web): reset empty target-size validation state - #353
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough단일 및 배치 크기 입력이 비어 있을 때 미리보기와 유효성 상태를 초기화합니다. 숫자 검사는 건너뜁니다. 이 동작을 검증하는 소스 계약 테스트와 처리 지침 및 변경 이력을 추가합니다. Changes빈 크기 입력 검증
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/test_saas_web.py (1)
294-300: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win두 입력 필드의 회귀를 모두 검증하도록 테스트를 확장하세요.
현재 assertion은 일반적인
if (this.value === '') {문자열 하나만 확인합니다.batch_target_bytes분기가 없어도 테스트가 통과할 수 있습니다.두 핸들러의 빈 문자열 분기와
setCustomValidity(''),removeAttribute('aria-invalid')호출을 각각 검증하세요. 가능하면 브라우저 테스트에서 두 입력에 이벤트를 발생시키고 미리보기,validationMessage,aria-invalid상태를 확인하세요.간단한 정적 검증 보강 예시
self.assertIn("if (this.value === '') {", html) + self.assertEqual(html.count("if (this.value === '') {"), 2) + self.assertIn( + "document.getElementById('batch_target_bytes').addEventListener('input'", + html, + )🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/test_saas_web.py` around lines 294 - 300, Expand test_get_ui_includes_target_bytes_validation_feedback to independently verify both input handlers, including each empty-string branch, setCustomValidity(''), and removeAttribute('aria-invalid') calls; avoid relying on the shared if (this.value === '') assertion. Prefer exercising both inputs with browser events and asserting their preview output, validationMessage, and aria-invalid state.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@tests/test_saas_web.py`:
- Around line 294-300: Expand
test_get_ui_includes_target_bytes_validation_feedback to independently verify
both input handlers, including each empty-string branch, setCustomValidity(''),
and removeAttribute('aria-invalid') calls; avoid relying on the shared if
(this.value === '') assertion. Prefer exercising both inputs with browser events
and asserting their preview output, validationMessage, and aria-invalid state.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 97392f4e-3f51-4da1-a79a-74d980471165
📒 Files selected for processing (3)
.jules/palette.mdsaas_web.pytests/test_saas_web.py
|
@opencode-agent @cwl-noema-review Rebuild this draft from exact protected |
Acknowledged. I have rebuilt the patch from |
Rebuild the focused accessibility fix from protected current main, preserve dynamic upload-limit behavior, add isolated handler tests, and remove unrelated security/test changes.
3cc86ff to
84f7110
Compare
Purpose
When either required target-size input is cleared, remove stale custom validity and
aria-invalidstate so the browser and assistive technology report the current empty-required state instead of the previous numeric error.Change
aria-invalid, then return;Acceptance boundary
Merge only after exact-current-head CI, fuzz, security, SAST, review, zero unresolved actionable threads, and repository protection succeed. No unrelated security, credential, dependency, or governance change is included.
Summary by CodeRabbit
버그 수정
문서