Skip to content

🎨 Palette: μ—…λ‘œλ“œ 크기 μ œν•œμ— λŒ€ν•œ 동적 검증 λ©”μ‹œμ§€ 및 일괄 μ—…λ‘œλ“œ 총 μš©λŸ‰ μ œν•œ μΆ”κ°€ - #286

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette/dynamic-file-size-4272209532672658895
Closed

🎨 Palette: μ—…λ‘œλ“œ 크기 μ œν•œμ— λŒ€ν•œ 동적 검증 λ©”μ‹œμ§€ 및 일괄 μ—…λ‘œλ“œ 총 μš©λŸ‰ μ œν•œ μΆ”κ°€#286
seonghobae wants to merge 1 commit into
mainfrom
palette/dynamic-file-size-4272209532672658895

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

What: 단일 μ—…λ‘œλ“œ 및 일괄 μ—…λ‘œλ“œ 폼에 동적 파일 크기 μ œν•œ 검증 둜직 μΆ”κ°€
Why: ν•˜λ“œμ½”λ”©λœ μš©λŸ‰ ν‘œκΈ° 였λ₯˜ λ°©μ§€ 및 일괄 μ—…λ‘œλ“œ μ‹œ 총 μš©λŸ‰ 초과 λ°©μ§€
Before/After: 5 GiB ν•˜λ“œμ½”λ”© -> 동적 μƒμˆ˜ 계산 적용, 일괄 μ—…λ‘œλ“œ μ‹œ 총 μš©λŸ‰ 검증 μΆ”κ°€
Accessibility: μ»€μŠ€ν…€ μ—λŸ¬ λ©”μ‹œμ§€ 및 aria-invalid μƒνƒœ μ—…λ°μ΄νŠΈ


PR created automatically by Jules for task 4272209532672658895 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 23, 2026 22:45

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the FastAPI upload UI’s client-side validation by removing hardcoded β€œ5 GiB” strings and instead formatting the limit from the existing MAX_UPLOAD_BYTES constant, while also adding a combined-total-size validation path for batch uploads to better match the backend request-size envelope.

Changes:

  • Updated single-file validation to build user-facing limit messages dynamically from MAX_UPLOAD_BYTES.
  • Added batch upload total-size validation (sum of selected files) with a custom validity message and aria-invalid updates.
  • Updated UI snapshot-style tests and documented the change in the changelog and Palette learning log.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
saas_web.py Updates the embedded UI JavaScript to dynamically format size limits and validate batch total upload size.
tests/test_saas_web.py Adjusts HTML assertions to match the new dynamic strings and new batch-total-size checks.
CHANGELOG.md Documents the UI validation message improvements and new total-size validation.
.jules/palette.md Records the learning/action note about avoiding hardcoded limits and validating batch totals client-side.

πŸ’‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread saas_web.py
const limitText = formatBinaryBytes(MAX_UPLOAD_BYTES);
input.setCustomValidity('Total file size exceeds ' + limitText + ' limit.');
input.setAttribute('aria-invalid', 'true');
preview.innerText = 'Selected ' + files.length + ' files (' + formatBinaryBytes(totalSize) + ', exceeds ' + limitText + ' total limit)';

Copy link
Copy Markdown
Contributor Author

Superseded by merged PR #354, which includes this dynamic size-limit feedback and aggregate batch-size prevalidation. Closing the duplicate to keep the reviewed implementation canonical.

@seonghobae seonghobae closed this Aug 7, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by merged PR #354, which includes this dynamic size-limit feedback and aggregate batch-size prevalidation. Closing the duplicate to keep the reviewed implementation canonical.

Understood. Acknowledging that this work is superseded and closing the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants