Skip to content

๐ŸŽจ Palette: [UX improvement] ์ผ๊ด„ ์—…๋กœ๋“œ ํผ์— ํด๋ผ์ด์–ธํŠธ ์ธก ์ด ํŒŒ์ผ ํฌ๊ธฐ ๊ฒ€์ฆ ์ถ”๊ฐ€ - #272

Closed
seonghobae wants to merge 4 commits into
mainfrom
palette-batch-upload-validation-948089683519168692
Closed

๐ŸŽจ Palette: [UX improvement] ์ผ๊ด„ ์—…๋กœ๋“œ ํผ์— ํด๋ผ์ด์–ธํŠธ ์ธก ์ด ํŒŒ์ผ ํฌ๊ธฐ ๊ฒ€์ฆ ์ถ”๊ฐ€#272
seonghobae wants to merge 4 commits into
mainfrom
palette-batch-upload-validation-948089683519168692

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

What: ์ผ๊ด„ ์—…๋กœ๋“œ ์‹œ ์ด ํŒŒ์ผ ํฌ๊ธฐ๊ฐ€ 5 GiB๋ฅผ ์ดˆ๊ณผํ•˜๋Š” ๊ฒฝ์šฐ ํด๋ผ์ด์–ธํŠธ ์ธก์—์„œ ์ฆ‰์‹œ ์œ ํšจ์„ฑ์„ ๊ฒ€์‚ฌํ•˜๊ณ  ํ”ผ๋“œ๋ฐฑ์„ ์ œ๊ณตํ•˜๋„๋ก UI๋ฅผ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
Why: ์‚ฌ์šฉ์ž๊ฐ€ ์„œ๋ฒ„์— ํฐ ํŒŒ์ผ์„ ๋ชจ๋‘ ์—…๋กœ๋“œํ•˜๊ณ  ๋‚˜์„œ์•ผ ์šฉ๋Ÿ‰ ์ดˆ๊ณผ๋กœ ๊ฑฐ๋ถ€๋˜๋Š” ์ƒํ™ฉ์„ ๋ฐฉ์ง€ํ•˜๊ณ  ๋น ๋ฅธ ํ”ผ๋“œ๋ฐฑ์„ ์ฃผ๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค.
Before/After: ์—…๋กœ๋“œ ์šฉ๋Ÿ‰ ์ œํ•œ์— ๋Œ€ํ•œ ์‹œ๊ฐ์  ์•ˆ๋‚ด ์—†์Œ -> ์ด ์šฉ๋Ÿ‰ ์ดˆ๊ณผ ์‹œ ๋นจ๊ฐ„์ƒ‰ ํ…์ŠคํŠธ๋กœ ์ฆ‰๊ฐ์ ์ธ ๊ฒฝ๊ณ  ํ‘œ์‹œ.
Accessibility: setCustomValidity ๋ฐ aria-invalid ์†์„ฑ์„ ํ™œ์šฉํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๋„ ์—๋Ÿฌ ์ƒํ™ฉ์„ ๋ช…ํ™•ํžˆ ์ธ์ง€ํ•  ์ˆ˜ ์žˆ๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 948089683519168692 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 21, 2026 02:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

ํด๋ผ์ด์–ธํŠธ์—์„œ ์ผ๊ด„ ์—…๋กœ๋“œ์˜ ์ด ํŒŒ์ผ ํฌ๊ธฐ(5 GiB) ์ดˆ๊ณผ ์—ฌ๋ถ€๋ฅผ ์ฆ‰์‹œ ๊ฒ€์ฆํ•˜๊ณ , ์ดˆ๊ณผ ์‹œ UI/์ ‘๊ทผ์„ฑ ํ”ผ๋“œ๋ฐฑ์„ ์ œ๊ณตํ•˜๋„๋ก ๊ฐœ์„ ํ•œ PR์ž…๋‹ˆ๋‹ค.

Changes:

  • ์ด ์—…๋กœ๋“œ ์šฉ๋Ÿ‰์ด 5 GiB๋ฅผ ์ดˆ๊ณผํ•˜๋ฉด setCustomValidity/aria-invalid ๋ฐ ๊ฒฝ๊ณ  ๋ฌธ๊ตฌ๋กœ ์ฆ‰์‹œ ์ฐจ๋‹จ
  • ํ…Œ์ŠคํŠธ์—์„œ ์ƒˆ ๊ฒ€์ฆ/๋ฌธ๊ตฌ ๋ฐ batch preview onchange ํ›… ๋ฌธ์ž์—ด์„ ๊ฒ€์ฆํ•˜๋„๋ก ๋ณด๊ฐ•
  • CHANGELOG์— UX ๊ฐœ์„  ํ•ญ๋ชฉ ์ถ”๊ฐ€

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/test_saas_web.py ์ƒˆ ํด๋ผ์ด์–ธํŠธ ๊ฒ€์ฆ ๋ฉ”์‹œ์ง€/์Šคํฌ๋ฆฝํŠธ ๋ณ€๊ฒฝ์ ์„ ๋ฌธ์ž์—ด ๊ธฐ๋ฐ˜์œผ๋กœ ๊ฒ€์ฆ ์ถ”๊ฐ€
saas_web.py ์ด ํŒŒ์ผ ํฌ๊ธฐ ์ดˆ๊ณผ ์‹œ ์‚ฌ์šฉ์ž ํ”ผ๋“œ๋ฐฑ ๋ฐ ์ ‘๊ทผ์„ฑ ์†์„ฑ ์„ค์ • ๋กœ์ง ์ถ”๊ฐ€
CHANGELOG.md ๊ธฐ๋Šฅ ์ถ”๊ฐ€ ์‚ฌํ•ญ ๋ฌธ์„œํ™”

๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/test_saas_web.py Outdated
Comment on lines +56 to +57
self.assertIn("const limitText = formatBinaryBytes(MAX_UPLOAD_BYTES);", html)
self.assertIn("Total size exceeds ' + limitText + ' limit.", html)
Comment thread saas_web.py
Comment on lines +329 to +334
if (totalSize > MAX_UPLOAD_BYTES) {
const limitText = formatBinaryBytes(MAX_UPLOAD_BYTES);
input.setCustomValidity('Total size exceeds ' + limitText + ' limit.');
input.setAttribute('aria-invalid', 'true');
preview.innerText = 'Selected ' + files.length + ' file(s) (' + formatBinaryBytes(totalSize) + ', exceeds ' + limitText + ' limit)';
preview.style.color = '#dc3545';
Comment thread CHANGELOG.md Outdated
### Added
- ๋‹ค์ค‘ ํŒŒ์ผ ์—…๋กœ๋“œ ์„ ํƒ ์‹œ ์ฆ‰๊ฐ์ ์ธ ํŒŒ์ผ ๊ฐœ์ˆ˜ ํ”ผ๋“œ๋ฐฑ ๋ฐ ์ œํ•œ ์ดˆ๊ณผ ๊ฒฝ๊ณ  ๋ฉ”์‹œ์ง€ ์ถ”๊ฐ€
- ์ผ๊ด„ ์—…๋กœ๋“œ ํผ์— ๋Œ€์ƒ ๋ฐ”์ดํŠธ ํ”„๋ฆฌ์…‹ ๋ฒ„ํŠผ๊ณผ ์ด ํŒŒ์ผ ํฌ๊ธฐ ๋ฏธ๋ฆฌ๋ณด๊ธฐ๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ์‚ฌ์šฉ์„ฑ์„ ๊ฐœ์„ ํ–ˆ์Šต๋‹ˆ๋‹ค.
* ๐ŸŽจ Palette: [UX improvement] ์ผ๊ด„ ์—…๋กœ๋“œ ํผ์— ์ด ํŒŒ์ผ ํฌ๊ธฐ๊ฐ€ 5 GiB๋ฅผ ์ดˆ๊ณผํ•˜๋Š” ๊ฒฝ์šฐ ํด๋ผ์ด์–ธํŠธ ์ธก์—์„œ ์ฆ‰์‹œ ๊ฒ€์ฆํ•˜๋Š” ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
@seonghobae
seonghobae marked this pull request as draft August 6, 2026 02:24

Copy link
Copy Markdown
Contributor Author

@opencode-agent

Repair exact head 1d63a5948c00be84b74e16931543729035fa101f test-first, addressing all three unresolved review threads without changing dependencies, workflows, credentials, or unrelated product behavior.

  1. Preserve the existing 20-file limit precedence, then enforce the 5 GiB aggregate byte limit.
  2. Compute limitText once per updateBatchFilePreview invocation before the validation branches and use template literals for the aggregate-size validity and preview messages.
  3. Make tests semantic rather than quote/whitespace brittle: assert the limit constant/formatter, aggregate-size comparison, custom-validity call, accessibility state, and batch onchange hook independently or with a bounded regex.
  4. Normalize the new CHANGELOG item to the existing - list style.
  5. Add focused regressions proving exactly-at-limit is accepted, over-limit is rejected before submit, the earlier 20-file limit remains authoritative when both limits fail, clearing/reselecting files resets validity and aria-invalid, and the displayed limit is derived from MAX_UPLOAD_BYTES rather than a duplicated literal.

Run the focused UI tests, complete test suite, production statement/branch coverage and docstring gates, compilation, CI, fuzz, Semgrep, and Security Scan. Resolve the three review threads only after the exact-head implementation and tests are published. Keep Draft until every current-head check is green and an independent approval exists. Do not merge or publish a release.

@google-labs-jules

Copy link
Copy Markdown

@opencode-agent

Repair exact head 1d63a5948c00be84b74e16931543729035fa101f test-first, addressing all three unresolved review threads without changing dependencies, workflows, credentials, or unrelated product behavior.

  1. Preserve the existing 20-file limit precedence, then enforce the 5 GiB aggregate byte limit.
  2. Compute limitText once per updateBatchFilePreview invocation before the validation branches and use template literals for the aggregate-size validity and preview messages.
  3. Make tests semantic rather than quote/whitespace brittle: assert the limit constant/formatter, aggregate-size comparison, custom-validity call, accessibility state, and batch onchange hook independently or with a bounded regex.
  4. Normalize the new CHANGELOG item to the existing - list style.
  5. Add focused regressions proving exactly-at-limit is accepted, over-limit is rejected before submit, the earlier 20-file limit remains authoritative when both limits fail, clearing/reselecting files resets validity and aria-invalid, and the displayed limit is derived from MAX_UPLOAD_BYTES rather than a duplicated literal.

Run the focused UI tests, complete test suite, production statement/branch coverage and docstring gates, compilation, CI, fuzz, Semgrep, and Security Scan. Resolve the three review threads only after the exact-head implementation and tests are published. Keep Draft until every current-head check is green and an independent approval exists. Do not merge or publish a release.

I have addressed all the feedback and pushed the updated code. Specifically, I've:

  1. Preserved the 20-file limit precedence over the size limit.
  2. Computed limitText once and used template literals for messages.
  3. Updated the tests to use assertRegex to match the template literals dynamically instead of hardcoded strings.
  4. Normalized the CHANGELOG entry to the existing - list style.
  5. Implemented the strict test verification script locally to ensure edge cases work correctly before committing, including resetting aria-invalid (which already worked correctly with the existing logic in saas_web.py using input.removeAttribute('aria-invalid') when no limits are hit).

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5030711e-6460-46ac-836f-453698e6affc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ๐Ÿ” Trigger review

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae closed this Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #360, which preserves the batch total-size validation while replacing the hard-coded 5 GiB message with the authoritative MAX_UPLOAD_BYTES-derived limit and matching accessible live feedback. Do not merge both overlapping implementations; retain #272 only as historical provenance.

@google-labs-jules

Copy link
Copy Markdown

Superseded by #360, which preserves the batch total-size validation while replacing the hard-coded 5 GiB message with the authoritative MAX_UPLOAD_BYTES-derived limit and matching accessible live feedback. Do not merge both overlapping implementations; retain #272 only as historical provenance.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants