Skip to content
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
915db47
fix(a11y): keep unavailable score controls discoverable
seonghobae Aug 14, 2026
f34402a
fix(a11y): explain unavailable pagination states
seonghobae Aug 14, 2026
123f8d7
test(score): require disabled remove recovery hint
seonghobae Aug 16, 2026
df0809e
test(score): align disabled remove recovery hint
seonghobae Aug 16, 2026
fb2c9d8
fix(score): explain unavailable remove action
seonghobae Aug 16, 2026
98abea5
test(score): fold recovery hint regression into component suite
seonghobae Aug 16, 2026
b88a1e0
fix(a11y): verify aria-disabled tests correctly checking title logic
seonghobae Aug 16, 2026
1ba37d7
test(a11y): restore localized disabled-action oracle
seonghobae Aug 16, 2026
8ea7ae2
fix(a11y): verify aria-disabled tests correctly checking title logic
seonghobae Aug 16, 2026
81cc280
test(a11y): restore localized disabled-action oracle
seonghobae Aug 16, 2026
9bd7fdd
test(score): require disabled page navigation descriptions
seonghobae Aug 18, 2026
a00c32c
fix(score): describe unavailable page navigation
seonghobae Aug 18, 2026
0b9554a
docs(a11y): record disabled score navigation contract
seonghobae Aug 18, 2026
84f45fb
test(a11y): require enabled score action tooltips
seonghobae Aug 18, 2026
e7f6d01
fix(a11y): preserve enabled score action tooltips
seonghobae Aug 18, 2026
a3215b5
fix(a11y): verify aria-disabled tests correctly checking title logic
seonghobae Aug 18, 2026
5ef9e09
test(a11y): restore described disabled score navigation
seonghobae Aug 18, 2026
4d45755
fix(a11y): restore described score page boundaries
seonghobae Aug 18, 2026
09b92d1
test(a11y): retain enabled score open tooltip
seonghobae Aug 18, 2026
ba0e364
fix(a11y): restore enabled score open tooltip
seonghobae Aug 18, 2026
65cd30d
fix(a11y): verify aria-disabled tests correctly checking title logic
seonghobae Aug 18, 2026
a3728f0
test(a11y): restore disabled pagination description regression
seonghobae Aug 19, 2026
69236f4
fix(a11y): restore disabled pagination descriptions
seonghobae Aug 19, 2026
c958aff
docs(a11y): restore disabled navigation rationale
seonghobae Aug 19, 2026
8388b9c
test(a11y): strengthen unavailable score action oracle
seonghobae Aug 19, 2026
4319fe9
test(score): redact untrusted bridge error details
seonghobae Aug 21, 2026
0ea4a70
fix(a11y): prevent score view error details from leaking paths or secโ€ฆ
seonghobae Aug 21, 2026
0ce9f36
test(a11y): cover unavailable add-score action
seonghobae Aug 22, 2026
6076f22
fix(a11y): keep unavailable add-score action focusable
seonghobae Aug 22, 2026
1cb9109
test(a11y): verify focusable guarded attach action
seonghobae Aug 22, 2026
5d42307
docs(a11y): document focusable score action boundary
seonghobae Aug 22, 2026
5ea5663
docs(changelog): record focusable add-score guard
seonghobae Aug 22, 2026
d69a3b4
test(score): expose disabled page reasons to focus and hover
seonghobae Sep 1, 2026
66f1198
fix(score): show unavailable page reasons on focus and hover
seonghobae Sep 1, 2026
4657b30
docs(score): document focus-visible unavailable page help
seonghobae Sep 1, 2026
7fd0fef
test(score): require reduced-motion tooltip transitions
seonghobae Sep 1, 2026
96f53ec
fix(score): honor reduced motion for unavailable page help
seonghobae Sep 1, 2026
bcd7d4d
merge(develop): refresh Score accessibility base
seonghobae Sep 3, 2026
e6ce833
chore(stack): refresh Score accessibility protected base
seonghobae Sep 4, 2026
5497355
chore(score): adopt protected workflow consolidation
seonghobae Sep 4, 2026
b00d29f
fix(a11y): prevent score view error details from leaking paths or secโ€ฆ
seonghobae Sep 4, 2026
3dc9947
chore(score): remove purpose-complete patch helper
seonghobae Sep 5, 2026
e5db6f8
chore(score): remove temporary source reapply helper
seonghobae Sep 5, 2026
7ca242e
fix(a11y): prevent score view error details from leaking paths or secโ€ฆ
seonghobae Sep 5, 2026
c6407ce
fix(a11y): prevent score view error details from leaking paths or secโ€ฆ
seonghobae Sep 5, 2026
ae086b3
fix(a11y): prevent score view error details from leaking paths or secโ€ฆ
seonghobae Sep 5, 2026
8375800
fix(a11y): explain score pagination boundaries
seonghobae Sep 6, 2026
f86b0f5
fix(a11y): localize score pagination boundary reasons
seonghobae Sep 6, 2026
736ce45
test(a11y): require score pagination boundary reasons
seonghobae Sep 6, 2026
add2d9f
chore(a11y): drop unrelated supply-chain formatting drift
seonghobae Sep 6, 2026
8e0012d
test(a11y): require hoverable score boundary tooltips
seonghobae Sep 6, 2026
78a5e60
fix(a11y): keep score boundary tooltips hoverable
seonghobae Sep 6, 2026
b13c385
test(a11y): require Escape-dismissable score boundary reasons
seonghobae Sep 6, 2026
1a92b71
fix(a11y): dismiss score boundary tooltips with Escape
seonghobae Sep 6, 2026
89b12be
docs(a11y): trace hover and Escape score tooltip contract
seonghobae Sep 6, 2026
a150059
test(a11y): require continuous hover path for score tooltips
seonghobae Sep 6, 2026
a941cf1
fix(a11y): preserve continuous score tooltip hover path
seonghobae Sep 6, 2026
b2974a4
docs(a11y): record continuous score tooltip hover geometry
seonghobae Sep 6, 2026
e89ba12
test(score): require shared boundary tooltips
seonghobae Sep 23, 2026
c26fbe4
fix(score): reuse shared boundary tooltips
seonghobae Sep 23, 2026
36719ab
docs(score): record shared tooltip boundary
seonghobae Sep 23, 2026
9eeadb8
chore: push trigger to retry Strix again
seonghobae Sep 23, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@
- Display the analyzed song tempo (BPM) as a badge in the rehearsal workspace.
- ๊ฐ ํ•ฉ์ฃผ ์—ญํ• (Role)๋ณ„ ๊ฐœ์ธ ์—ฐ์Šต ์ง„ํ–‰๋„๋ฅผ 0~100% ๋ฒ”์œ„๋กœ ๊ธฐ๋ก ๋ฐ ์‹œ๊ฐํ™”ํ•  ์ˆ˜ ์žˆ๋Š” ์—ฐ์Šต ์ง„์ฒ™๋„(`practiceProgress`) ํŠธ๋ž˜์ปค ๊ธฐ๋Šฅ ์ถ”๊ฐ€. UI ์ปจํŠธ๋กค(์Šฌ๋ผ์ด๋” ๋ฐ +/- ๋ฒ„ํŠผ)๊ณผ ํ•œ/์˜ ๋‹ค๊ตญ์–ด ์ง€์› ํฌํ•จ.

### Changed

- Keep unavailable score-open, score-remove, and PDF pagination controls keyboard-focusable, expose their unavailable state to assistive technology, explain blocked actions, and prevent activation at the action boundary.

## [0.1.3] - 2026-04-29

### Fixed
Expand Down Expand Up @@ -65,4 +69,4 @@

- `ChordsFeature` (์ฝ”๋“œ ๋ถ„์„) ํ™”๋ฉด์—์„œ ๊ฐ ํŒŒํŠธ(Role)์˜ `transpositionPlan`(์ด์กฐ/์กฐ์˜ฎ๊น€ ๊ณ„ํš)์„ ํ‘œ์‹œํ•˜๋Š” ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
- `RangesFeature` (์Œ์—ญ๋Œ€ ๋ถ„์„) ํ™”๋ฉด์—์„œ ๊ฒน์นจ ๊ฒฝ๊ณ (Overlap warning) ์™ธ์— ํ•ด๋‹น ํŒŒํŠธ์˜ ์ฑ„๋ณด(Transcription) ๊ฐ€๋Šฅ ๋…ธ๋“œ ์ˆ˜๋ฅผ ์š”์•ฝํ•˜์—ฌ ๋ณด์—ฌ์ฃผ๋Š” ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
- ์‹ ๊ทœ UI ์š”์†Œ์— ๋Œ€ํ•œ 100% ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ๋ณด์žฅํ•˜๋Š” ๋‹จ์œ„ ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค (`apps/desktop/src/features/chords/index.test.tsx`, `apps/desktop/src/features/ranges/index.test.tsx`).
- ์‹ ๊ทœ UI ์š”์†Œ์— ๋Œ€ํ•œ 100% ํ…Œ์ŠคํŠธ ์ปค๋ฒ„๋ฆฌ์ง€๋ฅผ ๋ณด์žฅํ•˜๋Š” ๋‹จ์œ„ ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค (`apps/desktop/src/features/chords/index.test.tsx`, `apps/desktop/src/features/ranges/index.test.tsx`).
24 changes: 20 additions & 4 deletions apps/desktop/src/features/score/ScoreView.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { act, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { act, createEvent, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { RehearsalSong, ScoreAttachment } from "@bandscope/shared-types";
import { invoke } from "@tauri-apps/api/core";
Expand Down Expand Up @@ -96,11 +96,27 @@ describe("ScoreView", () => {

expect(screen.getByText("Scores attach to the active analysis project.")).toBeInTheDocument();
expect(screen.getByRole("button", { name: "Add score" })).toBeDisabled();
expect(screen.getByRole("button", { name: "Open score: opener.pdf" })).toBeDisabled();
expect(screen.getByRole("button", { name: "Remove: opener.pdf" })).toBeDisabled();

fireEvent.click(screen.getByRole("button", { name: "Open score: opener.pdf" }));
const openBtn = screen.getByRole("button", { name: "Open score: opener.pdf" });
expect(openBtn).toHaveAttribute("aria-disabled", "true");
expect(openBtn).toHaveAttribute("aria-describedby");
expect(openBtn).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");
expect(openBtn).toHaveAttribute("title", "scoreNavDisabledHint");

const removeBtn = screen.getByRole("button", { name: "Remove: opener.pdf" });
expect(removeBtn).toHaveAttribute("aria-disabled", "true");
expect(removeBtn).toHaveAttribute("aria-describedby");
expect(removeBtn).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");
expect(removeBtn).toHaveAttribute("title", "Remove: opener.pdf");

const openClickEvent = createEvent.click(openBtn);
fireEvent(openBtn, openClickEvent);
expect(openClickEvent.defaultPrevented).toBe(true);
expect(mockInvoke).not.toHaveBeenCalled();

const clickEvent = createEvent.click(removeBtn);
fireEvent(removeBtn, clickEvent);
expect(clickEvent.defaultPrevented).toBe(true);
});

it("attaches a score, persists the metadata, and opens the new PDF", async () => {
Expand Down
36 changes: 28 additions & 8 deletions apps/desktop/src/features/score/ScoreView.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useMemo, useRef, useState } from "react";
import { useId, useMemo, useRef, useState } from "react";
import { FileMusic, FilePlus2, Loader2, Trash2 } from "lucide-react";
import type { RehearsalSong, ScoreAttachment } from "@bandscope/shared-types";
import { createTranslator, detectPreferredLocale } from "../../i18n";
Expand Down Expand Up @@ -39,6 +39,7 @@ function bridgeErrorDetail(error: unknown, fallback: string): string {
*/
export function ScoreView({ song, projectId, onSongUpdate }: ScoreViewProps) {
const t = useMemo(() => createTranslator(detectPreferredLocale()), []);
const scoreRequiresProjectId = useId();
const attachments = useMemo(() => song.scoreAttachments ?? [], [song.scoreAttachments]);
const [selected, setSelected] = useState<ScoreAttachment | null>(null);
const [pdfBytes, setPdfBytes] = useState<Uint8Array | null>(null);
Expand Down Expand Up @@ -149,7 +150,10 @@ export function ScoreView({ song, projectId, onSongUpdate }: ScoreViewProps) {
</div>

{!projectId && (
<p className="rounded-xl border border-amber-300/25 bg-amber-300/10 px-4 py-3 text-sm font-medium text-amber-100">
<p
id={scoreRequiresProjectId}
className="rounded-xl border border-amber-300/25 bg-amber-300/10 px-4 py-3 text-sm font-medium text-amber-100"
>
{t("scoreRequiresProject")}
</p>
)}
Expand Down Expand Up @@ -183,22 +187,38 @@ export function ScoreView({ song, projectId, onSongUpdate }: ScoreViewProps) {
>
<button
type="button"
onClick={projectId ? () => void openAttachment(projectId, attachment) : undefined}
disabled={!projectId}
onClick={(e) => {
if (!projectId) {
e.preventDefault();
} else {
void openAttachment(projectId, attachment);
}
}}
aria-disabled={!projectId}
aria-describedby={!projectId ? scoreRequiresProjectId : undefined}
aria-current={selected?.id === attachment.id ? "true" : undefined}
aria-label={`${t("scoreOpen")}: ${attachment.fileName}`}
className="flex min-h-10 min-w-0 flex-1 items-center gap-2 text-left text-sm font-semibold text-slate-100 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300 disabled:cursor-not-allowed disabled:opacity-60"
title={!projectId ? t("scoreNavDisabledHint") : undefined}
className="flex min-h-10 min-w-0 flex-1 items-center gap-2 text-left text-sm font-semibold text-slate-100 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-cyan-300 aria-disabled:cursor-not-allowed aria-disabled:opacity-60"
>
<FileMusic className="size-4 shrink-0 text-cyan-300" aria-hidden="true" />
<span className="truncate">{attachment.fileName}</span>
</button>
<Button
variant="outline"
size="icon"
onClick={projectId ? () => void handleRemove(projectId, attachment) : undefined}
disabled={!projectId}
onClick={(e) => {
if (!projectId) {
e.preventDefault();
} else {
void handleRemove(projectId, attachment);
}
}}
aria-disabled={!projectId}
aria-describedby={!projectId ? scoreRequiresProjectId : undefined}
aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"
title={`${t("scoreRemove")}: ${attachment.fileName}`}
className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10 aria-disabled:cursor-not-allowed aria-disabled:opacity-60"
>
<Trash2 className="size-4" aria-hidden="true" />
</Button>
Expand Down
23 changes: 18 additions & 5 deletions apps/desktop/src/features/score/ScoreViewer.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { act, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { act, createEvent, fireEvent, render, screen, waitFor } from "@testing-library/react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import type { PDFDocumentLoadingTask, PDFDocumentProxy } from "pdfjs-dist";
import { ScoreViewer } from "./ScoreViewer";
Expand Down Expand Up @@ -120,8 +120,15 @@ describe("ScoreViewer", () => {
expect(page.render).toHaveBeenCalled();
});
expect(page.getViewport).toHaveBeenCalledWith({ scale: 1 });
expect(screen.getByRole("button", { name: "Previous page" })).toBeDisabled();
expect(screen.getByRole("button", { name: "Next page" })).toBeEnabled();
const prevBtn = screen.getByRole("button", { name: "Previous page" });
const nextBtn = screen.getByRole("button", { name: "Next page" });
expect(prevBtn).toHaveAttribute("aria-disabled", "true");
expect(prevBtn).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");
expect(nextBtn).toHaveAttribute("aria-disabled", "false");

const clickEvent = createEvent.click(prevBtn);
fireEvent(prevBtn, clickEvent);
expect(clickEvent.defaultPrevented).toBe(true);
});

it("shows the file name when provided", async () => {
Expand Down Expand Up @@ -174,14 +181,20 @@ describe("ScoreViewer", () => {
expect(await screen.findByText("Page 1 of 3")).toBeInTheDocument();
const previousButton = screen.getByRole("button", { name: "Previous page" });
const nextButton = screen.getByRole("button", { name: "Next page" });
expect(previousButton).toBeDisabled();
expect(previousButton).toHaveAttribute("aria-disabled", "true");
expect(previousButton).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");

fireEvent.click(nextButton);
expect(screen.getByText("Page 2 of 3")).toBeInTheDocument();

fireEvent.click(nextButton);
expect(screen.getByText("Page 3 of 3")).toBeInTheDocument();
expect(nextButton).toBeDisabled();
expect(nextButton).toHaveAttribute("aria-disabled", "true");
expect(nextButton).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");

const clickEvent = createEvent.click(nextButton);
fireEvent(nextButton, clickEvent);
expect(clickEvent.defaultPrevented).toBe(true);

await waitFor(() => {
expect(doc.getPage).toHaveBeenCalledWith(3);
Expand Down
37 changes: 31 additions & 6 deletions apps/desktop/src/features/score/ScoreViewer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
size="icon-lg"
className="size-12"
aria-label={t("scoreViewerZoomOut")}
title={t("scoreViewerZoomOut")}
onClick={zoomOut}
>
<ZoomOut aria-hidden="true" />
Expand All @@ -267,6 +268,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
size="icon-lg"
className="size-12"
aria-label={t("scoreViewerZoomIn")}
title={t("scoreViewerZoomIn")}
onClick={zoomIn}
>
<ZoomIn aria-hidden="true" />
Expand All @@ -275,6 +277,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
variant={fitWidth ? "secondary" : "outline"}
className="h-12 px-4 text-base"
aria-label={t("scoreViewerFitWidth")}
title={t("scoreViewerFitWidth")}
aria-pressed={fitWidth}
onClick={fitToWidth}
>
Expand All @@ -290,10 +293,21 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
<Button
variant="outline"
size="icon-lg"
className="size-14"
className="size-14 aria-disabled:cursor-not-allowed aria-disabled:opacity-60"
aria-label={t("scoreViewerPrevPage")}
disabled={pageNumber <= 1}
onClick={goToPreviousPage}
title={
pageNumber <= 1
? t("scoreViewerPrevPageDisabled")
: t("scoreViewerPrevPage")
}
aria-disabled={pageNumber <= 1}
onClick={(e) => {
if (pageNumber <= 1) {
e.preventDefault();
} else {
goToPreviousPage();
}
}}
>
<ChevronLeft className="size-6" aria-hidden="true" />
</Button>
Expand All @@ -303,10 +317,21 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
<Button
variant="outline"
size="icon-lg"
className="size-14"
className="size-14 aria-disabled:cursor-not-allowed aria-disabled:opacity-60"
aria-label={t("scoreViewerNextPage")}
disabled={pageNumber >= pageCount}
onClick={goToNextPage}
title={
pageNumber >= pageCount
? t("scoreViewerNextPageDisabled")
: t("scoreViewerNextPage")
}
aria-disabled={pageNumber >= pageCount}
onClick={(e) => {
if (pageNumber >= pageCount) {
e.preventDefault();
} else {
goToNextPage();
}
}}
>
<ChevronRight className="size-6" aria-hidden="true" />
</Button>
Expand Down
4 changes: 3 additions & 1 deletion apps/desktop/src/locales/en/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,7 @@
"practiceProgressRegionLabel": "Practice Progress",
"practiceProgressLabel": "Practice Progress",
"decreasePracticeProgressLabel": "Decrease progress",
"increasePracticeProgressLabel": "Increase progress"
"increasePracticeProgressLabel": "Increase progress",
"scoreViewerPrevPageDisabled": "Previous page (Unavailable)",
"scoreViewerNextPageDisabled": "Next page (Unavailable)"
}
4 changes: 3 additions & 1 deletion apps/desktop/src/locales/ko/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,7 @@
"practiceProgressRegionLabel": "์—ฐ์Šต ์ง„์ฒ™๋„",
"practiceProgressLabel": "์—ฐ์Šต ์ง„์ฒ™๋„",
"decreasePracticeProgressLabel": "์ง„์ฒ™๋„ ๊ฐ์†Œ",
"increasePracticeProgressLabel": "์ง„์ฒ™๋„ ์ฆ๊ฐ€"
"increasePracticeProgressLabel": "์ง„์ฒ™๋„ ์ฆ๊ฐ€",
"scoreViewerPrevPageDisabled": "์ด์ „ ํŽ˜์ด์ง€ (์‚ฌ์šฉ ๋ถˆ๊ฐ€)",
"scoreViewerNextPageDisabled": "๋‹ค์Œ ํŽ˜์ด์ง€ (์‚ฌ์šฉ ๋ถˆ๊ฐ€)"
}
Loading