Skip to content

feat(workspace): name tonight's first leftover sit-out on the map - #1100

Open
seonghobae wants to merge 8 commits into
developfrom
feat/workspace-first-leftover
Open

feat(workspace): name tonight's first leftover sit-out on the map#1100
seonghobae wants to merge 8 commits into
developfrom
feat/workspace-first-leftover

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Product outcome

The ready rehearsal map names tonight's first leftover sit-out after a partial return from existing partGraph evidence so returning parts play without waiting and the leftover part stays out. This is not a come-in, tacet, dropout, tutti, handoff, Fine, last-line breath, a continued sit-out with nobody returning, a new dropout after every original sit-out returns, or a new MIR product.

Exact current identity

  • Protected target: develop@749511c3ad4000090048718f685c6bee6b3d2c25.
  • Exact current head: f1034348f580da2351558824c0014c31f59f52ca.
  • Branch: feat/workspace-first-leftover.

Current exact scope

  • firstLeftover admits a named section with at least one own-property sit-out, then a later named section where at least one previously sitting-out named part is own-property active and at least one previously sitting-out named part is still own-property tacet.
  • Blank labels, missing graph nodes, inherited is_active, missing is_active, unnamed roles, same-section false-then-true nodes, all-active later sections (tuttis), continued sit-outs with nobody returning, new dropouts after a full original return, and malformed roots fail closed.
  • When a role is selected, only a leftover section that includes that named part is shown. Returning parts get play-without-waiting copy; the leftover part gets stay-out copy.
  • Ready workspace copy names the next action: play the named section without waiting, stay out of the named section, or confirm who stays tacet after others return before the first section when the leftover is missing.
  • AGENTS / CLAUDE / ARCHITECTURE / CHANGELOG and the component contract stay current.
  • Doctoring: docs/doctoring/first-leftover.md.

Distinct from adjacent first-X work

Merge gate


Devin Review

Name the first leftover sit-out after a partial return from existing
partGraph evidence so returning parts play without waiting and the
leftover part stays out.
@seonghobae seonghobae added area: ui-ux Frontend, interaction, design, or user experience priority: medium Normal-priority or P2 work type: feature New or expanded product capability scope: product-gap Customer-visible product gap labels Aug 31, 2026
@seonghobae seonghobae added the status: needs-review Open pull request requiring current-head review or checks label Aug 31, 2026 — with Grok (by xAI)
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 2 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: beb19a8e-c305-4dd4-92fb-1936843b3247

📥 Commits

Reviewing files that changed from the base of the PR and between 749511c and 6984d99.

📒 Files selected for processing (14)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.md
  • CLAUDE.md
  • apps/desktop/src/features/workspace/Workspace.test.tsx
  • apps/desktop/src/features/workspace/Workspace.tsx
  • apps/desktop/src/features/workspace/firstLeftover.selected-role.test.ts
  • apps/desktop/src/features/workspace/firstLeftover.test.ts
  • apps/desktop/src/features/workspace/firstLeftover.ts
  • apps/desktop/src/i18n/index.test.ts
  • apps/desktop/src/locales/en/common.json
  • apps/desktop/src/locales/ko/common.json
  • docs/design-system/component-contract.md
  • docs/doctoring/first-leftover.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 5 potential issues.

Devin Review

Comment thread apps/desktop/src/features/workspace/firstLeftover.ts Outdated
Comment thread apps/desktop/src/features/workspace/firstLeftover.ts Outdated
Comment thread apps/desktop/src/features/workspace/firstLeftover.ts Outdated
Comment thread apps/desktop/src/features/workspace/firstLeftover.ts Outdated
Comment thread apps/desktop/src/locales/en/common.json

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

This report is out of date. Scroll down for Devin Review's latest report on this PR.

Devin Review found 4 new potential issues.

Devin Review

Comment thread apps/desktop/src/features/workspace/firstLeftover.ts Outdated
Comment thread apps/desktop/src/features/workspace/firstLeftover.ts Outdated
Comment thread apps/desktop/src/features/workspace/firstLeftover.ts
Comment thread apps/desktop/src/features/workspace/firstLeftover.ts Outdated
devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Copy Markdown
Collaborator Author

@opencode-agent Please perform the independent formal review on exact current head 6984d99294a1439d62ab3283f3b254d968f21999 against protected develop@749511c3ad4000090048718f685c6bee6b3d2c25. Verify the song-wide role/complete graph contract, repeated-label chronology, full-return baseline resets, selected-role behavior including the new keep-searching regression for a newly inactive selected part, and fail-closed duplicate/malformed activity evidence. Submit an authenticated formal APPROVED or CHANGES_REQUESTED review on this exact unchanged head; do not mutate the contributor branch or reuse predecessor-head evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ui-ux Frontend, interaction, design, or user experience priority: medium Normal-priority or P2 work scope: product-gap Customer-visible product gap status: needs-review Open pull request requiring current-head review or checks type: feature New or expanded product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant