feat(workspace): name tonight's first breath on the map - #1096
feat(workspace): name tonight's first breath on the map#1096seonghobae wants to merge 6 commits into
Conversation
The ready rehearsal map names the first named section end from existing timeRange.end evidence so the band breathes together before the last line. Sit-out parts stay off this cue. This is not a count-out, count-in, click, chart bar, Fine, or a new MIR product.
|
Warning Review limit reachedNext included review available in 30 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added
area: ui-ux
Grok (by xAI)
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (Array.isArray(sectionValue.partGraph)) { | ||
| let sawSelectedNode = false; | ||
| for (const nodeValue of sectionValue.partGraph) { | ||
| if ( | ||
| !isRuntimeObject(nodeValue) || | ||
| !Object.prototype.hasOwnProperty.call(nodeValue, "role_id") | ||
| ) { | ||
| continue; | ||
| } | ||
| const roleId = meaningfulRangeText(nodeValue.role_id); | ||
| if (roleId !== activeRole) { | ||
| continue; | ||
| } | ||
| sawSelectedNode = true; | ||
| if (isOwnActive(nodeValue)) { | ||
| return true; | ||
| } | ||
| } | ||
| if (sawSelectedNode) { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| if (!Array.isArray(sectionValue.roles)) { | ||
| return false; | ||
| } | ||
| for (const roleValue of sectionValue.roles) { | ||
| if (!isRuntimeObject(roleValue) || !Object.prototype.hasOwnProperty.call(roleValue, "id")) { | ||
| continue; | ||
| } | ||
| if (meaningfulRangeText(roleValue.id) === activeRole) { | ||
| return true; | ||
| } | ||
| } | ||
| return false; |
There was a problem hiding this comment.
📝 Info: Selected sit-outs remain excluded
sectionIncludesActiveRole requires explicit activity when the selected part has a graph node. Known sit-outs cannot re-enter through the role-list fallback.
Was this helpful? React with 👍 or 👎 to provide feedback.
| if ( | ||
| !isRuntimeObject(sectionValue.timeRange) || | ||
| !Object.prototype.hasOwnProperty.call(sectionValue.timeRange, "start") || | ||
| !Object.prototype.hasOwnProperty.call(sectionValue.timeRange, "end") | ||
| ) { | ||
| continue; | ||
| } | ||
| const start = sectionValue.timeRange.start; | ||
| const end = sectionValue.timeRange.end; | ||
| if (typeof start !== "number" || !Number.isFinite(start) || start < 0) { | ||
| continue; | ||
| } | ||
| const endTime = formatBreathTime(end); | ||
| if (!endTime || typeof end !== "number" || end < start) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
📝 Info: Runtime time checks stay bounded
firstBreath isolates malformed runtime values beyond the stricter shared parser. Normal loaded and analyzed songs already require integer, positive-duration ranges.
Was this helpful? React with 👍 or 👎 to provide feedback.
| "workspaceFirstRangeClash": "{sectionLabel}의 {roleName}은 {lowestNote}–{highestNote}이고 다른 파트와 겹칩니다. {sectionLabel} 들어가기 전에 그 충돌을 악기로 들어 보세요.", | ||
| "workspaceFirstRangeMissing": "오늘 먼저 볼 음역은 아직 귀로 확인이 필요합니다. 선택한 파트의 최저·최고음을 첫 구간 전에 확인해 보세요.", | ||
| "workspaceFirstBreathTitle": "오늘 먼저 맞출 구간 끝", | ||
| "workspaceFirstBreathNamed": "{sectionLabel}은 {endTime}에 끝납니다. 구간 경계에서 함께 마무리해 보세요.", |
There was a problem hiding this comment.
🔍 Korean cue drops breath action
The Korean named state tells players to finish at the boundary, not breathe before the last line. The workspace contract still requires that cue.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Product outcome
The ready rehearsal map names tonight's first last-line breath from existing
timeRange.endevidence so the band finishes the phrase together. Sit-out parts stay off this cue. This is not a count-out, count-in, click, chart bar, Fine, or a new MIR product.Exact current identity
develop@749511c3ad4000090048718f685c6bee6b3d2c25.d40a029.feat/workspace-first-breath.Current exact scope
firstBreathadmits own-property finite non-negative section ends at or after the matching start and formats them asm:ss.partGraphnode (or a named role when no graph node exists) owns the breath.docs/doctoring/first-breath.md.Merge gate
developshipped truth. This branch inherits that JavaScript baseline and does not duplicate or suppress it.