feat(workspace): name tonight's first D.C. al Fine on the map - #1091
feat(workspace): name tonight's first D.C. al Fine on the map#1091seonghobae wants to merge 1 commit into
Conversation
Show a trusted D.C. al Fine on the ready rehearsal map so the room can return to the beginning and end at Fine, then check tonight's first range. Fail closed on sibling navigation, inherited labels, and unverified beginning or Fine destinations. Do not invent D.C. al Fine from MIR.
seonghobae
added
area: ui-ux
Grok (by xAI)
|
Warning Review limit reachedNext included review available in 18 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| if (typeof value.label !== "string") { | ||
| return invalidField(`${path}.label`); |
There was a problem hiding this comment.
🟡 Inherited labels pass shared validation
When dcAlFine inherits label, validateRehearsalDcAlFine accepts it and parseRehearsalSong clones an empty marker. The workspace then reports the saved instruction as missing.
| if (typeof value.label !== "string") { | |
| return invalidField(`${path}.label`); | |
| if ( | |
| !Object.prototype.hasOwnProperty.call(value, "label") || | |
| typeof value.label !== "string" | |
| ) { | |
| return invalidField(`${path}.label`); | |
| } |
Was this helpful? React with 👍 or 👎 to provide feedback.
| #[serde( | ||
| default, | ||
| deserialize_with = "deserialize_optional_dc_al_fine", | ||
| skip_serializing_if = "Option::is_none" | ||
| )] | ||
| dc_al_fine: Option<DcAlFinePayload>, |
There was a problem hiding this comment.
📝 Info: Absent markers remain backward-compatible
The custom deserializer defaults an absent dcAlFine but rejects explicit null. Legacy projects still load without gaining a synthetic marker.
Was this helpful? React with 👍 or 👎 to provide feedback.
| result = build_demo_rehearsal_song(audio_features) | ||
| if request["sourceKind"] == "demo": | ||
| result["dcAlFine"] = {"label": "D.C. al Fine"} |
There was a problem hiding this comment.
📝 Info: Local caches preserve marker absence
Only demo requests add dcAlFine. Local-audio cache writes and hits preserve its absence instead of fabricating score notation.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Product outcome
The ready rehearsal map names tonight's first stored D.C. al Fine so the room can return to the beginning and end at Fine, then check tonight's first range. Customer copy stays target-agnostic: this is not MIR beginning/Fine detection, a destination mark, OCR, or a form tag. It is distinct from Da Capo, Dal Segno, Fine, To Coda, Coda, D.S. al Coda, D.C. al Coda, and D.S. al Fine.
Exact current identity
develop@749511c3ad4000090048718f685c6bee6b3d2c25.edab7e3bab8a6f2a6174a35131a68a4e5047fe3d.Current exact scope
{ label }onsong.dcAlFine:D.C. al FineorD.C. al Fine 1–D.C. al Fine 9.Authority
words/soundwith da capo and fine). https://www.w3.org/2021/06/musicxml40/musicxml-reference/elements/sound/docs/doctoring/workspace-first-dc-al-fine.md.Dependency / merge gate
developshipped truth. This branch inherits that JavaScript baseline and does not duplicate or suppress it. Inherited npm HIGH findings must not be suppressed here.