Skip to content

feat(project): add versioned project file envelope - #1073

Merged
seonghobae merged 2 commits into
fix/project-save-atomic-publication-962from
codex/project-format-v1
Aug 30, 2026
Merged

feat(project): add versioned project file envelope#1073
seonghobae merged 2 commits into
fix/project-save-atomic-publication-962from
codex/project-format-v1

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Security Notes

  • Imported project bytes remain untrusted and are parsed through deny_unknown_fields payloads.
  • The versioned reader fails closed for unknown fields and unsupported versions; file publication continues through the existing fix(project): stage saves before atomic publication #970 bounded atomic publisher.
  • No paths, URLs, subprocesses, IPC commands, network calls, or raw project payloads are added to logs.

Verification

  • cargo fmt --all -- --check
  • cargo test --manifest-path apps/desktop/core/Cargo.toml (22 passed)
  • cargo test --manifest-path apps/desktop/src-tauri/Cargo.toml (full persistence suite passed)
  • cargo clippy --manifest-path apps/desktop/src-tauri/Cargo.toml --all-targets --no-default-features -- -D warnings
  • desktop Vite build with npm 10.9.9
  • verify_docs.py, verify_security_notes.py, verify_supply_chain.py, git diff --check

Deliberate boundary

This slice does not fabricate source/derived/decision/handoff/preferences/runtime fields or create a competing player store. Those typed sections, autosave, backup, migration receipts, and accessible recovery choices remain follow-up work under #962.


Devin Review

@coderabbitai

coderabbitai Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7ba4ad29-1683-4497-93a4-a8e1f16c563b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Devin Review

Comment thread apps/desktop/core/src/lib.rs Outdated
Comment thread apps/desktop/core/src/lib.rs
Comment thread apps/desktop/core/src/lib.rs Outdated
@seonghobae
seonghobae merged commit 14fa46c into fix/project-save-atomic-publication-962 Aug 30, 2026
2 checks passed
@seonghobae
seonghobae deleted the codex/project-format-v1 branch August 30, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant