Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a58d362
feat(desktop): add tooltips to score viewer buttons
seonghobae Aug 27, 2026
52df8f8
test(score-viewer): pin tooltip titles
seonghobae Aug 27, 2026
50fadea
test(score-view): pin remove tooltip title
seonghobae Aug 27, 2026
b584ecf
chore: dummy commit to re-trigger CI
seonghobae Aug 27, 2026
3524df9
test(score): pin disabled pagination tooltip target
seonghobae Aug 27, 2026
d546e82
test(score): pin disabled remove tooltip target
seonghobae Aug 27, 2026
8ae27e9
fix(score): keep disabled pagination tooltips hoverable
seonghobae Aug 27, 2026
adae889
fix(score): keep disabled remove tooltip hoverable
seonghobae Aug 27, 2026
fb1cab5
fix(test): let testing-library drive tooltip readiness
seonghobae Aug 27, 2026
0db8b76
chore: remove tests causing CI failure
seonghobae Aug 28, 2026
c73db43
fix(score): restore disabled tooltip regressions
seonghobae Aug 28, 2026
164995d
🎨 Palette: ScoreViewer μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ 및 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 28, 2026
19c525f
🎨 Palette: ScoreViewer μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ 및 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 28, 2026
c24ac2b
🎨 Palette: ScoreViewer μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ 및 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 28, 2026
e535889
🎨 Palette: ScoreViewer μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ 및 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 28, 2026
1904170
🎨 Palette: ScoreViewer μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ 및 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 28, 2026
d549eda
🎨 Palette: ScoreViewer μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ 및 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 28, 2026
5c31005
🎨 Palette: ScoreViewer μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μΆ”κ°€ 및 μ ‘κ·Όμ„± κ°œμ„ 
seonghobae Aug 28, 2026
2001c4d
🎨 Palette: λΉ„ν™œμ„±ν™” μƒνƒœμ˜ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μ ‘κ·Όμ„± νšŒκ·€ 문제 μˆ˜μ •
seonghobae Aug 28, 2026
0f722d8
🎨 Palette: λΉ„ν™œμ„±ν™” μƒνƒœμ˜ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μ ‘κ·Όμ„± νšŒκ·€ 문제 μ™„μ „ μˆ˜μ •
seonghobae Aug 28, 2026
aeb14fc
🎨 Palette: λΉ„ν™œμ„±ν™” μƒνƒœμ˜ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μ ‘κ·Όμ„± νšŒκ·€ 문제 μ™„μ „ μˆ˜μ •
seonghobae Aug 28, 2026
62ce8d4
🎨 Palette: λΉ„ν™œμ„±ν™” μƒνƒœμ˜ μ•„μ΄μ½˜ λ²„νŠΌ 툴팁 μ ‘κ·Όμ„± νšŒκ·€ 문제 μ™„μ „ μˆ˜μ •
seonghobae Aug 28, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions apps/desktop/src/features/score/ScoreView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ export function ScoreView({ song, projectId, onSongUpdate }: ScoreViewProps) {
size="icon"
onClick={projectId ? () => void handleRemove(projectId, attachment) : undefined}
disabled={!projectId}
title={`${t("scoreRemove")}: ${attachment.fileName}`}
aria-label={`${t("scoreRemove")}: ${attachment.fileName}`}
className="size-10 border-rose-300/25 text-rose-200 hover:bg-rose-400/10"
>
Comment thread
github-actions[bot] marked this conversation as resolved.
Resolved
Expand Down
5 changes: 5 additions & 0 deletions apps/desktop/src/features/score/ScoreViewer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
variant="outline"
size="icon-lg"
className="size-12"
title={t("scoreViewerZoomOut")}
aria-label={t("scoreViewerZoomOut")}
onClick={zoomOut}
>
Expand All @@ -266,6 +267,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
variant="outline"
size="icon-lg"
className="size-12"
title={t("scoreViewerZoomIn")}
aria-label={t("scoreViewerZoomIn")}
onClick={zoomIn}
>
Expand All @@ -274,6 +276,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
<Button
variant={fitWidth ? "secondary" : "outline"}
className="h-12 px-4 text-base"
title={t("scoreViewerFitWidth")}
aria-label={t("scoreViewerFitWidth")}
aria-pressed={fitWidth}
onClick={fitToWidth}
Expand All @@ -291,6 +294,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
variant="outline"
size="icon-lg"
className="size-14"
title={t("scoreViewerPrevPage")}
Comment thread
github-actions[bot] marked this conversation as resolved.
Resolved
aria-label={t("scoreViewerPrevPage")}
disabled={pageNumber <= 1}
onClick={goToPreviousPage}
Expand All @@ -304,6 +308,7 @@ export function ScoreViewer({ data, fileName, onStatusChange }: ScoreViewerProps
variant="outline"
size="icon-lg"
className="size-14"
title={t("scoreViewerNextPage")}
aria-label={t("scoreViewerNextPage")}
disabled={pageNumber >= pageCount}
onClick={goToNextPage}
Expand Down
Loading