Skip to content

πŸ›‘οΈ Sentinel: [HIGH] CSV μˆ˜μ‹ μ£Όμž… λ°©μ§€ κΈ°λŠ₯ 우회(NUL λ°”μ΄νŠΈ) 취약점 μˆ˜μ • - #1035

Closed
seonghobae wants to merge 1 commit into
developfrom
fix/csv-injection-nul-byte-5296523471095022614
Closed

πŸ›‘οΈ Sentinel: [HIGH] CSV μˆ˜μ‹ μ£Όμž… λ°©μ§€ κΈ°λŠ₯ 우회(NUL λ°”μ΄νŠΈ) 취약점 μˆ˜μ •#1035
seonghobae wants to merge 1 commit into
developfrom
fix/csv-injection-nul-byte-5296523471095022614

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

🚨 심각도: HIGH (κ³ μœ„ν—˜)
πŸ’‘ 취약점: CSV 내보내기 μ‹œ μ•…μ˜μ μΈ μ‚¬μš©μžκ°€ μž…λ ₯κ°’ μ•žμ— NUL λ°”μ΄νŠΈ(\x00)λ₯Ό μΆ”κ°€ν•˜μ—¬ =, +, -, @ 문자λ₯Ό λ‚œλ…ν™”ν•  수 μžˆμŠ΅λ‹ˆλ‹€. 기쑴의 CSV μˆ˜μ‹ μ£Όμž… λ°©μ§€ μ •κ·œμ‹μ€ 이λ₯Ό νƒμ§€ν•˜μ§€ λͺ»ν•˜μ§€λ§Œ, Excel λ“±μ˜ μŠ€ν”„λ ˆλ“œμ‹œνŠΈ ν”„λ‘œκ·Έλž¨μ€ NUL λ°”μ΄νŠΈλ₯Ό λ¬΄μ‹œν•˜κ³  λ’€λ”°λ₯΄λŠ” μˆ˜μ‹μ„ μ‹€ν–‰ν•©λ‹ˆλ‹€.
🎯 영ν–₯: μ•…μ„± μˆ˜μ‹ μ£Όμž…μ„ 톡해 μž„μ˜ μ½”λ“œ μ‹€ν–‰μ΄λ‚˜ 정보 유좜이 λ°œμƒν•  수 μžˆμŠ΅λ‹ˆλ‹€.
πŸ”§ ν•΄κ²°: apps/desktop/src/lib/export.ts의 escapeCsvField ν•¨μˆ˜ λ‚΄ μ •κ·œμ‹ ν΄λž˜μŠ€μ— NUL λ°”μ΄νŠΈ(\x00)λ₯Ό λͺ…μ‹œμ μœΌλ‘œ μΆ”κ°€ν•˜μ—¬, ν•΄λ‹Ή 문자둜 μ‹œμž‘ν•˜λŠ” μž…λ ₯값도 μ•ˆμ „ν•˜κ²Œ μ΄μŠ€μΌ€μ΄ν”„ μ²˜λ¦¬ν•˜λ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
βœ… 검증: apps/desktop/src/lib/export.test.ts에 NUL λ°”μ΄νŠΈλ₯Ό ν™œμš©ν•œ 우회 μ‹œλ„λ₯Ό μ°¨λ‹¨ν•˜λŠ” λ‹¨μœ„ ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜κ³  λͺ¨λ“  ν…ŒμŠ€νŠΈλ₯Ό 톡과함을 ν™•μΈν–ˆμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 5296523471095022614 started by @seonghobae


Open in Devin Review

@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 43 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d21e5b4-d19a-458a-95da-aff25458bba1

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 7ad56cf and 6e1eaa2.

πŸ“’ Files selected for processing (3)
  • .jules/sentinel.md
  • apps/desktop/src/lib/export.test.ts
  • apps/desktop/src/lib/export.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

βœ… Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Copy link
Copy Markdown
Collaborator Author

Closing as an exact semantic duplicate of the canonical CSV-security owner #941 after fresh head/diff comparison.

Current identities immediately before this state change:

#1035's production delta only adds \x00 to the older ^[\s\uFEFF\xA0]*... formula-prefix regex and adds four NUL+ASCII-operator tests. #941 already owns that behavior and a strictly stronger boundary: NUL itself is dangerous, TAB/CR/LF/FF/VT are not swallowed by \s*, full-width spreadsheet operators are covered, spacing/BOM handling is explicit, and the regression suite includes direct control-token cases plus NUL/operator cases. #941 also carries the doctoring/traceability for this trust boundary. #1035 has no unique buyer-visible or security behavior worth preserving; .jules/sentinel.md is task metadata, not independent production authority.

Keeping #1035 open would create a competing writer for the same security boundary and could regress #941's stronger first-effective-token contract. Preserve CSV formula-injection authority on #941; no changes from #1035 are being merged.

@seonghobae seonghobae closed this Aug 26, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as an exact semantic duplicate of the canonical CSV-security owner #941 after fresh head/diff comparison.

Current identities immediately before this state change:

#1035's production delta only adds \x00 to the older ^[\s\uFEFF\xA0]*... formula-prefix regex and adds four NUL+ASCII-operator tests. #941 already owns that behavior and a strictly stronger boundary: NUL itself is dangerous, TAB/CR/LF/FF/VT are not swallowed by \s*, full-width spreadsheet operators are covered, spacing/BOM handling is explicit, and the regression suite includes direct control-token cases plus NUL/operator cases. #941 also carries the doctoring/traceability for this trust boundary. #1035 has no unique buyer-visible or security behavior worth preserving; .jules/sentinel.md is task metadata, not independent production authority.

Keeping #1035 open would create a competing writer for the same security boundary and could regress #941's stronger first-effective-token contract. Preserve CSV formula-injection authority on #941; no changes from #1035 are being merged.

Understood. Acknowledging that this work is now an exact semantic duplicate and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant