Skip to content

🎨 Palette: λ²„νŠΌμ˜ μ ‘κ·Όμ„± μƒνƒœμ— μ‹œκ°μ  μŠ€νƒ€μΌ μΆ”κ°€ (visual parity) - #991

Closed
seonghobae wants to merge 1 commit into
developfrom
palette-visual-parity-buttons-968767814827405073
Closed

🎨 Palette: λ²„νŠΌμ˜ μ ‘κ·Όμ„± μƒνƒœμ— μ‹œκ°μ  μŠ€νƒ€μΌ μΆ”κ°€ (visual parity)#991
seonghobae wants to merge 1 commit into
developfrom
palette-visual-parity-buttons-968767814827405073

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

πŸ’‘ What: disabled 및 aria-busy μƒνƒœμΈ λ²„νŠΌμ— λŒ€ν•œ μ‹œκ°μ  ν”Όλ“œλ°±(opacity: 0.6; cursor: not-allowed;)을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
🎯 Why: 슀크린 리더와 같은 보쑰 기술 μ‚¬μš©μžλΏλ§Œ μ•„λ‹ˆλΌ μ‹œκ°μ  μ‚¬μš©μžμ—κ²Œλ„ λ²„νŠΌμ΄ ν˜„μž¬ λΉ„ν™œμ„±ν™”λ˜μ–΄ μžˆκ±°λ‚˜ 처리 μ€‘μž„μ„ λͺ…ν™•νžˆ 인지할 수 μžˆλ„λ‘ μ‹œκ°μ  일관성(visual parity)을 μ œκ³΅ν•˜κΈ° μœ„ν•¨μž…λ‹ˆλ‹€.
πŸ“Έ Before/After: μ²¨λΆ€λœ μŠ€ν¬λ¦°μƒ· μ°Έμ‘° (λΉ„ν™œμ„±ν™”/처리 쀑인 λ²„νŠΌμ˜ 투λͺ…도 κ°μ†Œ 및 μ»€μ„œ λ³€κ²½).
β™Ώ Accessibility: μ ‘κ·Όμ„± μƒνƒœ 트리(aria-busy)와 μ‹œκ°μ  λ Œλ”λ§ κ°„μ˜ 괴리λ₯Ό ν•΄κ²°ν•˜μ—¬, λͺ¨λ“  μ‚¬μš©μžμ—κ²Œ λ™μΌν•œ μƒνƒœ 정보λ₯Ό μ œκ³΅ν•©λ‹ˆλ‹€.


PR created automatically by Jules for task 968767814827405073 started by @seonghobae

Summary by CodeRabbit

  • μ ‘κ·Όμ„± κ°œμ„ 
    • λΉ„ν™œμ„±ν™”λ˜μ—ˆκ±°λ‚˜ 처리 쀑인 λ²„νŠΌμ΄ μ‹œκ°μ μœΌλ‘œ κ΅¬λΆ„λ˜λ„λ‘ 투λͺ…도와 μ»€μ„œ ν‘œμ‹œλ₯Ό κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
    • μ ‘κ·Όμ„± μƒνƒœμ™€ ν™”λ©΄ ν‘œμ‹œκ°€ μΌμΉ˜ν•˜λ„λ‘ κ΄€λ ¨ κ°€μ΄λ“œλ₯Ό λ³΄μ™„ν–ˆμŠ΅λ‹ˆλ‹€.

- Add CSS rules `opacity: 0.6` and `cursor: not-allowed` to `button:disabled` and `button[aria-busy="true"]` in console.html.
- Update .jules/palette.md with UX learning on visual parity for ARIA states.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-project-automation github-project-automation Bot moved this to Backlog in Security Aug 19, 2026
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 36ea7253-ebc8-4653-8f44-bd4ba9284163

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between a68b57d and 299d239.

πŸ“’ Files selected for processing (2)
  • .jules/palette.md
  • scanner/dashboard/console.html

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


πŸ“ Walkthrough

Walkthrough

λΉ„ν™œμ„± 및 λ‘œλ”© λ²„νŠΌμ— μ‹œκ°μ  μƒνƒœλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€. κ΄€λ ¨ μ ‘κ·Όμ„± 지침도 .jules/palette.md에 κΈ°λ‘ν–ˆμŠ΅λ‹ˆλ‹€.

Changes

μ ‘κ·Όμ„± μƒνƒœ μ‹œκ°ν™”

Layer / File(s) Summary
λ²„νŠΌ μƒνƒœ μŠ€νƒ€μΌ 및 μ§€μΉ¨
scanner/dashboard/console.html, .jules/palette.md
button:disabled 및 button[aria-busy="true"]에 투λͺ…도와 not-allowed μ»€μ„œλ₯Ό μ μš©ν–ˆμŠ΅λ‹ˆλ‹€. μ ‘κ·Όμ„± μƒνƒœλ₯Ό μ‹œκ°μ  CSS μƒνƒœμ™€ μΌμΉ˜μ‹œν‚€λŠ” 지침을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.

Estimated code review effort: 1 (간단) | ~5λΆ„

Merge Risk: βšͺ Minimal Β· up to 299d2

The PR adds visual styling for disabled and busy buttons without supplied evidence of a correctness, security, availability, or deployment risk. It is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining.

Possibly related PRs

  • ContextualWisdomLab/appguardrail#930: λ™μΌν•œ λŒ€μ‹œλ³΄λ“œ 파일과 μ§€μΉ¨μ—μ„œ λΉ„ν™œμ„± 및 λ‘œλ”© μƒνƒœμ˜ μ‹œκ°ν™”λ₯Ό λ‹€λ£Ήλ‹ˆλ‹€.
  • ContextualWisdomLab/appguardrail#974: λ™μΌν•œ μ ‘κ·Όμ„± μ§€μΉ¨κ³Ό λ²„νŠΌ μƒνƒœ CSSλ₯Ό λ³€κ²½ν•©λ‹ˆλ‹€.
  • ContextualWisdomLab/appguardrail#986: λ™μΌν•œ νŒŒμΌμ— λΉ„ν™œμ„± 및 λ‘œλ”© μƒνƒœμ˜ μ‹œκ°μ  λ™μž‘μ„ μΆ”κ°€ν•©λ‹ˆλ‹€.
πŸš₯ Pre-merge checks | βœ… 5
βœ… Passed checks (5 passed)
Check name Status Explanation
Description Check βœ… Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check βœ… Passed 제λͺ©μ€ λ²„νŠΌμ˜ μ ‘κ·Όμ„± μƒνƒœμ— μ‹œκ°μ  μŠ€νƒ€μΌμ„ μΆ”κ°€ν•˜λŠ” μ£Όμš” λ³€κ²½ 사항을 λͺ…ν™•ν•˜κ²Œ μš”μ•½ν•©λ‹ˆλ‹€.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-visual-parity-buttons-968767814827405073

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing as superseded by #977. The only product delta here is visual parity for disabled/busy buttons; #977 carries that behavior with the shared --busy-opacity token, separates progress from true unavailability, covers busy scan rows and cleanup, and has executable contracts preventing the unsafe global busy selector. No unique buyer behavior remains in this branch.

@seonghobae seonghobae closed this Aug 20, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Security Aug 20, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #977. The only product delta here is visual parity for disabled/busy buttons; #977 carries that behavior with the shared --busy-opacity token, separates progress from true unavailability, covers busy scan rows and cleanup, and has executable contracts preventing the unsafe global busy selector. No unique buyer behavior remains in this branch.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Copy link
Copy Markdown
Contributor Author

Closing as superseded by the active dashboard design-system successor #977 and its security/accessibility predecessor contract #930. That lane already distinguishes explicit disabled state from transient aria-busy, uses reusable design tokens, preserves pointer and keyboard behavior, carries Storybook/ADR inventory, and reconciles viewer-only authorization and focus handling. This CSS-only branch adds no unique state contract and writes the same console surface.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by the active dashboard design-system successor #977 and its security/accessibility predecessor contract #930. That lane already distinguishes explicit disabled state from transient aria-busy, uses reusable design tokens, preserves pointer and keyboard behavior, carries Storybook/ADR inventory, and reconciles viewer-only authorization and focus handling. This CSS-only branch adds no unique state contract and writes the same console surface.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant