feat(scanner): reject plugin kubectl apply and docker push - #1172
Draft
seonghobae wants to merge 8 commits into
Draft
feat(scanner): reject plugin kubectl apply and docker push#1172seonghobae wants to merge 8 commits into
seonghobae wants to merge 8 commits into
Conversation
Lock hook and manifest kubectl apply and docker push as fail-closed findings. Keep kubectl get, docker ps, terraform apply, helm install, README wording, and GitHub merge on their existing classes. Relates to #1099.
Fail closed on hook and manifest kubectl apply as claude-plugin-kubectl-apply-command and docker push as claude-plugin-docker-push-command. kubectl get, docker ps, terraform apply, helm install, README wording, merge CLI, and Docker sockets stay their existing classes. Relates to #1099.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 2026-09-07 23:37 UTC records Draft #1172 `936311c` stacked on #1171. - Hook kubectl apply and docker push fail closed. - Remaining leftover: deep directory recursion, Cosign/GPG, terraform/helm. Rationale: - #999 is the single writer of the product-technical gap baseline. - Do not Close #1099, #1171, or #1170. Tests: - documentation-only; detector evidence lives on #1172 (1813/1813)
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #1171 / issue #1099. Does not Close those. Merge/release stay #1170. Credential stores stay #1171. Docker sockets stay
claude-plugin-docker-socket. Pass is not Noema admission.Unique delta
Fail closed when a plugin hook or manifest runs cluster or registry write commands:
kubectl applyfails asclaude-plugin-kubectl-apply-command(CWE-269)docker pushanddocker image pushfail asclaude-plugin-docker-push-command(CWE-250)kubectl get,docker ps,terraform apply, andhelm installstay inventorygh pr mergestaysclaude-plugin-github-merge-commandclaude-plugin-docker-socket#1171 remains owner of host cookie and token stores.
Evidence
391358fthen GREEN936311ctests/test_claude_plugin_deployment_write.pyplus sibling merge/credential/supply-chain suitesRelates to #1099. Relates to #1171.
Current shared command-context repair — 2026-09-08
RED
e6d606246de48f3da1cebe5fde60dd62f9b0b99eproves two false-negative classes—structural manifestcommandplus typedargs, and boundedsh|bash -cpayloads—and false positives from description prose, reporting commands, assignment values, and noexec payloads. The repair reuses one structural/shell parser for kubectl and Docker instead of joining arbitrary argv.The first source commit
a6efcf514ed13c491888727606b0e56b5689f02dfailed exact-tree verification because an overly broad source splice deleted the adjacent dynamic-eval analyzer. The non-destructive descendantde1b7c1f443a8347f1212e72ab4ed7ff281903c0restores that analyzer and is the exact head. Exact-head compilation and production probes pass 8/8: four direct-argv/nested-shell positives and four prose/reporting/noexec/assignment negatives. Near verbs, malformed/mixed argv, whitespace executable identity, pull/list operations, andpushLocalstay negative.This custom-base PR remains Draft: it has no hosted workflow, no current-head independent approval, and no unresolved review thread. Successor #1173 includes this exact commit as a second parent and is 0 behind; no stale evidence transfers.
Current GitHub parser predecessor integration — 2026-09-08
Normal two-parent descendant
058fdad051ce05f279a5ef0c4b561815ef9185e1integrates #1171 exact headf288cfa313a26661a3eaa1f8e74681228dfc20d9without force. It retains the GitHub command-context corpus and preserves kubectl/Docker, credential-store, and dynamic-eval deltas. GitHub compare reports 8 ahead / 0 behind. This custom-base PR stays Draft pending fresh hosted integration and independent current-head review; earlier exact-head text is historical evidence only.