feat(scanner): reject plugin checksum files that disagree with the artifact - #1169
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
…tifact Summary: - RED: SHA256SUMS listing plugin.json with a wrong digest does not fail closed. - Matching digests, missing checksum files, and # comments must stay silent. Rationale: - Issue #1099 signature-bind requires first-party checksum files to match bytes on disk. - Cosign/GPG network and #1168 sbom_sha256 stay out of this slice. Tests: - tests/test_claude_plugin_checksum_mismatch.py (8 fail / 9 pass)
…tifact Summary: - First-party SHA256SUMS, SHA256SUMS.txt, checksums.sha256, and *.sha256 next to plugin.json fail closed when a listed digest disagrees with disk bytes. - Matching checksums, # comments, and missing checksum files are not this class. - Snippets are path labels. Cosign/GPG network checks are not required. Rationale: - Issue #1099 signature-bind requires checksum evidence to match the scanned artifact. - sbom_sha256 stays the #1168 CycloneDX receipt digest. Tests: - tests/test_claude_plugin_checksum_mismatch.py (27 passed) - detector statement coverage 2424/2424 on Python 3.13
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 22:18 UTC records Draft #1169 `226ca73` stacked on #1168. - First-party SHA256SUMS that disagree with disk bytes fail closed. - Matching checksums and a missing checksum file are not this class. Rationale: - #999 is the single writer of the product-technical gap baseline. - Cosign/GPG network is not required for this slice. Tests: - documentation-only; detector evidence lives on #1169 (2424/2424)
This was referenced Sep 7, 2026
seonghobae
added
enhancement
ChatGPT Codex Connector
seonghobae
added a commit
that referenced
this pull request
Sep 8, 2026
Summary: - Snapshot 2026-09-08 03:09 UTC records Draft #1175 `eb2389e` stacked on #1174. - Checksum digest rows without a sibling signature fail closed. - Remaining leftover: deep directory recursion. Rationale: - #999 is the single writer of the product-technical gap baseline. - Do not Close #1099, #1174, or #1169. Tests: - documentation-only; detector evidence lives on #1175 (416 passed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #1168 / issue #1099. Does not Close those.
sbom_sha256stays #1168. Pass is not Noema admission.Unique delta
Fail closed when a first-party plugin checksum file disagrees with bytes on disk:
SHA256SUMS,SHA256SUMS.txt,checksums.sha256, or*.sha256next toplugin.jsonsha256sumrows and hex-only siblingplugin.json.sha256files#comments and blank lines ignoredclaude-plugin-checksum-mismatchsbom_sha256remains the #1168 CycloneDX receipt digest and still verifies.Evidence
c23c4cbthen GREEN226ca73tests/test_claude_plugin_checksum_mismatch.py27 passedclaude_plugin_detector.pystatement coverage 2424/2424 on Python 3.13Relates to #1099. Relates to #1168.