feat(scanner): emit Actions poll analyzer findings without double-count - #1152
Draft
seonghobae wants to merge 2 commits into
Draft
feat(scanner): emit Actions poll analyzer findings without double-count#1152seonghobae wants to merge 2 commits into
seonghobae wants to merge 2 commits into
Conversation
Pin production _scan_file contracts for analyzer-only helper loops, reversed comparisons, unreachable exits, and split while/do polls so regex adjacency misses become findings without a third detector ID.
Hook classify_poll_loops into production _scan_file for GitHub Actions workflows and merge by (rule_id, file) so the packaged #1088 identities emit once. Split while/do helper loops, reversed comparisons, and unreachable exits that regex adjacency misses now surface; quoted text and success-path break/exit stay finite.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 15:28 UTC records Draft #1151 `822ca12` on #1150 and Draft #1152 `255cfd8` on #1133. - `_scan_file` emits poll analyzer findings once per (rule_id, file). - Deceptive read-only descriptions fail closed when inventory shows write or egress. Rationale: - #999 is the single writer of the product-technical gap baseline. - G-06 emission waited on #1133 exact-head coverage SUCCESS. Tests: - documentation-only; evidence lives on #1151 (1560/1560) and #1152 (417/417 analyzer statements)
This was referenced Sep 7, 2026
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor of #1133 / G-06 / issue #1087. This stacked slice hooks
classify_poll_loopsinto production_scan_filefor GitHub Actions workflows and merges regex plus analyzer hits by(rule_id, file)so the packaged #1088 corpus is not double-counted.This pull request does not Close #1087 or #1088. It does not Close #1133.
What this adds
_scan_filealso runs the structural poll-loop classifier on.github/workflows/*.{yml,yaml}github-actions-transport-only-poll-boundandgithub-actions-transport-failure-budget-poll-bound(rule_id, file): if regex and analyzer would both report the same identity, emit oncewhile/dohelper loops, reversed comparisons, unreachable fail-closed exits, quoted decoys next to a real pollbreak/exit/returnremains a finite success-path terminator so existing security(actions): detect transport-only verdict poll bounds #1088 regex tests still passVerification
_scan_filecount ofgithub-actions-transport-only-poll-boundis 1tests/test_actions_poll_analyzer_emit.py,tests/test_actions_poll_structural_analyzer.py, and the existing security(actions): detect transport-only verdict poll bounds #1088 poll regex corpusappguardrail_core/actions_poll_analyzer.pyremains 100% statement and branch coverage