feat(scanner): reject unsigned plugin downloads and runtime installers - #1138
Draft
seonghobae wants to merge 3 commits into
Draft
seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
RED coverage for curl -o plus chmod of a fetched binary, unpinned pip/npm/cargo URL installs, lockfile inventory without postinstall download, and snippet redaction of secrets and bidi. Relates to #1099.
Fail closed when hooks download a binary and chmod or execute it, pipe curl/wget to an interpreter, or install from an unpinned package URL. package.json plus a lockfile without a postinstall download stays package_install inventory. GitHub write tokens, Docker sockets, and secret-to-network flows are unchanged. Relates to #1099.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6 tasks
seonghobae
added a commit
that referenced
this pull request
Sep 7, 2026
Summary: - Snapshot 10:28 UTC records Draft #1138 `bdb3809` stacked on #1137. - Unsigned executable downloads and unpinned URL installs fail closed. - Lockfile-only package trees stay package_install inventory. Rationale: - #999 is the single writer of the product-technical gap baseline. - #1099 remaining surfaces stay on stacked successors, not Close. Tests: - documentation-only; detector evidence lives on #1138 (1150/1150)
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claude-plugin-unsigned-executable-download):curl/wgetwriting a binary thenchmod +xor executing it, and installer bootstrap such ascurl | python.claude-plugin-unpinned-package-install):pip/npm/cargo installofhttps://orgit+URLs.echo histill passes.package.jsonplus a lockfile without a postinstall download ispackage_installinventory, not a finding. Ordinarypip install requestsandcurlhealthchecks stay inventory.Successor of #1137 / #1136 / #1099 TDD item 9. Does not Close #1099, #1137, #1136, #1135, #1134, #1129, #1087, #929, #983, #1106, #1036, #1133, or #998. Does not steal G-06 #1133. Does not reimplement #1036.
Ordinary restack — 2026-09-12
94d3d7f5b4d7e16a46291f217f9269d88badf8cc, tree31dc2873576a5e666654ca3af19837477411626a.bdb380938b33bd9918eafc433ff3081964bd36a4and current feat(scanner): reject GitHub write tokens and Docker sockets #113707fcbcd0764ff12180e64b7258db96505d1db812.py_compileand diff check passed.Test plan
tests/test_claude_plugin_supply_chain.py(67 passed)gh issue create/docker pushinventory-not-finding contract retainedRelates to #1099. Relates to #1137.