Repository navigation
feat: add baseline package tests and private-safe security audit #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
3df121c
feat: add baseline package tests and private-safe security audit
seonghobae e9956f1
fix: tune private security audit with gitleaks allowlist
seonghobae d0b8c64
fix: address review findings for input recursion and audit integrity
seonghobae c587118
fix: verify downloaded artifact filenames in security audit
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,5 @@ | |
| ^CONTRIBUTING\.md$ | ||
| ^docs$ | ||
| ^docs/.* | ||
| ^registered_agents\.json$ | ||
| ^task_agent_mapping\.json$ | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| name: Security Audit (private-safe) | ||
|
|
||
| on: | ||
| push: | ||
| branches: ["master", "main"] | ||
| pull_request: | ||
| branches: ["master", "main"] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| secret-and-workflow-audit: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Harden runner | ||
| uses: step-security/harden-runner@5ef0c079ce82195b2a36a210272d6b661572d83e | ||
| with: | ||
| egress-policy: audit | ||
|
|
||
| - name: Checkout | ||
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 | ||
|
|
||
| - name: Install gitleaks | ||
| run: | | ||
| curl -sSLo gitleaks.tar.gz "https://github.com/gitleaks/gitleaks/releases/download/v8.24.2/gitleaks_8.24.2_linux_x64.tar.gz" | ||
| tar -xzf gitleaks.tar.gz gitleaks | ||
| chmod +x gitleaks | ||
|
|
||
| - name: Run secret scan (gitleaks) | ||
| run: | | ||
| ./gitleaks detect --source . --no-git --redact --exit-code 1 | ||
|
|
||
| - name: Validate workflows | ||
| run: | | ||
| curl -sSL https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash | bash -s -- 1.7.10 | ||
| ./actionlint | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step pipes and executes
https://raw.githubusercontent.com/rhysd/actionlint/main/scripts/download-actionlint.bash, so every run trusts whatever is on the movingmainbranch at that moment; if upstream changes or is compromised, CI will execute unreviewed code and private-repo source can be exposed from the runner. This also conflicts with the pinned-workflow guardrail in/workspace/aFIPC/AGENTS.md("Keep.github/workflows/green and action SHAs pinned"). Use a commit-pinned URL (or vendor the script) so the executed installer is reproducible and auditable.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved by removing the mutable installer-script pipeline from main and using versioned release assets with checksum verification.