🛡️ Sentinel: [CRITICAL] 입력 값 검증 강화를 통한 DoS(NA Coercion) 방지

.jules/sentinel.md

@@ -2,3 +2,8 @@
 **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
 **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
 **Prevention:** Always implement explicit runtime type validation for optional boolean parameters.
+
+## 2024-08-25 - Fix missing bounded validation for readline inputs
+**Vulnerability:** Unbounded numeric regex validation (e.g., `^[0-9]+$`) for `readline()` allows large inputs that coerce to `NA` via `as.integer()`. This causes downstream `if (variable == 1)` conditions to fail with a `missing value where TRUE/FALSE needed` error, resulting in unhandled exception crashes.
+**Learning:** When reading integer inputs for binary choices, using bounded exact-match regex like `^[12]$` is necessary to prevent coercion crashes and Denial of Service (DoS) vulnerabilities in interactive environments.
+**Prevention:** Always use strict and bounded regex validation for `readline()` input instead of broad numeric matching.

R/aFIPC.R

@@ -141,7 +141,7 @@ autoFIPC <-
       }
       for (attempt in seq_len(3)) {
         n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
-        if (grepl("^[0-9]+$", n)) {
+        if (grepl("^[12]$", n)) {
           return(as.integer(n))
         }
       }
@@ -171,7 +171,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }
@@ -390,7 +390,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }

tests/testthat/test-sentinel-validation.R

@@ -1,7 +1,7 @@
 test_that("autoFIPC validates boolean flags for newformBILOGprior, oldformBILOGprior, and confirmCommonItems", {
   # newformBILOGprior
   expect_error(
-    aFIPC::autoFIPC(
+    autoFIPC(
       newformXData = data.frame(A=1),
       oldformYData = data.frame(A=2),
       newformCommonItemNames = c('A'),
@@ -13,7 +13,7 @@ test_that("autoFIPC validates boolean flags for newformBILOGprior, oldformBILOGp
 
   # oldformBILOGprior
   expect_error(
-    aFIPC::autoFIPC(
+    autoFIPC(
       newformXData = data.frame(A=1),
       oldformYData = data.frame(A=2),
       newformCommonItemNames = c('A'),
@@ -25,7 +25,7 @@ test_that("autoFIPC validates boolean flags for newformBILOGprior, oldformBILOGp
 
   # confirmCommonItems
   expect_error(
-    aFIPC::autoFIPC(
+    autoFIPC(
       newformXData = data.frame(A=1),
       oldformYData = data.frame(A=2),
       newformCommonItemNames = c('A'),
@@ -35,3 +35,23 @@ test_that("autoFIPC validates boolean flags for newformBILOGprior, oldformBILOGp
     "Security Error: confirmCommonItems must be a single non-NA logical value or NULL"
   )
 })
+
+test_that("large numbers do not cause NA coercion errors in autoFIPC readline prompt", {
+
+  # Give a huge number that passes ^[0-9]+$ but fails as.integer()
+  # Then give a valid '2' to continue if it rejects the first one
+  m <- mockery::mock("999999999999999999999999999999", "2", "2", "2")
+  mockery::stub(autoFIPC, 'readline', m)
+  mockery::stub(autoFIPC, 'interactive', TRUE)
+
+  # Check that it rejects the large number correctly by prompting again (which gives 2) and thus stopping
+  expect_error({
+      autoFIPC(
+        newformXData = data.frame(A=c(1,0,1,0), B=c(1,1,0,0)),
+        oldformYData = data.frame(A=c(1,0,1,0), B=c(1,1,0,0)),
+        newformCommonItemNames = c('A'),
+        oldformCommonItemNames = c('A'),
+        confirmCommonItems = NULL
+      )
+  }, "Please write down pairs correctly")
+})