Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix unbounded numeric regex input validation #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 4 commits into from
Closed

πŸ›‘οΈ Sentinel: [CRITICAL] Fix unbounded numeric regex input validation #199

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71a1c74
I have addressed the CRITICAL Sentinel alert regarding unbounded nume…
seonghobae Aug 1, 2026
2edb2ed
Add missing files to .Rbuildignore to fix R CMD check
seonghobae Aug 1, 2026
275003d
Add missing files to .Rbuildignore to fix R CMD check
seonghobae Aug 1, 2026
0c76fcd
Add missing files to .Rbuildignore to fix R CMD check
seonghobae Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@
**Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
**Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
**Prevention:** Always implement explicit runtime type validation for optional boolean parameters.

## 2024-08-01 - Fix Integer Overflow Coercion Vulnerability
**Vulnerability:** Unbounded numeric regular expressions (`^[0-9]+$`) were used to validate interactive inputs before coercing them to integer using `as.integer()`. If excessively large numbers were provided, they would pass the regex check but coercion would produce `NA`, which could cause unexpected downstream failures or crashes.
**Learning:** In R scripts, validating inputs using `^[0-9]+$` does not account for the limits of R's integer representation. This can lead to integer overflow coercion vulnerabilities.
**Prevention:** Strictly match against exact expected values (e.g., `^[12]$`) instead of unbounded digit classes to ensure the input fits safely within R's integer bounds.
6 changes: 3 additions & 3 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ autoFIPC <-
}
for (attempt in seq_len(3)) {
n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down Expand Up @@ -171,7 +171,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down Expand Up @@ -390,7 +390,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down
Loading