Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] λŒ€ν™”ν˜• μž…λ ₯κ°’ 검증 κ°•ν™”λ₯Ό ν†΅ν•œ μ •μˆ˜ μ˜€λ²„ν”Œλ‘œμš° 방지 #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 4 commits into from
Closed

πŸ›‘οΈ Sentinel: [MEDIUM] λŒ€ν™”ν˜• μž…λ ₯κ°’ 검증 κ°•ν™”λ₯Ό ν†΅ν•œ μ •μˆ˜ μ˜€λ²„ν”Œλ‘œμš° 방지 #159

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f71232
πŸ›‘οΈ Sentinel: μž…λ ₯κ°’ 검증 κ°•ν™”λ₯Ό ν†΅ν•œ μ •μˆ˜ μ˜€λ²„ν”Œλ‘œμš° 방지
seonghobae Jul 20, 2026
66665fd
test(security): cover bounded prompt choices
seonghobae Jul 20, 2026
15f573e
πŸ›‘οΈ Sentinel: μž…λ ₯κ°’ 검증 κ°•ν™”λ₯Ό ν†΅ν•œ μ •μˆ˜ μ˜€λ²„ν”Œλ‘œμš° 방지
seonghobae Jul 20, 2026
e37766c
test(security): restore bounded prompt coverage
seonghobae Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .jules/sentinel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@
**Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
**Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
**Prevention:** Always implement explicit runtime type validation for optional boolean parameters.

## 2024-07-20 - Prevent Integer Overflow Coercion Vulnerability in Interactive Prompts
**Vulnerability:** Unbounded digit classes (`^[0-9]+$`) in interactive input validation allow excessively large numeric strings that evaluate to `NA` when coerced with `as.integer()`, which could lead to downstream crashes.
**Learning:** `readline()` input validation should strictly match the exact expected options (e.g., `^[12]$`) rather than generic digit patterns.
**Prevention:** Always use precise regex patterns limiting the length and allowed characters when validating inputs intended for integer conversion in R.
6 changes: 3 additions & 3 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ autoFIPC <-
}
for (attempt in seq_len(3)) {
n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
Comment thread
opencode-agent[bot] marked this conversation as resolved.
Outdated
Comment thread
opencode-agent[bot] marked this conversation as resolved.
Outdated
}
Expand Down Expand Up @@ -171,7 +171,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down Expand Up @@ -390,7 +390,7 @@ autoFIPC <-
readline(
prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
)
if (grepl("^[0-9]+$", n)) {
if (grepl("^[12]$", n)) {
return(as.integer(n))
}
}
Expand Down
Loading