-
Notifications
You must be signed in to change notification settings - Fork 0
feat(temporal): refuse disjoint predictions as observed fact #93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9902a90
feat(temporal): refuse disjoint predictions as observed fact
seonghobae 5daed33
fix(quality): bind crate-root count to the workspace contract
cursoragent 3b30935
fix(temporal): classify promotion with temporal_core Allen relations
cursoragent bc26a06
merge(main): keep prediction gate with landed 0007 and router
cursoragent 8198e96
fix(temporal): require full prediction support for promotion
seonghobae 539eaa3
test(temporal): lock adjacency error wording contract
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| [package] | ||
| name = "prediction_contradiction" | ||
| description = "Predicted intervals that contradict observations cannot become fact." | ||
| version.workspace = true | ||
| edition.workspace = true | ||
| rust-version.workspace = true | ||
| license.workspace = true | ||
| authors.workspace = true | ||
| repository.workspace = true | ||
| homepage.workspace = true | ||
| readme.workspace = true | ||
| keywords.workspace = true | ||
| categories.workspace = true | ||
| publish = false | ||
|
|
||
| [dependencies] | ||
| temporal_core = { path = "../temporal_core", version = "0.1.0" } | ||
|
|
||
| [lints] | ||
| workspace = true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| //! Fail-closed prediction-contradiction errors. | ||
|
|
||
| use std::fmt; | ||
|
|
||
| /// A fail-closed prediction-contradiction error. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| #[non_exhaustive] | ||
| pub enum PredictionContradictionError { | ||
| /// Predicted and observed event-time intervals are Allen `before` or `after`. | ||
| PredictionContradictsObservation, | ||
| /// Predicted and observed intervals meet but do not overlap in their interiors. | ||
| PredictionLacksOverlappingSupport, | ||
| /// Observed evidence covers only part of the predicted interval. | ||
| PredictionLacksFullSupport, | ||
| /// Observed evidence became available after the analysis knowledge cutoff. | ||
| EvidenceAfterCutoff, | ||
| /// An interval is not a closed proper Allen input. | ||
| InvalidIntervalPayload, | ||
| /// An agreement-rate comparison used empty or length-mismatched slices. | ||
| AgreementSliceMismatch, | ||
| } | ||
|
|
||
| impl fmt::Display for PredictionContradictionError { | ||
| fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| let message = match self { | ||
| Self::PredictionContradictsObservation => { | ||
| "predicted interval contradicts observed evidence" | ||
| } | ||
| Self::PredictionLacksOverlappingSupport => { | ||
| "predicted interval is adjacent to observation without overlapping support" | ||
| } | ||
| Self::PredictionLacksFullSupport => { | ||
| "predicted interval is not fully supported by observed evidence" | ||
| } | ||
| Self::EvidenceAfterCutoff => { | ||
| "observed evidence is available after the knowledge cutoff" | ||
| } | ||
| Self::InvalidIntervalPayload => "invalid prediction-contradiction payload", | ||
| Self::AgreementSliceMismatch => "agreement slices are empty or length-mismatched", | ||
| }; | ||
| formatter.write_str(message) | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for PredictionContradictionError {} | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::PredictionContradictionError; | ||
|
|
||
| #[test] | ||
| fn error_messages_are_stable() { | ||
| for (error, message) in [ | ||
| ( | ||
| PredictionContradictionError::PredictionContradictsObservation, | ||
| "predicted interval contradicts observed evidence", | ||
| ), | ||
| ( | ||
| PredictionContradictionError::PredictionLacksOverlappingSupport, | ||
| "predicted interval is adjacent to observation without overlapping support", | ||
| ), | ||
| ( | ||
| PredictionContradictionError::PredictionLacksFullSupport, | ||
| "predicted interval is not fully supported by observed evidence", | ||
| ), | ||
| ( | ||
| PredictionContradictionError::EvidenceAfterCutoff, | ||
| "observed evidence is available after the knowledge cutoff", | ||
| ), | ||
| ( | ||
| PredictionContradictionError::InvalidIntervalPayload, | ||
| "invalid prediction-contradiction payload", | ||
| ), | ||
| ( | ||
| PredictionContradictionError::AgreementSliceMismatch, | ||
| "agreement slices are empty or length-mismatched", | ||
| ), | ||
| ] { | ||
| assert_eq!(error.to_string(), message); | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.