feat(event): score TDT story segments with WindowDiff and Pk - #72
Conversation
Keep story cuts as detection evidence. Refuse instance and transition promotion, and compute WindowDiff, Pk, and boundary recovery against known truth.
|
Warning Review limit reached
Next review available in: 33 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # CHANGELOG.md # DOCUMENTATION.md # docs/TRACEABILITY.md
|
Revalidated at current HEAD
Please run protected current-head Checks and obtain an independent qualifying approval before normal merge. |
|
Current-head review refresh for ce5c5a7:
|
|
Exact-head review receipt for PR #72 after normal main synchronization. Current PR head: 8996569 The story-segmentation branch was synchronized with protected main through a normal merge. CHANGELOG.md and the two overlapping ADR maturity sections were merged without dropping either the TDT segmentation capability or naruon loopback capability. Inherited documentation whitespace was corrected so the exact-head diff is clean. Local proof at this exact HEAD: Rust 1.97.1 cargo fmt --check; cargo test --workspace --offline including six story-segmentation contracts; documentation validation; workspace contract; git diff --check; CodeGraph sync; CodeReviewGraph update against protected main. @cwl-noema-review @opencode-agent Please issue a formal independent review verdict for exactly 8996569. Review only; do not modify files, push, approve on behalf of another identity, or merge. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head899656968cc9f68a3d8fc55dddc4fd257fb27050. -
Head SHA:
899656968cc9f68a3d8fc55dddc4fd257fb27050 -
Workflow run: 32699622037
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (6 files)"]
S1 --> I1["repository behavior"]
I1 --> Conflict["Merge conflict blocks this path"]
Conflict --> V1["required checks"]
Evidence --> S2["Docs (11 files)"]
S2 --> I2["operator or user guidance"]
I2 --> Conflict["Merge conflict blocks this path"]
Conflict --> V2["docs review"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (6 files)"]
S1 --> I1["repository behavior"]
I1 --> Conflict["Merge conflict blocks this path"]
Conflict --> V1["required checks"]
Evidence --> S2["Docs (11 files)"]
S2 --> I2["operator or user guidance"]
I2 --> Conflict["Merge conflict blocks this path"]
Conflict --> V2["docs review"]
Merge Conflict Guidance
gh pr checkout 72 --repo ContextualWisdomLab/TEPP
git fetch origin main
git merge --no-ff origin/main # or: git rebase origin/main
git status --short
# resolve files, then git add <resolved-files>
# merge path: git commit
# rebase path: git rebase --continue
git push origin HEAD:agent/event-story-segmentation
# rebase path only: git push --force-with-lease origin HEAD:agent/event-story-segmentation |
1 participant
Summary
#45 remains preferred merge (
deac1d6, ready, MERGEABLE BLOCKED). CodeRabbit COMMENTED only; no qualifying independent APPROVE. Do not self-approve or force-merge. Do not leapfrog #45 with #43.Next no-0008 gap: ADR 0016 TDT story-segmentation
WindowDiff/Pk/boundary precision-recall and segmentation-versus-instance refusal in existingevent_core(does not recreate TDT/CHRONOS,topic_measurement,psychometric_core,compute_backend,concept_dictionary,model_selection,interpretation_gateway, ornetwork_analysis, and does not allocate 0008).refuse_story_segmentation_as_instance/refuse_story_segmentation_as_transitionnever promote a detected story cutstory_window_diffandstory_pkfail closed on empty, misaligned, or oversized windowsstory_boundary_precisionandstory_boundary_recallfail closed on empty recovered or truth boundary setsdecide_story_boundaryuses an inclusive probability thresholdTest plan
story_segmentation_contractfailed to compile beforesegment.rsexistedcargo test -p event_core --offline --lib --testscargo clippy -p event_core --all-targets --offline -- -D warningscargo test --workspace --offline --lib --testspython3 scripts/validate_documentation.pyand docstring/workspace contractsDo not self-approve or merge. Prefer merge #45 when exact-head required checks and a qualifying independent APPROVE exist. Do not allocate 0008.