feat(api): list accepted temporal-context identities via loopback CLI - #450
Conversation
Publish tepp-temporal-contexts list so operators mint LineageWeave GET /v1/temporal-context onto spawned tepp-loopback TCP. Receipts stay metric-free temporal_association_only. Naruon is refused. NaruonLiveService stays POST-only. ADR 0082.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Closing under the active WIP circuit breaker. This is a one-operation CLI stacked on now-closed #449; its useful typed-exchange, framing, CLI parsing, metric-refusal and stdout tests remain branch/review lineage for the coherent Temporal Event Knowledge / Analysis Run read-model landing vehicle. The parent #449 also has unresolved atomic-commit, full-request idempotency, pagination-validation, bounded-growth and bounded-serialization RED findings, so this child cannot be a safe replacement vehicle. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Coverage gate evidence is missing
The new production module adds many parser, pagination, and transport branches. The supplied verification omits the mandatory 100% line and branch coverage gate.
Was this helpful? React with 👍 or 👎 to provide feedback.
| refuse_scientific_acceptance(&response.body)?; | ||
| refuse_metrics_on_temporal_context_collection_payload(&response.body)?; | ||
| refuse_event_pii(&response.body)?; |
There was a problem hiding this comment.
🟡 Opaque identities can block listing
When an accepted identity contains a forbidden field name, refuse_event_pii rejects the entire valid collection. Operators cannot list that identity or its page.
Prompt for agents
The response filters in crates/tepp_api/src/temporal_context_collection_cli.rs scan raw JSON text, so allowed opaque idempotency-key values containing event_label, actor_references, timeline_events, evidence_text, or tepp.scientific_acceptance.v1 cause valid pages to fail. Replace value-wide substring checks with structural JSON key/schema validation, while preserving the strict TemporalContextCollection DTO validation and metric/PII field refusal. Add tests using accepted identities that contain each reserved substring.
Was this helpful? React with 👍 or 👎 to provide feedback.
1 participant
Summary
GAP-003A unique operator-visible slice: published
tepp-temporal-contexts listmints typedlineageweave_temporal_context_collection_exchangeonto spawnedtepp-loopbackTCP.from_args+ typed exchange +loopback_http1_from_temporal_context_collection_exchange+dispatch/execute/render+ published[[bin]].localhosthost /httporigin / unpublished consumer / credential flags fail closed.inference_status=temporal_association_only. Event labels, actor lists, timeline events, evidence text, findings, RMSE, bias, coverage, SE-gate, causal scores, andtepp.scientific_acceptance.v1never appear.tepp-temporal-context(feat(api): query cutoff-safe temporal context via loopback CLI #414).feat/temporal-context-collection-get-gap-003a). Does not unstack onto main.Explicitly not
Another temporal-context collection GET (#449), temporal-context CLI (#414), project-history collection CLI (#428), export collection CLI (#444), interpretation-run collection CLI (#436), project-history cancel CLI (#448), export cancel CLI (#446), Leiden, Driver p.16, GAP-010 Figma/export, persistence/Compose (#287).
Does not add GET to
NaruonLiveService. Does not open naruon on this LineageWeave-owned adapter. Does not weaken fail-closed. Does not infer causality. No Buyer language. HTTP 200 is not an ADR 0014 claim.Test plan
cargo test -p tepp_api --lib temporal_context_collection_clicargo test -p tepp_api --test temporal_context_collection_cli_contractcargo clippy -p tepp_api --all-targets -- -D warningscargo doc -p tepp_api --no-depspython3 scripts/validate_documentation.pypython3 scripts/check_docstrings.py