Restore 2017-era T0TRAITEFFECT as t0_trait·trait

CHANGELOG.md

@@ -40,6 +40,8 @@ All notable changes to TEPP are documented here. The format follows Keep a Chang
 
 - `event_core` adds bounded Allen interval-consistency classification, atomic path-consistency closure, contradiction/resource refusals, and an explicit dependency-error fallback without claiming unrestricted global satisfiability.
 
+- `psychometric_core` recovers the Driver, Oud, and Voelkle (2017, §4.3, pp. 9–10; §7.1, pp. 18–19; 2017-era ctsem `ctModel.R` / `ctFit.R` / `ctGenerate.R`; JSS PDF re-opened 2026-08-30T17:45Z from https://www.jstatsoft.org/index.php/jss/article/download/v077i05/1104) scalar first-occasion trait effect on current main (register items 112–113). Section 4.3 and §7.1 name traits the stable between-subject differences (`TRAITVAR` `φ_ξ`). The 2017-era `ctModel.R` names `T0TRAITEFFECT` the `n.latent × n.latent` first-occasion trait path and freely labels it when `TRAITVAR` is specified. The 2017-era `ctFit.R` places that matrix in the OpenMx `A` regression block from the trait latents to the process latents at `T0`. The default `stationary` argument includes `'T0TRAITEFFECT'` and then fixes free cells to the identity. The 2017-era `ctGenerate.R` writes `T0MEANS = T0MEANS + T0TRAITEFFECT %*% traits`. The JSS Table 2 / Table 3 do not print `T0TRAITEFFECT`; this crate recovers the 2017-era named matrix, not a new std map. The scalar first-occasion shift is `t0_trait · trait` after finite `t0_trait` and finite trait score. Form `t0_trait` first, then multiply by the trait score. A zero coefficient or zero trait is exactly zero. A signed trait score is a signed shift. The stationary identity default `t0_trait = 1` recovers the trait score and remains a distinct named quantity from the score. `t0_b z` is Table 3 `T0TIPREDEFFECT` and is not this shift even when the numbers equal. `t0_m x0` is Table 3 `T0TDPREDEFFECT` and is not this shift even when the numbers equal. `t0_trait` is the coefficient, not the shift; equal numbers when `trait = 1` remain distinct named quantities. The 2017-era `summary.ctsemFit.R` comments out `T0TRAITVAR = T0TRAITEFFECT %*% TRAITVAR %*% t(T0TRAITEFFECT)` with "is this valid?". This crate does not invent `T0TRAITVAR`. `t0_trait² · TRAITVAR` is that extra variance, not this shift. `T0` is an event-time occasion, so a non-event clock fails closed. An overflowing product fails closed. Free first-occasion trait effect does not require stable `a < 0`. Meredith (1993) remains unread (Unpaywall historically `is_oa: false`; Springer `content/pdf` is an HTML stub). Mislevy (1991, *Psychometrika, 56*, 177–196) remains unread on the same terms (DOI `10.1007/bf02294457`). Still not a Kalman filter, not a matrix `expm`, not ESEM estimation, not DSEM, and not ctsem estimation.
+
 - `psychometric_core` recovers the Driver, Oud, and Voelkle (2017, Table 2, p. 12 `MANIFESTTRAITVAR`; §7.1, p. 19; p. 16 `MANIFESTTRAITVARstd`; footnote 4; 2017-era ctsem `summary.ctsemFit.R`; JSS PDF re-opened 2026-08-27T14:20Z from https://www.jstatsoft.org/index.php/jss/article/download/v077i05/1104) scalar standardised manifest-trait variance on current main after `0ce16e8` dropped the pre-consolidation code while research notes already named the map (register items 83–84). Table 2 names `MANIFESTTRAITVAR` `Ψ_τ` the additional time-invariant variance-covariance on the measurement level and sets it `NULL` when there is no manifest trait. Equation 5 writes `Γ ~ N(τ, Ψ)` and names that covariance the manifest traits. Section 7.1 names manifest traits stable individual differences in indicator levels, distinct from process-level `TRAITVAR` `φ_ξ`. Page 16 prints standardised matrices with the suffix `std` when appropriate. The printed example on p. 16 is `discreteDRIFTstd`, not `MANIFESTTRAITVARstd`. Footnote 4 standardises using only the relevant variance, not the total. The relevant variance for that named indicator-level correlation is `MANIFESTTRAITVAR`, not process-level `TRAITVAR` and not residual `MANIFESTVAR` `θ`. The 2017-era source forms `MANIFESTTRAITVARstd` only when `MANIFESTTRAITVAR != 0`, as `solve(sqrt(diag(MANIFESTTRAITVAR) + ridging)) %&% MANIFESTTRAITVAR` when `verbose = TRUE`. OpenMx `%&%` is `t(A) %*% B %*% A`. Unlike `TRAITVARstd`, that formation adds `diag(c(ridging), n.manifest)`. The default `ridging = FALSE` adds 0, not `0.0001`; that ridge is a numerical hack and is not this exact map. The scalar correlation is `ψ / ψ = 1` after strictly positive `MANIFESTTRAITVAR`. Form strictly positive `ψ` first, then `1 / √ψ`, then `(1 / √ψ) ψ (1 / √ψ)`. Unstandardised `MANIFESTTRAITVAR` is defined for a zero trait; standardised `MANIFESTTRAITVAR` is not. Zero `MANIFESTTRAITVAR` skips forming `MANIFESTTRAITVARstd` in the 2017-era source and fails closed here. Indicator-level trait variance is an event-time structural quantity, so a non-event clock fails closed. `MANIFESTTRAITVAR` does not require stable `a < 0`. Distinct positive `ψ` recover the same 1. `trait / trait = 1` is `TRAITVARstd` and recovers the same number and remains a distinct named quantity. `θ` is `MANIFESTVAR` and is measurement error, not this correlation. Meredith (1993) remains unread (web search 2026-08-27T14:20Z: Springer/Cambridge Core paywalled; Unpaywall historically `is_oa: false`; Springer `content/pdf` is an HTML stub). Mislevy (1991, *Psychometrika, 56*, 177–196) remains unread on the same terms (DOI `10.1007/bf02294457`). Still not a Kalman filter, not a matrix `expm`, not ESEM estimation, not DSEM, and not ctsem estimation.
 
 - `psychometric_core` recovers the Driver, Oud, and Voelkle (2017, Table 2, p. 12 `TRAITVAR`; §7.1, pp. 18–19; p. 16 `TRAITVARstd`; footnote 4; 2017-era ctsem `summary.ctsemFit.R`; JSS PDF re-opened 2026-08-26T17:45Z from https://www.jstatsoft.org/index.php/jss/article/download/v077i05/1104) scalar standardised trait variance on current main after `0ce16e8` dropped the pre-consolidation code while research notes already named the map (register items 81–82). Table 2 names `TRAITVAR` `φ_ξ` the latent trait variance/covariance and sets it `NULL` when there is no trait. Section 7.1 names traits the stable between-subject differences (unit-level unobserved heterogeneity). Page 16 prints standardised matrices with the suffix `std` when appropriate. The printed example on p. 16 is `discreteDRIFTstd`, not `TRAITVARstd`. Footnote 4 standardises using only the relevant variance, not the total. The relevant variance for that named between-subject correlation is `TRAITVAR`, not free first-occasion `T0VAR` and not process-dynamics `asymDIFFUSION`. The 2017-era source forms `TRAITVARstd` only when `TRAITVAR != 0`, as `solve(sqrt(diag(TRAITVAR))) %&% TRAITVAR` when `verbose = TRUE`. OpenMx `%&%` is `t(A) %*% B %*% A`. Unlike `T0VARstd`, that formation uses `diag(diag(TRAITVAR))` and does not add `diag(c(ridging))`. The ridge is a `T0VAR` numerical hack and is not this exact map. The scalar correlation is `trait / trait = 1` after strictly positive `TRAITVAR`. Form strictly positive `trait` first, then `1 / √trait`, then `(1 / √trait) trait (1 / √trait)`. Unstandardised `TRAITVAR` is defined for a zero trait; standardised `TRAITVAR` is not. Zero `TRAITVAR` skips forming `TRAITVARstd` in the 2017-era source and fails closed here. Between-subject variance is an event-time structural quantity, so a non-event clock fails closed. `TRAITVAR` does not require stable `a < 0`. Distinct positive `trait` recover the same 1. `p_0 / p_0 = 1` is `T0VARstd` and recovers the same number and remains a distinct named quantity. `t0_b² v` is `addedT0TIPREDVAR` and is extra first-occasion TI variance, not this correlation. Meredith (1993) remains unread (Unpaywall 2026-08-26T17:20Z: `is_oa: false`; OpenAlex closed; Springer `content/pdf` is an HTML stub). Mislevy (1991, *Psychometrika, 56*, 177–196) remains unread on the same terms (DOI `10.1007/bf02294457`; Unpaywall `is_oa: false`). Still not a Kalman filter, not a matrix `expm`, not ESEM estimation, not DSEM, and not ctsem estimation.

crates/psychometric_core/src/error.rs

@@ -710,6 +710,32 @@ pub enum PsychometricError {
     /// `MANIFESTVARstd`. `λ² Var(η) + θ` is `Var(y)`, not the
     /// correlation form of `Θ`.
     ObservedVarianceIsNotStandardisedManifestVariance,
+
+    /// Driver Table 3 `T0TIPREDEFFECT` `t0_b z` was treated as
+    /// 2017-era `T0TRAITEFFECT`. The TI first-occasion shift is a
+    /// predictor effect; `T0TRAITEFFECT` is the RAM `A`-path from
+    /// traits to latents at `T0`. Equal numbers when `t0_b z =
+    /// t0_trait · trait` remain distinct named quantities.
+    InitialTimeIndependentEffectIsNotInitialTraitEffect,
+    /// Driver Table 3 `T0TDPREDEFFECT` `t0_m x0` was treated as
+    /// 2017-era `T0TRAITEFFECT`. The TD first-occasion shift is a
+    /// predictor effect; `T0TRAITEFFECT` is the trait path into
+    /// `T0MEANS`. Equal numbers when `t0_m x0 = t0_trait · trait`
+    /// remain distinct named quantities.
+    InitialTimeDependentEffectIsNotInitialTraitEffect,
+    /// 2017-era `T0TRAITEFFECT` `t0_trait` was treated as the
+    /// first-occasion trait shift. The coefficient is the RAM
+    /// `A`-path; the shift is `t0_trait · trait`. Equal numbers
+    /// when `trait = 1` remain distinct named quantities.
+    InitialTraitCoefficientIsNotInitialTraitEffect,
+    /// Commented 2017-era `T0TRAITVAR` `t0_trait² · TRAITVAR` was
+    /// treated as `T0TRAITEFFECT`. That quadratic form is extra
+    /// first-occasion trait variance (`summary.ctsemFit.R` comments
+    /// it out with "is this valid?"); this crate does not invent
+    /// it. The shift is `t0_trait · trait`, not that extra. Equal
+    /// numbers when `t0_trait = trait = TRAITVAR` remain distinct
+    /// named quantities.
+    InitialTraitExtraVarianceIsNotInitialTraitEffect,
 }
 
 impl fmt::Display for PsychometricError {
@@ -1235,6 +1261,18 @@ impl fmt::Display for PsychometricError {
             Self::ObservedVarianceIsNotStandardisedManifestVariance => {
                 "observed-indicator variance is not standardised measurement-error variance"
             }
+            Self::InitialTimeIndependentEffectIsNotInitialTraitEffect => {
+                "first-occasion time-independent predictor effect is not the first-occasion trait effect"
+            }
+            Self::InitialTimeDependentEffectIsNotInitialTraitEffect => {
+                "first-occasion time-dependent predictor effect is not the first-occasion trait effect"
+            }
+            Self::InitialTraitCoefficientIsNotInitialTraitEffect => {
+                "first-occasion trait coefficient is not the first-occasion trait effect"
+            }
+            Self::InitialTraitExtraVarianceIsNotInitialTraitEffect => {
+                "first-occasion extra trait variance is not the first-occasion trait effect"
+            }
         };
         formatter.write_str(message)
     }
@@ -2073,4 +2111,24 @@ mod tests {
             "measurement error is not standardised manifest-trait variance"
         );
     }
+
+    #[test]
+    fn initial_trait_effect_boundary_messages_are_stable() {
+        assert_eq!(
+            PsychometricError::InitialTimeIndependentEffectIsNotInitialTraitEffect.to_string(),
+            "first-occasion time-independent predictor effect is not the first-occasion trait effect"
+        );
+        assert_eq!(
+            PsychometricError::InitialTimeDependentEffectIsNotInitialTraitEffect.to_string(),
+            "first-occasion time-dependent predictor effect is not the first-occasion trait effect"
+        );
+        assert_eq!(
+            PsychometricError::InitialTraitCoefficientIsNotInitialTraitEffect.to_string(),
+            "first-occasion trait coefficient is not the first-occasion trait effect"
+        );
+        assert_eq!(
+            PsychometricError::InitialTraitExtraVarianceIsNotInitialTraitEffect.to_string(),
+            "first-occasion extra trait variance is not the first-occasion trait effect"
+        );
+    }
 }