Skip to content

fix(workflow): pin scheduler budget hardening - #177

Merged
seonghobae merged 3 commits into
mainfrom
fix/central-scheduler-budget-pin
Aug 24, 2026
Merged

fix(workflow): pin scheduler budget hardening#177
seonghobae merged 3 commits into
mainfrom
fix/central-scheduler-budget-pin

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Hourly PR maintenance was pinned to an older central scheduler revision. The current central scheduler adds fail-closed validation and organization-wide review-dispatch/branch-update budgets; the older pin reset those budgets per repository and could enqueue excessive long-running review jobs.

Changes:

  • Pin hourly-pr-maintenance.yml to verified central revision 8319ae5beda1b4dcbc9c2b189f38d951c2c61b7a.
  • Update the executable caller contract to bind the exact immutable revision.

Verification:

  • python3 -m pytest -q tests/quality: 89 passed, 18 subtests
  • python3 scripts/check_workspace_contract.py: PASS
  • python3 scripts/check_docstrings.py: PASS
  • git diff --check: PASS
  • actionlint hourly-pr-maintenance.yml: PASS

Merge remains subject to current-head required Checks, unresolved-thread resolution, and qualifying independent approvals.


Open in Devin Review

Summary by CodeRabbit

  • 개선 사항
    • 예약된 PR 검토 및 병합 작업이 최신 중앙 스케줄러 버전을 사용하도록 업데이트되었습니다.
    • 관련 품질 검증도 최신 버전에 맞게 조정되었습니다.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 33 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cd37acbb-0a7c-4cd8-bcd2-749a93791e35

📥 Commits

Reviewing files that changed from the base of the PR and between 8a5dee5 and 580d452.

📒 Files selected for processing (2)
  • .github/workflows/hourly-pr-maintenance.yml
  • tests/quality/test_hourly_maintenance_caller.py

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 22953d1b-44cf-4178-b270-286479104fff

📥 Commits

Reviewing files that changed from the base of the PR and between 7c29e7c and 8a5dee5.

📒 Files selected for processing (2)
  • .github/workflows/hourly-pr-maintenance.yml
  • tests/quality/test_hourly_maintenance_caller.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

중앙 PR 리뷰·병합 스케줄러의 커밋 참조를 업데이트했습니다. GitHub Actions 워크플로와 호출자 테스트의 스케줄러 리비전을 새 커밋으로 동기화했습니다.

Changes

스케줄러 커밋 참조 업데이트

Layer / File(s) Summary
워크플로 및 테스트 참조 동기화
.github/workflows/hourly-pr-maintenance.yml, tests/quality/test_hourly_maintenance_caller.py
PR 유지보수 워크플로의 uses 참조와 CENTRAL_SCHEDULER_REVISION을 새 중앙 스케줄러 커밋으로 변경했습니다.

Estimated code review effort: 1 (매우 낮음) | ~2분

Merge Risk: ⚪ Minimal · up to 8a5de

The workflow now uses the verified immutable scheduler revision with matching contract coverage, and no actionable merge-blocking risk remains beyond normal required checks and approvals.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 워크플로에서 스케줄러 리비전을 고정하고 예산 검증을 강화하는 주요 변경 사항을 명확하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/central-scheduler-budget-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review request: please review commit 8a5dee5 against base 7c29e7c. Scope: central scheduler revision pin, organization-wide review/branch-update budget behavior, immutable workflow reference, and the two-file caller contract. Local quality tests pass; hosted Checks are queued. Do not approve or merge on stale evidence. Final merge remains subject to current-head required Checks, resolved threads, and qualifying independent approvals.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent @cwl-noema-review

Review-only request for exact current head `8a5dee50d4b0fa2396893ad26fa775f2629e2fcd`. Re-review scheduler budget hardening, immutable workflow provenance, secret isolation, edge tests, and protected-merge requirements. Do not merge or enable auto-merge.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Queued @cwl-noema-review and @opencode-agent for PR #177 at head 8a5dee50d4b0fa2396893ad26fa775f2629e2fcd. Central exact-name Actions artifacts are the durable dispatch ledger; existing review workflows remain authoritative for the final verdict and failure evidence.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head review refresh for 8a5dee5:

  • The hourly scheduler budget is pinned through a deterministic contract and remains bounded for autonomous product-loop execution.
  • git diff --check, documentation validation, workspace contract, docstring contract, and cargo fmt --all -- --check passed locally.
  • Current hosted checks are pass=13, pending=1, fail=0; merge remains withheld until the pending exact-head required check completes and qualifying independent approvals exist.
  • No new actionable source defect was found at this exact head; no approval is being self-issued.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review receipt for PR #177 after normal main synchronization.

Current PR head: 273cbed
Base protected main: c45be17

The hourly scheduler caller now pins the central PR-review scheduler to immutable revision 8319ae5beda1b4dcbc9c2b189f38d951c2c61b7a, and its contract test uses the same revision. The branch was synchronized with protected main through a normal merge without conflict.

Local proof at this exact HEAD: 48 targeted hourly/Actions quality tests passed; documentation validation; workspace contract; git diff --check; CodeGraph sync; CodeReviewGraph update against protected main.

@cwl-noema-review @opencode-agent Please issue a formal independent review verdict for exactly 273cbed. Review only; do not modify files, push, approve on behalf of another identity, or merge.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head update: 580d452.\n\nRoot cause fixed: the previous caller pinned the central reusable workflow blob SHA 8319ae5, not a commit SHA. The caller and contract test now pin the independently verified .github main commit 731af58e954901c4f1cc853231c592abb1eaf617.\n\nFresh verification: hourly maintenance caller contract 2 passed; documentation, workspace, rustdoc, and diff checks passed; GitHub API confirmed central commit 731af58.\n\nPlease review this exact head. coverage-evidence remains queued and qualifying independent approval is absent; no merge or bypass is requested.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

Open in Devin Review

Comment thread .github/workflows/hourly-pr-maintenance.yml
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review disposition

The only unresolved Devin note was verified against live ContextualWisdomLab/.github state. The valid central scheduler commit is 731af58e954901c4f1cc853231c592abb1eaf617, and both the workflow and executable contract pin it. The description value 8319ae5beda1b4dcbc9c2b189f38d951c2c61b7a is the workflow blob SHA, not a commit and not a valid reusable-workflow ref, so no source change is required.

The thread was replied to with this evidence and resolved. Hosted Strix remains in progress and coverage-source-tree remains queued; no qualifying independent approval is present. Decision: WAIT_AND_REMEDIATE; no merge or bypass performed.

@seonghobae
seonghobae enabled auto-merge (squash) August 24, 2026 00:55
@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head review disposition

  • Exact head: 580d45206536bf2f7deba327ffafb96a69ba7260; base: c45be17a9dbce95ef81cee230e9d128abc7160ac.
  • The two-line change is bounded to replacing the central reusable scheduler reference with verified commit 731af58e954901c4f1cc853231c592abb1eaf617; GitHub confirms that commit and the workflow path. The caller contract pins the same commit. No source defect found.
  • Hosted Checks are green for the recorded head; CodeRabbit found no actionable comments.
  • REVIEW_REQUIRED: no qualifying independent approval is present, so protected normal merge cannot proceed. No bypass is authorized. Decision: WAIT_AND_REMEDIATE.

@seonghobae
seonghobae merged commit 088fd64 into main Aug 24, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant