Repository navigation
feat(privacy): refuse untrusted intake without a grant #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
f96cbff
97e603b
0196a24
89dca1c
f46a14b
387e42d
5082f94
13256dd
46b2849
a562add
d558a4b
7547992
0c3dfb2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| [package] | ||
| name = "intake_authorization" | ||
| description = "Untrusted intake fails closed without a grant; bounds are not authorization." | ||
| version.workspace = true | ||
| edition.workspace = true | ||
| rust-version.workspace = true | ||
| license.workspace = true | ||
| authors.workspace = true | ||
| repository.workspace = true | ||
| homepage.workspace = true | ||
| readme.workspace = true | ||
| keywords.workspace = true | ||
| categories.workspace = true | ||
| publish = false | ||
|
|
||
| [lints] | ||
| workspace = true |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| //! Fail-closed intake-authorization errors. | ||
|
|
||
| use std::fmt; | ||
|
|
||
| /// A fail-closed intake-authorization error. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| #[non_exhaustive] | ||
| pub enum IntakeAuthorizationError { | ||
| /// Intake was attempted without a purpose-bound grant. | ||
| MissingGrant, | ||
| /// Size, identity, or provenance bounds were treated as authorization. | ||
| BoundsAreNotAuthorization, | ||
| /// A recovery slice was empty or length-mismatched. | ||
| InvalidIntakePayload, | ||
| } | ||
|
|
||
| impl fmt::Display for IntakeAuthorizationError { | ||
| fn fmt(&self, formatter: &mut fmt::Formatter<'_>) -> fmt::Result { | ||
| let message = match self { | ||
| Self::MissingGrant => "untrusted intake requires a purpose-bound grant", | ||
| Self::BoundsAreNotAuthorization => { | ||
| "identity, provenance, size, and depth bounds are not authorization" | ||
| } | ||
| Self::InvalidIntakePayload => "invalid intake-authorization payload", | ||
| }; | ||
| formatter.write_str(message) | ||
| } | ||
| } | ||
|
|
||
| impl std::error::Error for IntakeAuthorizationError {} | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::IntakeAuthorizationError; | ||
|
|
||
| #[test] | ||
| fn error_messages_are_stable() { | ||
| for (error, message) in [ | ||
| ( | ||
| IntakeAuthorizationError::MissingGrant, | ||
| "untrusted intake requires a purpose-bound grant", | ||
| ), | ||
| ( | ||
| IntakeAuthorizationError::BoundsAreNotAuthorization, | ||
| "identity, provenance, size, and depth bounds are not authorization", | ||
| ), | ||
| ( | ||
| IntakeAuthorizationError::InvalidIntakePayload, | ||
| "invalid intake-authorization payload", | ||
| ), | ||
| ] { | ||
| assert_eq!(error.to_string(), message); | ||
| } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,152 @@ | ||
| //! Grant presence required at untrusted intake. | ||
|
|
||
| use crate::IntakeAuthorizationError; | ||
|
|
||
| /// Closed vocabulary of untrusted inbound kinds that require a grant. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| pub enum IntakeKind { | ||
| /// External document bytes. | ||
| Document, | ||
| /// Serialized domain or wire record. | ||
| SerializedRecord, | ||
| /// Model checkpoint or artifact bytes. | ||
| ModelCheckpoint, | ||
| /// LLM or agent output. | ||
| LlmOutput, | ||
| } | ||
|
|
||
| impl IntakeKind { | ||
| /// Return the stable wire intake-kind name. | ||
| #[must_use] | ||
| pub const fn wire_name(self) -> &'static str { | ||
| match self { | ||
| Self::Document => "document", | ||
| Self::SerializedRecord => "serialized_record", | ||
| Self::ModelCheckpoint => "model_checkpoint", | ||
| Self::LlmOutput => "llm_output", | ||
| } | ||
| } | ||
|
|
||
| /// Parse a stable wire intake-kind name. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns [`IntakeAuthorizationError::InvalidIntakePayload`] for | ||
| /// unrecognized names. | ||
| pub fn from_wire_name(name: &str) -> Result<Self, IntakeAuthorizationError> { | ||
| match name { | ||
| "document" => Ok(Self::Document), | ||
| "serialized_record" => Ok(Self::SerializedRecord), | ||
| "model_checkpoint" => Ok(Self::ModelCheckpoint), | ||
| "llm_output" => Ok(Self::LlmOutput), | ||
| _ => Err(IntakeAuthorizationError::InvalidIntakePayload), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| /// Whether a purpose-bound grant is present at intake. | ||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | ||
| pub enum GrantPresence { | ||
| /// A grant exists for this intake. | ||
| Present, | ||
| /// No grant exists for this intake. | ||
| Absent, | ||
| } | ||
|
|
||
| /// Refuse untrusted intake that has no purpose-bound grant. | ||
| /// | ||
| /// Cross-purpose reuse of a present grant is owned by `purpose_authorization`. | ||
| /// Identity, provenance, size, and depth are owned by `payload_bound`. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns [`IntakeAuthorizationError::MissingGrant`] when `grant` is | ||
| /// [`GrantPresence::Absent`]. | ||
| pub fn refuse_intake_without_grant( | ||
| kind: IntakeKind, | ||
| grant: GrantPresence, | ||
| ) -> Result<(), IntakeAuthorizationError> { | ||
| let _ = kind.wire_name(); | ||
| match grant { | ||
| GrantPresence::Absent => Err(IntakeAuthorizationError::MissingGrant), | ||
| GrantPresence::Present => Ok(()), | ||
| } | ||
| } | ||
|
|
||
| /// Refuse to treat size, identity, or provenance bounds as authorization. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Always returns [`IntakeAuthorizationError::BoundsAreNotAuthorization`]. | ||
| pub fn refuse_bounds_as_authorization() -> Result<(), IntakeAuthorizationError> { | ||
| Err(IntakeAuthorizationError::BoundsAreNotAuthorization) | ||
| } | ||
|
|
||
| /// Fraction of recovered grant-presence flags that match known truth. | ||
| /// | ||
| /// # Errors | ||
| /// | ||
| /// Returns [`IntakeAuthorizationError::InvalidIntakePayload`] when either | ||
| /// slice is empty or the lengths differ. | ||
| pub fn identity_recovery_rate( | ||
| truth: &[bool], | ||
| decided: &[bool], | ||
| ) -> Result<f64, IntakeAuthorizationError> { | ||
| if truth.is_empty() || truth.len() != decided.len() { | ||
| return Err(IntakeAuthorizationError::InvalidIntakePayload); | ||
| } | ||
| let mut matches = 0_u32; | ||
| for (truth_flag, decided_flag) in truth.iter().zip(decided) { | ||
| if truth_flag == decided_flag { | ||
| matches += 1; | ||
| } | ||
| } | ||
| Ok(f64::from(matches) / truth.len() as f64) | ||
|
Comment on lines
+98
to
+104
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📝 Info: identity_recovery_rate match counter is u32 while inputs are unbounded slices In intake.rs, Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::{ | ||
| GrantPresence, IntakeKind, identity_recovery_rate, refuse_bounds_as_authorization, | ||
| refuse_intake_without_grant, | ||
| }; | ||
| use crate::IntakeAuthorizationError; | ||
|
|
||
| #[test] | ||
| fn local_branches_cover_kinds_grants_and_payloads() { | ||
| for kind in [ | ||
| IntakeKind::Document, | ||
| IntakeKind::SerializedRecord, | ||
| IntakeKind::ModelCheckpoint, | ||
| IntakeKind::LlmOutput, | ||
| ] { | ||
| assert_eq!( | ||
| refuse_intake_without_grant(kind, GrantPresence::Absent), | ||
| Err(IntakeAuthorizationError::MissingGrant) | ||
| ); | ||
| refuse_intake_without_grant(kind, GrantPresence::Present).expect("present"); | ||
| assert_eq!( | ||
| IntakeKind::from_wire_name(kind.wire_name()).expect("round-trip"), | ||
| kind | ||
| ); | ||
| } | ||
| assert_eq!( | ||
| refuse_bounds_as_authorization(), | ||
| Err(IntakeAuthorizationError::BoundsAreNotAuthorization) | ||
| ); | ||
| assert_eq!( | ||
| IntakeKind::from_wire_name("trusted"), | ||
| Err(IntakeAuthorizationError::InvalidIntakePayload) | ||
| ); | ||
| let matched = identity_recovery_rate(&[true], &[true]).expect("rate"); | ||
| assert!((matched - 1.0).abs() < f64::EPSILON); | ||
| assert_eq!( | ||
| identity_recovery_rate(&[], &[]), | ||
| Err(IntakeAuthorizationError::InvalidIntakePayload) | ||
| ); | ||
| assert_eq!( | ||
| identity_recovery_rate(&[true], &[]), | ||
| Err(IntakeAuthorizationError::InvalidIntakePayload) | ||
| ); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #![forbid(unsafe_code)] | ||
| #![deny(missing_docs)] | ||
| #![allow(clippy::cast_precision_loss)] | ||
| //! Untrusted intake fails closed without a grant; bounds are not authorization. | ||
| //! | ||
| //! Documents, serialized records, checkpoints, and LLM outputs require a | ||
| //! purpose-bound grant at the intake boundary. Passing size or identity | ||
| //! bounds is not that grant (ADR 0009; AGENTS.md). | ||
|
|
||
| mod error; | ||
| mod intake; | ||
|
|
||
| /// Fail-closed intake-authorization errors. | ||
| pub use error::IntakeAuthorizationError; | ||
| /// Whether a purpose-bound grant is present at intake. | ||
| pub use intake::GrantPresence; | ||
| /// Closed vocabulary of untrusted inbound kinds that require a grant. | ||
| pub use intake::IntakeKind; | ||
| /// Fraction of recovered grant-presence flags that match known truth. | ||
| pub use intake::identity_recovery_rate; | ||
| /// Refuse to treat size, identity, or provenance bounds as authorization. | ||
| pub use intake::refuse_bounds_as_authorization; | ||
| /// Refuse untrusted intake that has no purpose-bound grant. | ||
| pub use intake::refuse_intake_without_grant; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| //! Integration contract for the `intake_authorization` package identity. | ||
|
|
||
| #[test] | ||
| fn package_identity_is_stable() { | ||
| let observed = std::hint::black_box(env!("CARGO_PKG_NAME")); | ||
| assert_eq!(observed, "intake_authorization"); | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| //! Untrusted intake fails closed without a grant; bounds are not authorization. | ||
|
|
||
| use intake_authorization::{ | ||
| GrantPresence, IntakeAuthorizationError, IntakeKind, identity_recovery_rate, | ||
| refuse_bounds_as_authorization, refuse_intake_without_grant, | ||
| }; | ||
|
|
||
| #[test] | ||
| fn untrusted_intake_fails_closed_without_a_grant() { | ||
| for kind in [ | ||
| IntakeKind::Document, | ||
| IntakeKind::SerializedRecord, | ||
| IntakeKind::ModelCheckpoint, | ||
| IntakeKind::LlmOutput, | ||
| ] { | ||
| assert_eq!( | ||
| refuse_intake_without_grant(kind, GrantPresence::Absent), | ||
| Err(IntakeAuthorizationError::MissingGrant) | ||
| ); | ||
| refuse_intake_without_grant(kind, GrantPresence::Present).expect("grant present"); | ||
| } | ||
| assert_eq!( | ||
| refuse_bounds_as_authorization(), | ||
| Err(IntakeAuthorizationError::BoundsAreNotAuthorization) | ||
| ); | ||
| } | ||
|
|
||
| #[test] | ||
| fn recovered_grant_flags_match_known_truth_better_than_accepting_every_intake() { | ||
| let truth = [true, false, false]; | ||
| let recovered = [true, false, false]; | ||
| let collapsed = [true, true, true]; | ||
| let recovered_rate = identity_recovery_rate(&truth, &recovered).expect("recovered"); | ||
| let collapsed_rate = identity_recovery_rate(&truth, &collapsed).expect("collapsed"); | ||
| let expected = { | ||
| let mut matches = 0_u32; | ||
| for (truth_flag, decided_flag) in truth.iter().zip(recovered.iter()) { | ||
| if truth_flag == decided_flag { | ||
| matches += 1; | ||
| } | ||
| } | ||
| f64::from(matches) / f64::from(u32::try_from(truth.len()).expect("len")) | ||
| }; | ||
| assert!((recovered_rate - expected).abs() < f64::EPSILON); | ||
| assert!(recovered_rate > collapsed_rate); | ||
| } | ||
|
|
||
| #[test] | ||
| fn empty_or_mismatched_grant_flags_fail_closed() { | ||
| assert_eq!( | ||
| identity_recovery_rate(&[], &[]), | ||
| Err(IntakeAuthorizationError::InvalidIntakePayload) | ||
| ); | ||
| assert_eq!( | ||
| identity_recovery_rate(&[true], &[]), | ||
| Err(IntakeAuthorizationError::InvalidIntakePayload) | ||
| ); | ||
| assert_eq!( | ||
| identity_recovery_rate(&[true, false], &[true]), | ||
| Err(IntakeAuthorizationError::InvalidIntakePayload) | ||
| ); | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,10 +31,10 @@ The full APA 7th standards/literature register remains `docs/research/standards- | |
| | posterior ESEM / longitudinal invariance / DSEM | ADR 0005 | future `psychometric_core` | accepted-target | | ||
| | CPU bounded multithreading + GPU/VRAM streaming/parity | ADR 0001/0006 | future `compute_backend` | accepted-target | | ||
| | TDT detection/tracking vs CHRONOS schema/prediction/temporal consistency | ADR 0016; PRD/research | future `event_intelligence` | accepted-target | | ||
| | evidence-bounded LLM interpretation | ADR 0010/0012; PRD | `tepp_api` router plus future `interpretation_gateway` | partial | | ||
| | evidence-bounded LLM interpretation | ADR 0010/0012; PRD | future `interpretation_gateway` | accepted-target | | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 Traceability entry for evidence-bounded LLM interpretation quietly dropped tepp_api router claim TRACEABILITY.md changed the "evidence-bounded LLM interpretation" row from Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| | adaptive direct/verify/committee/conductor test-time compute | ADR 0010; `docs/LLM_ORCHESTRATION.md` | `tepp_api::route_orchestration` + ablation record on the active PR; live contextual-orchestrator execution remaining | partial | | ||
| | purpose-bound PII handling without blanket masking | ADR 0009; `docs/PRIVACY_DATA_GOVERNANCE.md` | `tepp_api` export authorization plus provider-payload minimization / elevated re-identification implemented-main; persistence retention/deletion remaining | partial | | ||
| | tenant/purpose/role/lifetime access and identity separation | ADR 0009; Threat Model | `tepp_api` time-bounded `PurposeGrant` + cross-tenant denial implemented-main; persistent `access_grant` storage remaining | partial | | ||
| | purpose-bound PII handling without blanket masking | ADR 0009; `docs/PRIVACY_DATA_GOVERNANCE.md` | `tepp_api` export authorization plus provider-payload minimization / elevated re-identification implemented-main; `intake_authorization` grant-presence gate on the active PR; persistence retention/deletion remaining | partial | | ||
| | tenant/purpose/role/lifetime access and identity separation | ADR 0009; Threat Model | `tepp_api` time-bounded `PurposeGrant` + cross-tenant denial implemented-main; `intake_authorization` grant-presence gate on the active PR; persistent `access_grant` storage remaining | partial | | ||
| | standalone + modular CWL MSA / no cross-service DB coupling | ADR 0011; `docs/API_CONTRACT.md` | current standalone crates; future service ports | partial | | ||
| | naruon modular artifact consumer boundary | ADR 0011/0012; API contract | `docs/connectors/naruon-artifact-consumer.md` + PR #22 versioned consumer contract on protected main; `tepp_api` HTTP interchange (active PR); live HTTP service remaining | partial | | ||
| | contextual-orchestrator interpretation port boundary | ADR 0010/0011; LLM orchestration | `docs/connectors/contextual-orchestrator-interpretation-port.md`; live port remaining | partial | | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.