Skip to content

fix: close current-head native review gaps - #57

Merged
seonghobae merged 1 commit into
docs/product-technical-gap-baselinefrom
codex/pr41-current-review-repairs
Aug 31, 2026
Merged

fix: close current-head native review gaps#57
seonghobae merged 1 commit into
docs/product-technical-gap-baselinefrom
codex/pr41-current-review-repairs

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep autonomous product proposals Python-only so model-authored Rust and build metadata cannot reach later credentialed builders
  • declare the packed batch and real-scope preflight methods in the native extension stub
  • correct the 30-sample nearest-rank p95 calculation and record the corrective Accelerate measurement

Validation

  • 694 Python tests passed with 100% statement and branch coverage
  • 25 Rust core tests passed with 100% line, function, and region coverage
  • Rust fmt and workspace clippy passed
  • Accelerate 6578x3072x4: min 3.573 ms, mean 4.063 ms, p95 4.604 ms, max 5.686 ms; zero screened top-four mismatches; maximum ambiguity 6

This remains a proof profile only and does not activate an accelerator or prove the consumer 20 ms concurrent SLO.


Devin Review

Signed-off-by: Seongho Bae <me@seonghobae.me>
@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 379ef65a-72a6-4f56-a301-d5e57408ddf2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 877fe04 into docs/product-technical-gap-baseline Aug 31, 2026
7 of 8 checks passed
@seonghobae
seonghobae deleted the codex/pr41-current-review-repairs branch August 31, 2026 12:49

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Devin Review

println!(
"shape={CANDIDATES}x{DIMENSION}x{QUERIES} min_ms={:.3} mean_ms={mean:.3} p95_ms={:.3} max_ms={:.3} bit_mismatches={mismatched} approximate_top4_mismatches={top_four_mismatches} screened_top4_mismatches={screened_top_four_mismatches} maximum_ambiguity={maximum_ambiguity} max_abs_diff={maximum_absolute_difference:e}",
elapsed[0], elapsed[27], elapsed[29]
elapsed[0], elapsed[28], elapsed[29]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Nearest-rank index matches p95

Thirty sorted samples place nearest-rank p95 at rank 29. The zero-based selection elapsed[28] is correct.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +614 to +617
"pyproject.toml",
"SECURITY.md",
}
forbidden_prefixes = (".github/", ".git/")
forbidden_prefixes = (".github/", ".git/", "crates/")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Python-only boundary remains deterministic

OpenCode can edit broadly, but the pre-execution gate rejects crates/ and pyproject.toml. Validation uses the restored trusted native extension.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +104 to +119
def rank_authorized_batch_packed(
self,
model_identity: str,
query_vectors: list[list[float]],
packed_authorization: bytes,
) -> list[
tuple[
tuple[str, str, str, str, str, str, int, int],
str,
str,
int,
str,
str,
list[tuple[str, str, float]],
]
]: ...

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Collection contracts remain aligned

The native binding returns a list as declared. The public adapter converts it to an immutable tuple, preserving its separate contract.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant