feat(core): add typed semantic node query contract - #57
Draft
seonghobae wants to merge 20 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28: a bounded typed semantic node query over already validated observations.
Live dependency and exact head
main:542ca1e9c0a863595b8b6697790005d2471f5413;feat/semantic-node-observation:8e7a7f2563718610cf07e9b2d34e2a6b70be3d21;8e7a7f2563718610cf07e9b2d34e2a6b70be3d21;52d0efafd292f2af5a38f747a10f7a7d80a86de9.The branch was non-destructively reconciled onto the live observation parent. The final fix restores
SemanticNodeQueryandSemanticNodeQueryErrorfrom the actualsrc/root.rscrate entry point; the existing semantic-query integration test had exposed the missing public export at compile time.Exact-current verification
Rust contracts: success;Pinned Chrome for Testing MV3 fixture: success;Production coverage: success;Boundary
This Draft remains a value-level prerequisite only. It adds no browser I/O, BiDi/CDP/WebMCP transport, action execution, policy grant, persistence, secret handling, network authority, model execution, or release claim. Queries match only bounded reviewed role, accessible-name, and descriptive node-action fields; they never expose raw selector languages or grant execution authority. Keep Draft while the browser authority and observation stack remain active.
No independent counted approval is claimed. This scheduled maintenance actor does not self-approve, bypass required checks, alter workflows or rulesets, force-push, tag, release, or publish.