Skip to content

feat(core): add typed semantic node query contract - #57

Draft
seonghobae wants to merge 20 commits into
feat/semantic-node-observationfrom
feat/semantic-node-query
Draft

feat(core): add typed semantic node query contract#57
seonghobae wants to merge 20 commits into
feat/semantic-node-observationfrom
feat/semantic-node-query

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Partial implementation of #28: a bounded typed semantic node query over already validated observations.

Live dependency and exact head

  • Protected main: 542ca1e9c0a863595b8b6697790005d2471f5413;
  • prerequisite feat(core): add bounded semantic node observation contract #52 / feat/semantic-node-observation: 8e7a7f2563718610cf07e9b2d34e2a6b70be3d21;
  • this PR base: 8e7a7f2563718610cf07e9b2d34e2a6b70be3d21;
  • this PR exact head: 52d0efafd292f2af5a38f747a10f7a7d80a86de9.

The branch was non-destructively reconciled onto the live observation parent. The final fix restores SemanticNodeQuery and SemanticNodeQueryError from the actual src/root.rs crate entry point; the existing semantic-query integration test had exposed the missing public export at compile time.

Exact-current verification

  • GitHub Rust contracts: success;
  • GitHub Pinned Chrome for Testing MV3 fixture: success;
  • GitHub Production coverage: success;
  • local Rust 1.97.1 focused semantic-query tests: 5 passed;
  • local locked workspace/all-features tests, strict Clippy, rustdoc, Python compileall, and 153 Python tests: passed.

Boundary

This Draft remains a value-level prerequisite only. It adds no browser I/O, BiDi/CDP/WebMCP transport, action execution, policy grant, persistence, secret handling, network authority, model execution, or release claim. Queries match only bounded reviewed role, accessible-name, and descriptive node-action fields; they never expose raw selector languages or grant execution authority. Keep Draft while the browser authority and observation stack remain active.

No independent counted approval is claimed. This scheduled maintenance actor does not self-approve, bypass required checks, alter workflows or rulesets, force-push, tag, release, or publish.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant