feat(resource): record browser task runtime telemetry - #51
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
Changes브라우저 작업 텔레메트리
Estimated code review effort: 3 (Moderate) | ~25분 Mergeability Score: ⚪ Minimal · up to The PR adds bounded Linux process RSS sampling and telemetry validation without expanding into browser process discovery or attribution. No actionable merge-blocking risk remains at the current head after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant BrowserTask
participant sample_linux_process_rss_bytes
participant parse_linux_proc_status_rss_bytes
participant ResourceSnapshot
participant ResourceGovernor
BrowserTask->>sample_linux_process_rss_bytes: 프로세스 ID로 RSS 샘플링
sample_linux_process_rss_bytes->>parse_linux_proc_status_rss_bytes: /proc/<pid>/status 전달
parse_linux_proc_status_rss_bytes-->>sample_linux_process_rss_bytes: 검증된 RSS 바이트 반환
sample_linux_process_rss_bytes-->>BrowserTask: RSS 바이트 반환
BrowserTask->>ResourceSnapshot: telemetry와 리소스 인자 전달
ResourceSnapshot->>ResourceGovernor: 리소스 스냅샷 전달
ResourceGovernor-->>BrowserTask: 리소스 계획 반환
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headed01297e5fd0e6a97336078e23f49206c0952ef3. -
Head SHA:
ed01297e5fd0e6a97336078e23f49206c0952ef3 -
Workflow run: 32081189934
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: 0105-resource-governor-priority.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: 0105-resource-governor-priority.md"]
R2 --> V2["docs review"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: 0105-resource-governor-priority.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: 0105-resource-governor-priority.md"]
R2 --> V2["docs review"]
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Verified against exact current head 744892c: the alleged missing kernel standards record is already in the current PR diff. docs/doctoring.md adds the “Linux process RSS measurement” decision trace and the APA 7 “Linux Kernel Documentation. (n.d.). The /proc filesystem” reference; CHANGELOG.md and ADR 0105 also retain the same boundary. No duplicate documentation change is warranted. |
1 participant
Partial implementation of #28: a bounded browser/task telemetry value contract that feeds the existing resource governor.
Live exact state
main:542ca1e9c0a863595b8b6697790005d2471f5413;744892c25fd584b061415863b3dbc12b24d7a75e;mainat542ca1e9c0a863595b8b6697790005d2471f5413.The branch validates caller-supplied browser/task RSS bytes, semantic-observation bytes, governed-action latency, and total task duration. RSS conversion is overflow-safe and conservatively rounded to MiB; the Linux
VmRSSparser is bounded and rejects missing, duplicate, malformed, signed, trailing, unsupported-unit, and overflow forms. The branch does not claim independent browser-process provenance.Exact-current review and checks
CHANGES_REQUESTEDreview is bound to predecessor headed01297e5fd0e6a97336078e23f49206c0952ef3and is not current-head evidence;APPROVEDreview is present.Boundary
This is active-PR evidence, not protected-main shipment. It does not discover Chromium processes, aggregate process trees/cgroups, measure JS heap/GPU/VRAM, launch or control Chromium, provide BiDi/CDP transport, persist telemetry, or prove that a supplied PID belongs to the governed browser task.
The live
CWL Central required workflowsruleset currently requires one approving review, resolved threads, and the configured required workflows. No self-approval, bypass, force-push, workflow/ruleset mutation, tag, release, or unsupported shipment claim is made.