-
Notifications
You must be signed in to change notification settings - Fork 0
test(mv3): prove real downloads compatibility #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
39c4544
50138f1
b98c2ca
bedc430
7d25a50
054b32a
5c5f9d0
9259e28
b10e3cc
20f1d83
dd94266
a38d56d
643298d
61a5a64
c58bde7
669e308
27ce890
e1042bf
7bd2d43
7d21945
806f571
6ffb02e
1d391df
8759518
02e4550
7cbc2fa
f410460
319f5b5
6a1ace6
d60f305
ac7f1f5
7fc08e5
ab8a6e9
f6f307f
4e24f41
1141103
d9914c6
3a35b78
9c29a08
e129c28
cbd5d8c
c5e13a1
5b123d9
1c63849
6a6e5f7
c457f1d
58b3d08
1db35c9
484c74d
0a43e09
8ba95b9
208447f
a4b1da1
b299f76
c5e33b4
b01e973
4be3b77
93e4be4
41462e4
3ad1978
4f36c70
656d1bd
61929f0
93d36ef
6963e4d
ecaac90
089116b
3148876
fab11f6
e434ac9
e501797
a45c83e
bf3a2b0
1953a8f
df8565c
84dfe07
dff276c
7b54fdf
e363cec
f0c6c36
803caef
1462650
ed15185
a7a55eb
04e262d
89ec46a
1472862
fe39cef
ff3cdc6
efd2ebf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -63,12 +63,15 @@ jobs: | |
| chmod 0755 \ | ||
| .mv3-browser/chrome-linux64/chrome \ | ||
| .mv3-browser/chromedriver-linux64/chromedriver | ||
| sudo chown root:root .mv3-browser/chrome-linux64/chrome_sandbox | ||
| sudo chmod 4755 .mv3-browser/chrome-linux64/chrome_sandbox | ||
|
|
||
| - name: Execute real MV3 compatibility fixture | ||
| shell: bash | ||
| env: | ||
| CHROME_BIN: ${{ github.workspace }}/.mv3-browser/chrome-linux64/chrome | ||
| CHROMEDRIVER_BIN: ${{ github.workspace }}/.mv3-browser/chromedriver-linux64/chromedriver | ||
| CHROME_DEVEL_SANDBOX: ${{ github.workspace }}/.mv3-browser/chrome-linux64/chrome_sandbox | ||
|
Comment on lines
+66
to
+74
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 Workflow edit adds root-owned setuid sandbox helper This PR modifies mv3-compatibility.yml to Was this helpful? React with 👍 or 👎 to provide feedback. |
||
| run: | | ||
| set -euo pipefail | ||
| "$CHROME_BIN" --version | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Sandbox helper existence is an unchecked archive assumption
sudo chown root:root ...chrome_sandboxruns underset -euo pipefail. If the pinned Chrome for Testing 150.0.7871.129 archive lacks achrome_sandboxmember, the step fails and the lane fails on every run. Worth confirming this member exists in the exact pinned build.Was this helpful? React with 👍 or 👎 to provide feedback.