Skip to content

test(bidi): align media authority contract - #305

Merged
seonghobae merged 1 commit into
codex/bidi-application-completeness-20260909from
codex/bidi-media-contract-repair-20260909
Sep 9, 2026
Merged

test(bidi): align media authority contract#305
seonghobae merged 1 commit into
codex/bidi-application-completeness-20260909from
codex/bidi-media-contract-repair-20260909

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

  • repair stale source-contract assertions after fix(bidi): make reusable application scope explicit #298 removed the unsafe reusable SetReducedMotion command
  • retain the positive assertion that standard BiDi advertises the reduced-motion capability while requiring that the reusable command enum does not mint mutation authority
  • record the reusable test-maintenance rule in AGENTS.md and CLAUDE.md

Traceability

Verification

  • RED at fix(bidi): make reusable application scope explicit #298 head: uv run pytest tests/test_bidi_media_authority_contract.py tests/test_webdriver_bidi_presentation_adapter_contract.py -q produced 2 failures because both older assertions still required SetReducedMotion.
  • GREEN: same command reports 8 passed, 3 subtests passed; cargo test -p originweave-bidi --locked; cargo clippy -p originweave-bidi --all-targets --all-features -- -D warnings; RUSTDOCFLAGS='-D warnings' cargo doc -p originweave-bidi --no-deps --locked; git diff --check.

No release, deployment, merge, Chromium runtime, or complete-coverage claim is made.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1fca5082-fb15-4345-97a7-152931106a27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit d01f45c into codex/bidi-application-completeness-20260909 Sep 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant