ci: stop draft PR jobs from occupying runners - #286
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughPR 활동 유형과 초안 상태에 따른 CI 및 MV3 호환성 워크플로 실행 조건을 추가했습니다. 관련 계약 테스트는 새 트리거 목록과 가드를 검증합니다. Changes워크플로 실행 조건
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 60d6ab3fcd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review, converted_to_draft, closed] |
There was a problem hiding this comment.
This changes when mandatory CI and MV3 compatibility evidence runs, but none of the four changed files documents the new Draft/Ready lifecycle or updates CHANGELOG.md. Without that record, maintainers can mistake Draft-state skipped jobs for verification evidence or miss that ready_for_review is the point at which exact-head checks restart; add the operational documentation and changelog entry required for every change.
AGENTS.md reference: AGENTS.md:L11-L18
Useful? React with 👍 / 👎.
| on: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review, converted_to_draft, closed] |
There was a problem hiding this comment.
When a PR previously triggered this 20-minute lane but its latest diff no longer contains an MV3 path—for example, a follow-up commit reverts those changes—the paths filter prevents the new synchronize, converted_to_draft, or closed workflow run from being created, so the run never reaches this concurrency group and the older MV3 job keeps occupying its runner. GitHub documents that paths controls whether a pull_request workflow runs; handle lifecycle cancellation through an unfiltered trigger so reverted Draft or closed PRs also cancel stale runs.
Useful? React with 👍 / 👎.
1 participant
Summary
Verification
actionlint .github/workflows/ci.yml .github/workflows/mv3-compatibility.ymlgit diff --checkpython3 -m unittest tests.test_repository_contract tests.test_mv3_compatibility_contract(21 passed)This is an Actions-capacity chicken-and-egg repair: 149 stale or Draft runs were canceled immediately before this PR.
Summary by CodeRabbit
Chores
Tests