Skip to content

feat(network): correlate bounded BiDi pointer click response - #258

Draft
seonghobae wants to merge 13 commits into
feat/webdriver-bidi-pointer-click-sendfrom
feat/webdriver-bidi-pointer-click-response
Draft

feat(network): correlate bounded BiDi pointer click response#258
seonghobae wants to merge 13 commits into
feat/webdriver-bidi-pointer-click-sendfrom
feat/webdriver-bidi-pointer-click-response

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Partial implementation of #28. This Draft owns typed local-end response correlation for the transported WebDriver BiDi primary-button click. Protocol success is not an observed DOM/UI post-condition and grants no browser/session/origin/document/policy authority.

Current non-force stack adoption

Current exact head is b8eaa97f7a417c79250b6b760ff214ac03d39b8a, a tree-identical ordinary two-parent adoption over predecessor 5f830324f6d5a47ac213a57528ef95649bdfd0df and current #257 8f1507346f65798a6bf4eaf370d65a2d406a6f44. No source, test, docs, workflow, dependency, gate or authority changed; #255's safe-successor topology is simply carried forward.

Predecessor CI 33965695405 and local numeric 100% evidence belong to predecessor 5f830324... only. Fresh exact-head CI 34003285350 is queued. Do not transfer the predecessor result or blind-rerun while queued.

The response boundary still accepts only the exact outstanding pointer-click correlation and leaves unrelated state untouched on malformed, mismatched-kind or unknown-id input. Keep Draft and parent-first protected integration. No workflow/ruleset/secret mutation, self-approval, bypass, force update, destructive rebase, merge, tag, release or publication was performed.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head restack verification: exact parent #257 ac7b03574ff4c99e32c240bedc3b9a7834a7e57b is repository-native CI GREEN (33770755986; Rust contracts 100700073107, Production coverage 100700073689). This head bd3652892ecc5a7ed5cf3d7faa4ac2b912c0a14d adopts that verified parent non-force while preserving the prior child lineage. Exact parent→child compare is 0 behind and three semantic paths only: crate composition plus the typed pointer-click response source and realistic response test. Parent structural routing/correlation repairs and send-failure coverage are inherited from the parent tree rather than duplicated. Fresh exact-head CI 33881791731 remains queued, so this is not a GREEN/merge-ready claim. Keep Draft; #259 remains parent-first blocked until this exact head is terminally verified.

Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Restacked on exact parent #257 head 53faa74beb48d0e6a77cac2f3b3ef2eca91c094a and repaired the response regression exposed by the parent protocol hardening.

RCA: the remote-error fixture used a code outside the current reviewed WebDriver BiDi ErrorCode vocabulary and omitted the required stacktrace, so it failed envelope admission before testing the intended correlated remote-error consumption. The fixture now uses a complete, valid error envelope; CHANGELOG.md also records the buyer-visible response boundary.

Exact local evidence:

  • focused pointer-click response tests
  • strict all-target Clippy
  • full workspace tests
  • documentation contracts: 22 passed, 177 subtests passed
  • rustdoc with warnings denied
  • pinned nightly production functions/lines/regions/branches: 100%

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head lineage review: live parent is #257 53faa74beb48d0e6a77cac2f3b3ef2eca91c094a, current head is b9415ba8e0376447355caa7fa093eaa0d168f6d9, and fresh compare is 9 ahead / 0 behind. Current exact CI 33901290367 is non-terminal. Earlier bd365289... and ac7b035... evidence is predecessor-only after the non-destructive parent refresh. A successful input.performActions response remains protocol evidence, not the page-observed post-condition.

Commit-Message-Assisted-by: Claude (via Claude Code)
Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Non-force restacked on PR #257 exact head ac73abfe7edd5786a7eb3eaab1a8c773093be7d3; PR #258 is now exact head a61c717e525eb94f5a4aaa68d3bfdabc9152edfd. Verification: rustfmt, all-feature/all-target check, strict Clippy, rustdoc, 141 Python contracts, and CI-equivalent pinned-nightly production function/line/region/branch coverage at 100%. Fresh hosted exact-head checks and ordered parent integration remain required.

Commit-Message-Assisted-by: Claude (via Claude Code)
Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae

Copy link
Copy Markdown
Contributor Author

Non-force restacked on PR #257 exact head ea2b5b78868917219c46f1304558b92490a7f6fe; PR #258 is now exact head f2ceabb3ea50b1959e936503c50cae12f3e6e480. Verification: rustfmt, all-feature/all-target check, strict Clippy, rustdoc, 141 Python contracts, and CI-equivalent pinned-nightly production function/line/region/branch coverage at 100%. Fresh hosted exact-head checks and ordered parent integration remain required.

Retain response admission and the existing bounded socket-observation test while inheriting current connection-provenance prerequisites. Restore native release-contract execution and verify the integrated tree without promoting protocol correlation to browser authority.

Commit-Message-Assisted-by: Codex (via Codex)
Signed-off-by: Seongho Bae <me@seonghobae.me>
Adopt #257 8f15073 without changing this branch tree, carrying the safe teardown-successor topology into typed click-response correlation.

Ordinary two-parent topology adoption only; the response implementation, tests, workflow, gates, and authority boundary are unchanged.

Signed-off-by: Seongho Bae <me@seonghobae.me>
seonghobae added a commit that referenced this pull request Sep 6, 2026
Adopt #258 b8eaa97 without changing this branch tree, carrying the safe teardown-successor topology into navigation observation.

Ordinary two-parent topology adoption only; observation semantics, tests, workflow, gates, and authority are unchanged.

Signed-off-by: Seongho Bae <me@seonghobae.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant