fix(core): expose standard extension-id error contract

[seonghobae]

Buyer-visible defect

ExtensionId::parse exposes public ExtensionIdError, but protected main does not yet ship Rust's standard Display / std::error::Error contract for that canonical trust-boundary parser. Downstream adapters otherwise need special-case diagnostic handling.

Test-first / repair lineage

Historical test-only bc4b682adee2513db70465b64a235711891a3601 required ExtensionIdError: std::error::Error, deterministic operator-safe text, and no fabricated nested source before production support existed. CI 31852429522 / Rust contracts 94930549852 proved the intended compile RED. Production added deterministic Display and source-free std::error::Error.

Intermediate 56e502a25ac12fec911a0c4482e7b342beb70f0e then exposed an independent test-harness defect: expect_err() violated the repository's strict -D clippy::unwrap-used contract. Exact contributor head e3a675ca33d6c438a3321063b7050c280c117f86 retained the panic-free Result inspection repair without changing production behavior.

Fresh protected-main adoption

Fresh live comparison showed e3a675ca33d6c438a3321063b7050c280c117f86 4 ahead / 2 behind current protected main@c789b802fc98a8d7fd8c09d9327f36828054d2a1, with merge base 542ca1e9c0a863595b8b6697790005d2471f5413. The two protected-main commits after that merge base have no net file delta.

Commit ab2e8ebba8a24c0519cebad785ee464304db9523 adopts exact current protected main as a second parent while preserving the contributor tree exactly. The branch advanced by normal non-force fast-forward. Fresh compare is 5 ahead / 0 behind, merge base exactly current protected main, and the semantic delta remains exactly three paths: CHANGELOG.md, crates/originweave-core/src/lib.rs, and crates/originweave-core/tests/extension_error_contract.rs.

The PR is intentionally Draft after this head movement. Historical native GREEN and central review evidence do not transfer.

Exact-current evidence

Current exact head is ab2e8ebba8a24c0519cebad785ee464304db9523; GitHub reports the PR open, Draft, and content-mergeable.

Fresh exact-head workflows are non-terminal:

• CI 33783085492: queued;
• Manifest V3 Compatibility 33783085503: queued;
• SAST Semgrep 33783085731: queued;
• Security Scan 33783085614: queued;
• OSV-Scanner PR 33783086145: queued;
• Scorecard PR 33783085603: queued; and
• one-shot Materialize Rust nightly refresh once 33783085656: completed as skipped and is not product evidence.

No predecessor, queued, skipped, status-only, model-only, author-only, or synthetic result is promoted to exact-current GREEN or approval.

Scope boundary

This PR changes only the standard public extension-ID error contract and its focused test/changelog evidence. It changes no extension-ID parsing semantics, extension/Agent authority, browser execution, network behavior, secret handling, persistence, workflow, or release behavior.

Protected-main AGENTS.md and live GitHub governance remain authoritative. This scheduled writer does not merge, self-approve, force-push, destructively rebase, alter workflows/rulesets/secrets, weaken checks, tag, release, or publish.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: fcb555e9-86fd-48c5-8517-c027a23a6def

📥 Commits

Reviewing files that changed from the base of the PR and between 0c376ac and e033a9b.

📒 Files selected for processing (3)

• CHANGELOG.md
• crates/originweave-core/src/lib.rs
• crates/originweave-core/tests/extension_error_contract.rs

---

📝 Walkthrough

Walkthrough

ExtensionIdError에 표준 Display 및 std::error::Error 구현이 추가되었습니다. 고정된 오류 메시지, 오류 변형, source() 결과를 검증하는 테스트와 변경 로그가 추가되었습니다.

Changes

ExtensionIdError 오류 계약

Layer / File(s)	Summary
오류 계약 구현 및 검증 crates/originweave-core/src/lib.rs, crates/originweave-core/tests/extension_error_contract.rs, CHANGELOG.md	ExtensionIdError가 고정된 표시 문자열을 반환하고 std::error::Error를 구현합니다. 잘못된 식별자 입력, InvalidExtensionId 변형, source() 부재를 테스트합니다. 변경 로그에 오류 계약 항목을 기록합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to e033a

This PR adds the standard Display and Error behavior for extension-ID validation failures with regression coverage and no actionable merge-blocking risk remaining after normal checks and review.

Possibly related PRs

• ContextualWisdomLab/OriginWeave#160: 다른 core 오류 유형에 동일한 Display 및 std::error::Error 계약과 결정적 테스트 패턴을 추가합니다.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR 제목은 ExtensionIdError에 표준 Rust 오류 계약을 공개하는 주요 변경을 정확하고 간결하게 설명합니다.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/extension-id-error-contract

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@cwl-noema-review

Please perform an independent review of exact head e033a9b78f59783205b7eb80394ecce3314d1992 against protected base 0c376acf059be9ddddddfbde1d0189e4f39ef014. Submit a formal review only if this unchanged exact head is acceptable; do not transfer predecessor-head evidence.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 4396ae9e999268bc7a5598ac1cf05faf10b450cc.

• Head SHA: 4396ae9e999268bc7a5598ac1cf05faf10b450cc

• Workflow run: 32175174001

• Workflow attempt: 1

Coverage evidence

Coverage Decision

• Result: FAIL
• Test evidence: not proven passing
• Docstring evidence: not proven passing when configured
• Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: 4396ae9e999268bc7a5598ac1cf05faf10b450cc
• Workflow run: 32175174001
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 4396ae9e999268bc7a5598ac1cf05faf10b450cc.

• Head SHA: 4396ae9e999268bc7a5598ac1cf05faf10b450cc

• Workflow run: 32175174001

• Workflow attempt: 1

Coverage evidence

Coverage Decision

• Result: FAIL
• Test evidence: not proven passing
• Docstring evidence: not proven passing when configured
• Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]

Loading

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Dismissed as stale automated coverage review: exact current head ab2e8eb has terminal successful Rust contracts and Production coverage, with no unresolved review threads. This dismissal does not supply or bypass the required independent approval.