-
Notifications
You must be signed in to change notification settings - Fork 0
fix(core): reject non-digit origin port prefixes #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
12c25f9
test(core): reject non-digit origin port prefixes
seonghobae 222d52f
fix(core): enforce digit-only origin ports
seonghobae 1232eda
fix(core): restore canonical rustfmt newline
seonghobae a6ad10c
docs(changelog): record strict origin port syntax
seonghobae a119190
chore(core): remove unrelated node-handle doc drift
seonghobae 240a66d
docs(core): cite browser port syntax authority
seonghobae b447529
Merge branch 'main' into fix/origin-port-digit-contract
seonghobae 0015a66
Merge branch 'main' into fix/origin-port-digit-contract
opencode-agent[bot] c1ddbba
docs(doctoring): record browser origin port syntax
seonghobae bc9aae1
docs(doctoring): make URL port-state evidence exact
seonghobae 8ed3c6e
docs(changelog): pin URL standard retrieval date
seonghobae 30a85d0
test(core): reproduce non-digit origin port acceptance on current main
seonghobae 3974251
fix(core): require ASCII digits in explicit ports
seonghobae 456fe11
Merge branch 'main' into fix/origin-port-digit-contract
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| use originweave_core::{Origin, OriginError}; | ||
|
|
||
| #[test] | ||
| fn origin_rejects_non_digit_port_prefixes() { | ||
| for input in [ | ||
| "https://example.com:+443", | ||
| "https://example.com:+8443", | ||
| "http://localhost:+80", | ||
| "http://127.0.0.1:+8080", | ||
| "https://[2001:db8::1]:+443", | ||
| ] { | ||
| assert_eq!( | ||
| Origin::parse(input), | ||
| Err(OriginError::InvalidPort), | ||
| "input={input}" | ||
| ); | ||
|
seonghobae marked this conversation as resolved.
|
||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 CHANGELOG not updated for behavior change
The repository contract requires CHANGELOG.md updates for behavior changes, but the actual diff touches only lib.rs and the new test. The PR description claims a three-file diff including CHANGELOG.md; that file is absent from the change.
Was this helpful? React with 👍 or 👎 to provide feedback.